Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elasticache/aws_elasticache_cluster: Enable auto_minor_version_upgrade #23996

Merged
merged 9 commits into from
Apr 7, 2022
Merged

elasticache/aws_elasticache_cluster: Enable auto_minor_version_upgrade #23996

merged 9 commits into from
Apr 7, 2022

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Apr 1, 2022 •
edited

Enables auto_minor_version_upgrade for aws_elasticache_cluster and properly supports auto_minor_version_upgrade for aws_elasticache_replication_group.

Relates #22385

Output from acceptance testing:

$ make testacc PKG=elasticache TESTS='TestAccElastiCacheCluster_|TestAccElastiCacheReplicationGroup_'

--- PASS: TestAccElastiCacheClusterDataSource_Data_basic (497.16s)
--- PASS: TestAccElastiCacheClusterDataSource_Engine_Redis_LogDeliveryConfigurations (734.80s)
--- PASS: TestAccElastiCacheCluster_EngineVersion_redis (1624.58s)

--- PASS: TestAccElastiCacheReplicationGroupDataSource_nonExistent (2.56s)
--- PASS: TestAccElastiCacheReplicationGroupDataSource_Engine_Redis_LogDeliveryConfigurations (786.95s)
--- PASS: TestAccElastiCacheReplicationGroupDataSource_multiAZ (879.79s)
--- PASS: TestAccElastiCacheReplicationGroupDataSource_basic (858.93s)
--- PASS: TestAccElastiCacheReplicationGroupDataSource_clusterMode (921.96s)

--- PASS: TestAccElastiCacheCluster_Memcached_finalSnapshot (2.93s)
--- PASS: TestAccElastiCacheCluster_NumCacheNodes_redis (2.68s)
--- PASS: TestAccElastiCacheCluster_NodeTypeResize_memcached (914.46s)
--- PASS: TestAccElastiCacheCluster_Redis_autoMinorVersionUpgrade (520.87s)
--- PASS: TestAccElastiCacheCluster_Engine_Redis_LogDeliveryConfigurations (867.90s)
--- PASS: TestAccElastiCacheCluster_Redis_finalSnapshot (684.36s)
--- PASS: TestAccElastiCacheCluster_Engine_None (1.99s)
--- SKIP: TestAccElastiCacheCluster_SecurityGroup_ec2Classic (0.83s)
--- PASS: TestAccElastiCacheCluster_snapshotsWithUpdates (490.46s)
--- PASS: TestAccElastiCacheCluster_AZMode_memcached (455.97s)
--- PASS: TestAccElastiCacheCluster_AZMode_redis (474.45s)
--- PASS: TestAccElastiCacheCluster_vpc (469.83s)
--- PASS: TestAccElastiCacheCluster_multiAZInVPC (589.63s)
--- PASS: TestAccElastiCacheCluster_port (443.93s)
--- PASS: TestAccElastiCacheCluster_ReplicationGroupID_singleReplica (1142.04s)
--- PASS: TestAccElastiCacheCluster_ReplicationGroupID_availabilityZone (1164.45s)
--- PASS: TestAccElastiCacheCluster_ReplicationGroupID_multipleReplica (1166.65s)
--- PASS: TestAccElastiCacheCluster_NodeTypeResize_redis (1116.36s)
--- PASS: TestAccElastiCacheCluster_ParameterGroupName_default (443.88s)
--- PASS: TestAccElastiCacheCluster_NumCacheNodes_increaseWithPreferredAvailabilityZones (744.64s)
--- PASS: TestAccElastiCacheCluster_NumCacheNodes_increase (743.01s)
--- PASS: TestAccElastiCacheCluster_PortRedis_default (475.33s)
--- PASS: TestAccElastiCacheCluster_NumCacheNodes_decrease (742.90s)
--- PASS: TestAccElastiCacheCluster_EngineVersion_memcached (1022.70s)
--- PASS: TestAccElastiCacheCluster_Engine_redis (474.67s)
--- PASS: TestAccElastiCacheCluster_Engine_redis_v5 (454.96s)
--- PASS: TestAccElastiCacheCluster_Engine_memcached (476.08s)

--- PASS: TestAccElastiCacheReplicationGroup_clusteringAndCacheNodesCausesError (23.04s)
--- PASS: TestAccElastiCacheReplicationGroup_disappears (665.09s)
--- PASS: TestAccElastiCacheReplicationGroup_autoMinorVersionUpgrade (808.11s)
--- PASS: TestAccElastiCacheReplicationGroup_enableSnapshotting (880.98s)
--- PASS: TestAccElastiCacheReplicationGroup_dataTiering (903.66s)
--- PASS: TestAccElastiCacheReplicationGroup_finalSnapshot (944.20s)
--- PASS: TestAccElastiCacheReplicationGroup_tags (1065.39s)
--- PASS: TestAccElastiCacheReplicationGroup_useCMKKMSKeyID (1150.83s)
--- PASS: TestAccElastiCacheReplicationGroup_ValidationMultiAz_noAutomaticFailover (3.34s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappearsRemoveMemberCluster_atTargetSize (1353.02s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterModeValidation_numNodeGroupsOnSecondary (1396.59s)
--- PASS: TestAccElastiCacheReplicationGroup_enableAuthTokenTransitEncryption (1566.07s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappears_addMemberCluster (1718.08s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappears_noChange (1747.07s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_singleNode (1791.61s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClusters_basic (1901.71s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersFailover_autoFailoverDisabled (2003.14s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_basic (1057.50s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersFailover_autoFailoverEnabled (2176.43s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClusters_multiAZEnabled (2216.73s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_nonClusteredParameterGroup (1286.22s)
--- PASS: TestAccElastiCacheReplicationGroup_multiAzNotInVPC_repeated (902.17s)
--- PASS: TestAccElastiCacheReplicationGroup_vpc (693.33s)
--- PASS: TestAccElastiCacheReplicationGroup_depecatedAvailabilityZones_vpc (825.19s)
--- PASS: TestAccElastiCacheReplicationGroup_enableAtRestEncryption (2635.99s)
--- PASS: TestAccElastiCacheReplicationGroup_multiAzNotInVPC (1015.67s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_updateReplicasPerNodeGroup (2027.60s)
--- PASS: TestAccElastiCacheReplicationGroup_updateParameterGroup (840.63s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappearsRemoveMemberCluster_scaleDown (2979.73s)
--- PASS: TestAccElastiCacheReplicationGroup_updateAuthToken (1128.17s)
--- PASS: TestAccElastiCacheReplicationGroup_updateMaintenanceWindow (848.78s)
--- PASS: TestAccElastiCacheReplicationGroup_updateDescription (837.94s)
--- PASS: TestAccElastiCacheReplicationGroup_updateUserGroups (1084.96s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleUp (2644.73s)
--- PASS: TestAccElastiCacheReplicationGroup_multiAzInVPC (1957.71s)
--- PASS: TestAccElastiCacheReplicationGroup_deprecatedAvailabilityZones_multiAzInVPC (2157.46s)
--- PASS: TestAccElastiCacheReplicationGroup_basic_v5 (739.79s)
--- PASS: TestAccElastiCacheReplicationGroup_deprecatedAvailabilityZones_multiAzNotInVPC (2004.35s)
--- PASS: TestAccElastiCacheReplicationGroup_basic (748.09s)
--- PASS: TestAccElastiCacheReplicationGroup_uppercase (984.32s)
--- PASS: TestAccElastiCacheReplicationGroup_updateNodeSize (1574.77s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleUp (2833.83s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleDown (3283.54s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleDown (2938.46s)
--- PASS: TestAccElastiCacheReplicationGroup_Validation_noNodeType (5.08s)
--- PASS: TestAccElastiCacheReplicationGroup_Engine_Redis_LogDeliveryConfigurations_ClusterMode_Enabled (1229.57s)
--- PASS: TestAccElastiCacheReplicationGroup_Engine_Redis_LogDeliveryConfigurations_ClusterMode_Disabled (1226.76s)
--- PASS: TestAccElastiCacheReplicationGroup_Validation_globalReplicationGroupIdAndNodeType (1167.68s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_disappears (2388.68s)
--- PASS: TestAccElastiCacheReplicationGroup_EngineVersion_update (3294.03s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_basic (2490.75s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterMode_basic (3714.02s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_full (3437.57s)

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 1, 2022
@gdavison gdavison marked this pull request as ready for review April 4, 2022 17:44
@ewbankkit ewbankkit self-assigned this Apr 5, 2022
ewbankkit
ewbankkit approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccElastiCacheCluster_Engine_memcached\|TestAccElastiCacheCluster_Engine_redis_v5\|TestAccElastiCacheCluster_Redis_autoMinorVersionUpgrade\|TestAccElastiCacheReplicationGroup_basic\|TestAccElastiCacheReplicationGroup_basic_v5\|TestAccElastiCacheReplicationGroup_uppercase\|TestAccElastiCacheReplicationGroup_autoMinorVersionUpgrade' PKG=elasticache ACCTEST_PARALLELISM=2 ACCTEST_TIMEOUT=720m
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 2  -run=TestAccElastiCacheCluster_Engine_memcached\|TestAccElastiCacheCluster_Engine_redis_v5\|TestAccElastiCacheCluster_Redis_autoMinorVersionUpgrade\|TestAccElastiCacheReplicationGroup_basic\|TestAccElastiCacheReplicationGroup_basic_v5\|TestAccElastiCacheReplicationGroup_uppercase\|TestAccElastiCacheReplicationGroup_autoMinorVersionUpgrade -timeout 720m
=== RUN   TestAccElastiCacheCluster_Engine_memcached
=== PAUSE TestAccElastiCacheCluster_Engine_memcached
=== RUN   TestAccElastiCacheCluster_Engine_redis_v5
=== PAUSE TestAccElastiCacheCluster_Engine_redis_v5
=== RUN   TestAccElastiCacheCluster_Redis_autoMinorVersionUpgrade
=== PAUSE TestAccElastiCacheCluster_Redis_autoMinorVersionUpgrade
=== RUN   TestAccElastiCacheReplicationGroup_basic
=== PAUSE TestAccElastiCacheReplicationGroup_basic
=== RUN   TestAccElastiCacheReplicationGroup_basic_v5
=== PAUSE TestAccElastiCacheReplicationGroup_basic_v5
=== RUN   TestAccElastiCacheReplicationGroup_uppercase
=== PAUSE TestAccElastiCacheReplicationGroup_uppercase
=== RUN   TestAccElastiCacheReplicationGroup_autoMinorVersionUpgrade
=== PAUSE TestAccElastiCacheReplicationGroup_autoMinorVersionUpgrade
=== CONT  TestAccElastiCacheCluster_Engine_memcached
=== CONT  TestAccElastiCacheReplicationGroup_basic_v5
--- PASS: TestAccElastiCacheCluster_Engine_memcached (474.93s)
=== CONT  TestAccElastiCacheCluster_Redis_autoMinorVersionUpgrade
--- PASS: TestAccElastiCacheReplicationGroup_basic_v5 (693.76s)
=== CONT  TestAccElastiCacheReplicationGroup_basic
--- PASS: TestAccElastiCacheCluster_Redis_autoMinorVersionUpgrade (536.72s)
=== CONT  TestAccElastiCacheCluster_Engine_redis_v5
--- PASS: TestAccElastiCacheReplicationGroup_basic (704.76s)
=== CONT  TestAccElastiCacheReplicationGroup_autoMinorVersionUpgrade
--- PASS: TestAccElastiCacheCluster_Engine_redis_v5 (493.52s)
=== CONT  TestAccElastiCacheReplicationGroup_uppercase
--- PASS: TestAccElastiCacheReplicationGroup_uppercase (708.25s)
--- PASS: TestAccElastiCacheReplicationGroup_autoMinorVersionUpgrade (844.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	2247.896s

@ewbankkit ewbankkit removed their assignment Apr 6, 2022
@gdavison gdavison merged commit b599209 into main Apr 7, 2022
@gdavison gdavison deleted the elasticache-auto-update branch April 7, 2022 19:34
@github-actions github-actions bot added this to the v4.9.0 milestone Apr 7, 2022
github-actions bot pushed a commit that referenced this pull request Apr 7, 2022
Update CHANGELOG.md for #23996
1552d76
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

This functionality has been released in v4.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gdavison @ewbankkit