Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/lambda_permission - add principal_org_id argument #24001

Merged
merged 6 commits into from
Apr 2, 2022

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23994

Output from acceptance testing:

$ make testacc TESTS=TestAccLambdaPermission PKG=lambda

--- PASS: TestAccLambdaPermission_withIAMRole (52.99s)
--- PASS: TestAccLambdaPermission_basic (65.21s)
--- PASS: TestAccLambdaPermission_withS3 (82.27s)
--- PASS: TestAccLambdaPermission_withStatementIdPrefix (85.44s)
--- PASS: TestAccLambdaPermission_multiplePerms (93.18s)
--- PASS: TestAccLambdaPermission_withRawFunctionName (110.81s)
--- PASS: TestAccLambdaPermission_StatementID_duplicate (115.98s)
--- PASS: TestAccLambdaPermission_principalOrgId (118.89s)
--- PASS: TestAccLambdaPermission_withSNS (142.43s)
--- PASS: TestAccLambdaPermission_disappears (152.10s)
--- PASS: TestAccLambdaPermission_withQualifier (52.18s)

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/lambda Issues and PRs that pertain to the lambda service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Apr 2, 2022
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 2, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review April 2, 2022 09:34
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccLambdaPermission_ PKG=lambda ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 2 -run='TestAccLambdaPermission_'  -timeout 180m
=== RUN   TestAccLambdaPermission_basic
=== PAUSE TestAccLambdaPermission_basic
=== RUN   TestAccLambdaPermission_principalOrgId
=== PAUSE TestAccLambdaPermission_principalOrgId
=== RUN   TestAccLambdaPermission_StatementID_duplicate
=== PAUSE TestAccLambdaPermission_StatementID_duplicate
=== RUN   TestAccLambdaPermission_withRawFunctionName
=== PAUSE TestAccLambdaPermission_withRawFunctionName
=== RUN   TestAccLambdaPermission_withStatementIdPrefix
=== PAUSE TestAccLambdaPermission_withStatementIdPrefix
=== RUN   TestAccLambdaPermission_withQualifier
=== PAUSE TestAccLambdaPermission_withQualifier
=== RUN   TestAccLambdaPermission_disappears
=== PAUSE TestAccLambdaPermission_disappears
=== RUN   TestAccLambdaPermission_multiplePerms
=== PAUSE TestAccLambdaPermission_multiplePerms
=== RUN   TestAccLambdaPermission_withS3
=== PAUSE TestAccLambdaPermission_withS3
=== RUN   TestAccLambdaPermission_withSNS
=== PAUSE TestAccLambdaPermission_withSNS
=== RUN   TestAccLambdaPermission_withIAMRole
=== PAUSE TestAccLambdaPermission_withIAMRole
=== CONT  TestAccLambdaPermission_basic
=== CONT  TestAccLambdaPermission_disappears
--- PASS: TestAccLambdaPermission_basic (35.24s)
=== CONT  TestAccLambdaPermission_withRawFunctionName
--- PASS: TestAccLambdaPermission_withRawFunctionName (39.39s)
=== CONT  TestAccLambdaPermission_withQualifier
--- PASS: TestAccLambdaPermission_disappears (96.48s)
=== CONT  TestAccLambdaPermission_withStatementIdPrefix
--- PASS: TestAccLambdaPermission_withQualifier (39.57s)
=== CONT  TestAccLambdaPermission_withSNS
--- PASS: TestAccLambdaPermission_withStatementIdPrefix (30.96s)
=== CONT  TestAccLambdaPermission_withIAMRole
--- PASS: TestAccLambdaPermission_withIAMRole (32.74s)
=== CONT  TestAccLambdaPermission_withS3
--- PASS: TestAccLambdaPermission_withS3 (34.49s)
=== CONT  TestAccLambdaPermission_multiplePerms
--- PASS: TestAccLambdaPermission_withSNS (94.63s)
=== CONT  TestAccLambdaPermission_StatementID_duplicate
--- PASS: TestAccLambdaPermission_multiplePerms (46.56s)
=== CONT  TestAccLambdaPermission_principalOrgId
--- PASS: TestAccLambdaPermission_principalOrgId (32.64s)
--- PASS: TestAccLambdaPermission_StatementID_duplicate (82.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	294.643s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit d24753e into hashicorp:main Apr 2, 2022
@github-actions github-actions bot added this to the v4.9.0 milestone Apr 2, 2022
@DrFaust92 DrFaust92 deleted the lambda-org-princ branch April 3, 2022 06:24
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

This functionality has been released in v4.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_lambda_permission - Add support for PrincipalOrgID
2 participants