F/ add ability to specify a privatelink end point for S3 file gateway - NFS resource #24038

kliu47 · 2022-04-05T22:19:50Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTS=testAccStorageGatewayNFSFileShare_basic  PKG=storagegateway

Unable to run acceptance test as test requires physical hardware to properly test (S3 gateway appliance). 

...

github-actions

Welcome @kliu47 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

This reverts commit c24907e.

This reverts commit 598099a.

…rp#14601).

…dpoint_dns_name'. Acceptance test output: % make testacc TESTS=TestAccStorageGatewayNFSFileShare_basic PKG=storagegateway ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/storagegateway/... -v -count 1 -parallel 20 -run='TestAccStorageGatewayNFSFileShare_basic' -timeout 180m === RUN TestAccStorageGatewayNFSFileShare_basic === PAUSE TestAccStorageGatewayNFSFileShare_basic === CONT TestAccStorageGatewayNFSFileShare_basic --- PASS: TestAccStorageGatewayNFSFileShare_basic (325.55s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/storagegateway 330.882s

Acceptance test output: % make testacc TESTS=TestAccStorageGatewayGateway_GatewayType_stored PKG=storagegateway ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/storagegateway/... -v -count 1 -parallel 20 -run='TestAccStorageGatewayGateway_GatewayType_stored' -timeout 180m === RUN TestAccStorageGatewayGateway_GatewayType_stored === PAUSE TestAccStorageGatewayGateway_GatewayType_stored === CONT TestAccStorageGatewayGateway_GatewayType_stored --- PASS: TestAccStorageGatewayGateway_GatewayType_stored (219.24s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/storagegateway 222.917s

This reverts commit 2dee622.

…th' and 'maintenance_start_time.day_of_week' nullable. Acceptance test output: % make testacc TESTS=TestAccStorageGatewayGateway_maintenanceStartTime PKG=storagegateway ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/storagegateway/... -v -count 1 -parallel 20 -run='TestAccStorageGatewayGateway_maintenanceStartTime' -timeout 180m === RUN TestAccStorageGatewayGateway_maintenanceStartTime === PAUSE TestAccStorageGatewayGateway_maintenanceStartTime === CONT TestAccStorageGatewayGateway_maintenanceStartTime --- PASS: TestAccStorageGatewayGateway_maintenanceStartTime (221.15s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/storagegateway 227.231s

ewbankkit · 2022-04-07T16:22:11Z

% make testacc TESTS=TestAccStorageGatewayNFSFileShare_ PKG=storagegateway ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/storagegateway/... -v -count 1 -parallel 2 -run='TestAccStorageGatewayNFSFileShare_'  -timeout 180m
=== RUN   TestAccStorageGatewayNFSFileShare_basic
=== PAUSE TestAccStorageGatewayNFSFileShare_basic
=== RUN   TestAccStorageGatewayNFSFileShare_audit
=== PAUSE TestAccStorageGatewayNFSFileShare_audit
=== RUN   TestAccStorageGatewayNFSFileShare_tags
=== PAUSE TestAccStorageGatewayNFSFileShare_tags
=== RUN   TestAccStorageGatewayNFSFileShare_fileShareName
=== PAUSE TestAccStorageGatewayNFSFileShare_fileShareName
=== RUN   TestAccStorageGatewayNFSFileShare_clientList
=== PAUSE TestAccStorageGatewayNFSFileShare_clientList
=== RUN   TestAccStorageGatewayNFSFileShare_defaultStorageClass
=== PAUSE TestAccStorageGatewayNFSFileShare_defaultStorageClass
=== RUN   TestAccStorageGatewayNFSFileShare_guessMIMETypeEnabled
=== PAUSE TestAccStorageGatewayNFSFileShare_guessMIMETypeEnabled
=== RUN   TestAccStorageGatewayNFSFileShare_kmsEncrypted
=== PAUSE TestAccStorageGatewayNFSFileShare_kmsEncrypted
=== RUN   TestAccStorageGatewayNFSFileShare_kmsKeyARN
=== PAUSE TestAccStorageGatewayNFSFileShare_kmsKeyARN
=== RUN   TestAccStorageGatewayNFSFileShare_nFSFileShareDefaults
=== PAUSE TestAccStorageGatewayNFSFileShare_nFSFileShareDefaults
=== RUN   TestAccStorageGatewayNFSFileShare_objectACL
=== PAUSE TestAccStorageGatewayNFSFileShare_objectACL
=== RUN   TestAccStorageGatewayNFSFileShare_readOnly
=== PAUSE TestAccStorageGatewayNFSFileShare_readOnly
=== RUN   TestAccStorageGatewayNFSFileShare_requesterPays
=== PAUSE TestAccStorageGatewayNFSFileShare_requesterPays
=== RUN   TestAccStorageGatewayNFSFileShare_squash
=== PAUSE TestAccStorageGatewayNFSFileShare_squash
=== RUN   TestAccStorageGatewayNFSFileShare_notificationPolicy
=== PAUSE TestAccStorageGatewayNFSFileShare_notificationPolicy
=== RUN   TestAccStorageGatewayNFSFileShare_cacheAttributes
=== PAUSE TestAccStorageGatewayNFSFileShare_cacheAttributes
=== RUN   TestAccStorageGatewayNFSFileShare_disappears
=== PAUSE TestAccStorageGatewayNFSFileShare_disappears
=== CONT  TestAccStorageGatewayNFSFileShare_basic
=== CONT  TestAccStorageGatewayNFSFileShare_nFSFileShareDefaults
--- PASS: TestAccStorageGatewayNFSFileShare_basic (328.80s)
=== CONT  TestAccStorageGatewayNFSFileShare_squash
--- PASS: TestAccStorageGatewayNFSFileShare_nFSFileShareDefaults (374.51s)
=== CONT  TestAccStorageGatewayNFSFileShare_disappears
--- PASS: TestAccStorageGatewayNFSFileShare_disappears (310.24s)
=== CONT  TestAccStorageGatewayNFSFileShare_cacheAttributes
--- PASS: TestAccStorageGatewayNFSFileShare_squash (437.75s)
=== CONT  TestAccStorageGatewayNFSFileShare_notificationPolicy
--- PASS: TestAccStorageGatewayNFSFileShare_cacheAttributes (427.33s)
=== CONT  TestAccStorageGatewayNFSFileShare_defaultStorageClass
--- PASS: TestAccStorageGatewayNFSFileShare_notificationPolicy (494.58s)
=== CONT  TestAccStorageGatewayNFSFileShare_kmsKeyARN
--- PASS: TestAccStorageGatewayNFSFileShare_defaultStorageClass (480.85s)
=== CONT  TestAccStorageGatewayNFSFileShare_kmsEncrypted
--- PASS: TestAccStorageGatewayNFSFileShare_kmsKeyARN (478.81s)
=== CONT  TestAccStorageGatewayNFSFileShare_guessMIMETypeEnabled
--- PASS: TestAccStorageGatewayNFSFileShare_kmsEncrypted (343.72s)
=== CONT  TestAccStorageGatewayNFSFileShare_readOnly
--- PASS: TestAccStorageGatewayNFSFileShare_guessMIMETypeEnabled (439.39s)
=== CONT  TestAccStorageGatewayNFSFileShare_requesterPays
--- PASS: TestAccStorageGatewayNFSFileShare_readOnly (368.53s)
=== CONT  TestAccStorageGatewayNFSFileShare_fileShareName
--- PASS: TestAccStorageGatewayNFSFileShare_requesterPays (411.02s)
=== CONT  TestAccStorageGatewayNFSFileShare_tags
--- PASS: TestAccStorageGatewayNFSFileShare_fileShareName (389.37s)
=== CONT  TestAccStorageGatewayNFSFileShare_audit
    nfs_file_share_test.go:77: Step 1/3 error: Error running apply: exit status 1
        
        Error: error creating Storage Gateway NFS File Share: InvalidGatewayRequestException: Policy document length breaking Cloudwatch Logs Constraints, either < 1 or > 5120 (Service: AWSIngestionHub; Status Code: 400; Error Code: LogDestinationPermissionIssueException; Request ID: 4146bc1d-7db0-4566-b353-67a54fda30a7; Proxy: null)
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "f8efefca-197c-4572-a846-6f65bee4942a"
          },
          Error_: {
            ErrorCode: "AuthenticationFailure"
          },
          Message_: "Policy document length breaking Cloudwatch Logs Constraints, either < 1 or > 5120 (Service: AWSIngestionHub; Status Code: 400; Error Code: LogDestinationPermissionIssueException; Request ID: 4146bc1d-7db0-4566-b353-67a54fda30a7; Proxy: null)"
        }
        
          with aws_storagegateway_nfs_file_share.test,
          on terraform_plugin_test.tf line 168, in resource "aws_storagegateway_nfs_file_share" "test":
         168: resource "aws_storagegateway_nfs_file_share" "test" {
        
--- PASS: TestAccStorageGatewayNFSFileShare_tags (382.03s)
=== CONT  TestAccStorageGatewayNFSFileShare_objectACL
--- FAIL: TestAccStorageGatewayNFSFileShare_audit (324.68s)
=== CONT  TestAccStorageGatewayNFSFileShare_clientList
--- PASS: TestAccStorageGatewayNFSFileShare_objectACL (381.53s)
--- PASS: TestAccStorageGatewayNFSFileShare_clientList (466.02s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/storagegateway	3492.494s
FAIL
make: *** [testacc] Error 1

We get that error in nightly CI:

=== RUN   TestAccStorageGatewayNFSFileShare_audit
=== PAUSE TestAccStorageGatewayNFSFileShare_audit
=== CONT  TestAccStorageGatewayNFSFileShare_audit
nfs_file_share_test.go:76: Step 1/3 error: Error running apply: exit status 1
Error: error creating Storage Gateway NFS File Share: InvalidGatewayRequestException: Policy document length breaking Cloudwatch Logs Constraints, either < 1 or > 5120 (Service: AWSIngestionHub; Status Code: 400; Error Code: LogDestinationPermissionIssueException; Request ID: f4de2e1a-b2c8-4140-9171-b92441f6a2c6; Proxy: null)
{
RespMetadata: {
StatusCode: 400,
RequestID: "42c2e7a1-0185-4bd2-8c67-84cded699e25"
},
Error_: {
ErrorCode: "AuthenticationFailure"
},
Message_: "Policy document length breaking Cloudwatch Logs Constraints, either < 1 or > 5120 (Service: AWSIngestionHub; Status Code: 400; Error Code: LogDestinationPermissionIssueException; Request ID: f4de2e1a-b2c8-4140-9171-b92441f6a2c6; Proxy: null)"
}
with aws_storagegateway_nfs_file_share.test,
on terraform_plugin_test.tf line 168, in resource "aws_storagegateway_nfs_file_share" "test":
168: resource "aws_storagegateway_nfs_file_share" "test" {
--- FAIL: TestAccStorageGatewayNFSFileShare_audit (313.60s)

% make testacc TESTS=TestAccStorageGatewayGateway_ PKG=storagegateway ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/storagegateway/... -v -count 1 -parallel 2 -run='TestAccStorageGatewayGateway_'  -timeout 180m
=== RUN   TestAccStorageGatewayGateway_GatewayType_cached
=== PAUSE TestAccStorageGatewayGateway_GatewayType_cached
=== RUN   TestAccStorageGatewayGateway_GatewayType_fileFSxSMB
=== PAUSE TestAccStorageGatewayGateway_GatewayType_fileFSxSMB
=== RUN   TestAccStorageGatewayGateway_GatewayType_fileS3
=== PAUSE TestAccStorageGatewayGateway_GatewayType_fileS3
=== RUN   TestAccStorageGatewayGateway_GatewayType_stored
=== PAUSE TestAccStorageGatewayGateway_GatewayType_stored
=== RUN   TestAccStorageGatewayGateway_GatewayType_vtl
=== PAUSE TestAccStorageGatewayGateway_GatewayType_vtl
=== RUN   TestAccStorageGatewayGateway_tags
=== PAUSE TestAccStorageGatewayGateway_tags
=== RUN   TestAccStorageGatewayGateway_gatewayName
=== PAUSE TestAccStorageGatewayGateway_gatewayName
=== RUN   TestAccStorageGatewayGateway_cloudWatchLogs
=== PAUSE TestAccStorageGatewayGateway_cloudWatchLogs
=== RUN   TestAccStorageGatewayGateway_gatewayTimezone
=== PAUSE TestAccStorageGatewayGateway_gatewayTimezone
=== RUN   TestAccStorageGatewayGateway_gatewayVPCEndpoint
=== PAUSE TestAccStorageGatewayGateway_gatewayVPCEndpoint
=== RUN   TestAccStorageGatewayGateway_smbActiveDirectorySettings
=== PAUSE TestAccStorageGatewayGateway_smbActiveDirectorySettings
=== RUN   TestAccStorageGatewayGateway_SMBActiveDirectorySettings_timeout
=== PAUSE TestAccStorageGatewayGateway_SMBActiveDirectorySettings_timeout
=== RUN   TestAccStorageGatewayGateway_smbMicrosoftActiveDirectorySettings
=== PAUSE TestAccStorageGatewayGateway_smbMicrosoftActiveDirectorySettings
=== RUN   TestAccStorageGatewayGateway_SMBMicrosoftActiveDirectorySettings_timeout
=== PAUSE TestAccStorageGatewayGateway_SMBMicrosoftActiveDirectorySettings_timeout
=== RUN   TestAccStorageGatewayGateway_smbGuestPassword
=== PAUSE TestAccStorageGatewayGateway_smbGuestPassword
=== RUN   TestAccStorageGatewayGateway_smbSecurityStrategy
=== PAUSE TestAccStorageGatewayGateway_smbSecurityStrategy
=== RUN   TestAccStorageGatewayGateway_smbVisibility
=== PAUSE TestAccStorageGatewayGateway_smbVisibility
=== RUN   TestAccStorageGatewayGateway_disappears
=== PAUSE TestAccStorageGatewayGateway_disappears
=== RUN   TestAccStorageGatewayGateway_bandwidthUpload
=== PAUSE TestAccStorageGatewayGateway_bandwidthUpload
=== RUN   TestAccStorageGatewayGateway_bandwidthDownload
=== PAUSE TestAccStorageGatewayGateway_bandwidthDownload
=== RUN   TestAccStorageGatewayGateway_bandwidthAll
=== PAUSE TestAccStorageGatewayGateway_bandwidthAll
=== RUN   TestAccStorageGatewayGateway_maintenanceStartTime
=== PAUSE TestAccStorageGatewayGateway_maintenanceStartTime
=== CONT  TestAccStorageGatewayGateway_GatewayType_cached
=== CONT  TestAccStorageGatewayGateway_SMBActiveDirectorySettings_timeout
--- PASS: TestAccStorageGatewayGateway_GatewayType_cached (250.67s)
=== CONT  TestAccStorageGatewayGateway_maintenanceStartTime
--- PASS: TestAccStorageGatewayGateway_SMBActiveDirectorySettings_timeout (935.15s)
=== CONT  TestAccStorageGatewayGateway_bandwidthAll
--- PASS: TestAccStorageGatewayGateway_bandwidthAll (273.88s)
=== CONT  TestAccStorageGatewayGateway_bandwidthDownload
--- PASS: TestAccStorageGatewayGateway_maintenanceStartTime (224.36s)
=== CONT  TestAccStorageGatewayGateway_bandwidthUpload
--- PASS: TestAccStorageGatewayGateway_bandwidthDownload (258.57s)
=== CONT  TestAccStorageGatewayGateway_disappears
--- PASS: TestAccStorageGatewayGateway_bandwidthUpload (288.59s)
=== CONT  TestAccStorageGatewayGateway_smbVisibility
--- PASS: TestAccStorageGatewayGateway_disappears (208.31s)
=== CONT  TestAccStorageGatewayGateway_smbSecurityStrategy
--- PASS: TestAccStorageGatewayGateway_smbVisibility (374.70s)
=== CONT  TestAccStorageGatewayGateway_smbGuestPassword
--- PASS: TestAccStorageGatewayGateway_smbSecurityStrategy (323.75s)
=== CONT  TestAccStorageGatewayGateway_SMBMicrosoftActiveDirectorySettings_timeout
--- PASS: TestAccStorageGatewayGateway_smbGuestPassword (328.11s)
=== CONT  TestAccStorageGatewayGateway_smbMicrosoftActiveDirectorySettings
--- PASS: TestAccStorageGatewayGateway_SMBMicrosoftActiveDirectorySettings_timeout (2222.79s)
=== CONT  TestAccStorageGatewayGateway_tags
--- PASS: TestAccStorageGatewayGateway_tags (270.70s)
=== CONT  TestAccStorageGatewayGateway_smbActiveDirectorySettings
--- PASS: TestAccStorageGatewayGateway_smbMicrosoftActiveDirectorySettings (2330.32s)
=== CONT  TestAccStorageGatewayGateway_gatewayVPCEndpoint
--- PASS: TestAccStorageGatewayGateway_gatewayVPCEndpoint (323.40s)
=== CONT  TestAccStorageGatewayGateway_gatewayTimezone
--- PASS: TestAccStorageGatewayGateway_gatewayTimezone (328.08s)
=== CONT  TestAccStorageGatewayGateway_cloudWatchLogs
--- PASS: TestAccStorageGatewayGateway_smbActiveDirectorySettings (976.57s)
=== CONT  TestAccStorageGatewayGateway_gatewayName
=== CONT  TestAccStorageGatewayGateway_cloudWatchLogs
    gateway_test.go:317: Step 1/2 error: Error running apply: exit status 1
        
        Error: error setting CloudWatch Log Group: InvalidGatewayRequestException: Policy document length breaking Cloudwatch Logs Constraints, either < 1 or > 5120 (Service: AWSIngestionHub; Status Code: 400; Error Code: LogDestinationPermissionIssueException; Request ID: adb2159b-8a92-4d66-97f9-96074ed19548; Proxy: null)
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "af33a933-ef17-4643-949d-e0abfc5a4380"
          },
          Error_: {
            ErrorCode: "AuthenticationFailure"
          },
          Message_: "Policy document length breaking Cloudwatch Logs Constraints, either < 1 or > 5120 (Service: AWSIngestionHub; Status Code: 400; Error Code: LogDestinationPermissionIssueException; Request ID: adb2159b-8a92-4d66-97f9-96074ed19548; Proxy: null)"
        }
        
          with aws_storagegateway_gateway.test,
          on terraform_plugin_test.tf line 104, in resource "aws_storagegateway_gateway" "test":
         104: resource "aws_storagegateway_gateway" "test" {
        
--- FAIL: TestAccStorageGatewayGateway_cloudWatchLogs (323.73s)
=== CONT  TestAccStorageGatewayGateway_GatewayType_fileS3
--- PASS: TestAccStorageGatewayGateway_GatewayType_fileS3 (303.89s)
=== CONT  TestAccStorageGatewayGateway_GatewayType_vtl
--- PASS: TestAccStorageGatewayGateway_GatewayType_vtl (186.69s)
=== CONT  TestAccStorageGatewayGateway_GatewayType_stored
--- PASS: TestAccStorageGatewayGateway_GatewayType_stored (237.95s)
=== CONT  TestAccStorageGatewayGateway_GatewayType_fileFSxSMB
--- PASS: TestAccStorageGatewayGateway_GatewayType_fileFSxSMB (314.68s)
=== CONT  TestAccStorageGatewayGateway_gatewayName
--- PASS: TestAccStorageGatewayGateway_gatewayName (342.22s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/storagegateway	6705.747s
FAIL
make: *** [testacc] Error 1

We get that error in nightly CI:

=== RUN   TestAccStorageGatewayGateway_cloudWatchLogs
=== PAUSE TestAccStorageGatewayGateway_cloudWatchLogs
=== CONT  TestAccStorageGatewayGateway_cloudWatchLogs
gateway_test.go:311: Step 1/2 error: Error running apply: exit status 1
Error: error setting CloudWatch Log Group: InvalidGatewayRequestException: Policy document length breaking Cloudwatch Logs Constraints, either < 1 or > 5120 (Service: AWSIngestionHub; Status Code: 400; Error Code: LogDestinationPermissionIssueException; Request ID: 04d4fda6-c525-4cad-bf84-6600b3980325; Proxy: null)
{
RespMetadata: {
StatusCode: 400,
RequestID: "18f34811-1f72-44c1-82cf-2fd28f67421d"
},
Error_: {
ErrorCode: "AuthenticationFailure"
},
Message_: "Policy document length breaking Cloudwatch Logs Constraints, either < 1 or > 5120 (Service: AWSIngestionHub; Status Code: 400; Error Code: LogDestinationPermissionIssueException; Request ID: 04d4fda6-c525-4cad-bf84-6600b3980325; Proxy: null)"
}
with aws_storagegateway_gateway.test,
on terraform_plugin_test.tf line 103, in resource "aws_storagegateway_gateway" "test":
103: resource "aws_storagegateway_gateway" "test" {
--- FAIL: TestAccStorageGatewayGateway_cloudWatchLogs (263.21s)

ewbankkit

LGTM 🚀.

ewbankkit · 2022-04-07T18:40:02Z

@kliu47 @awasilyev Thanks for the contribution 🎉 👏.

github-actions · 2022-04-07T22:32:57Z

This functionality has been released in v4.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-05-09T02:34:22Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

Alexey Wasilyev and others added 4 commits March 26, 2021 15:10

support for maintenance start time (15331)

598099a

fix for support for maintenance start time (15331)

c24907e

Update nfs_file_share.go

48a4a55

Update nfs_file_share.go

55040ce

github-actions bot added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/storagegateway Issues and PRs that pertain to the storagegateway service. labels Apr 5, 2022

Create 24038.txt

ef69a7e

github-actions bot reviewed Apr 5, 2022

View reviewed changes

kliu47 changed the title ~~WIP: F/ add ability to specify a privatelink end point for S3 file gateway - NFS resource~~ F/ add ability to specify a privatelink end point for S3 file gateway - NFS resource Apr 5, 2022

Update storagegateway_nfs_file_share.html.markdown

a5a7212

github-actions bot added the documentation Introduces or discusses updates to documentation. label Apr 5, 2022

ewbankkit added 2 commits April 6, 2022 08:03

Update 24038.txt

b59c3fc

Update storagegateway_nfs_file_share.html.markdown

71aae45

ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Apr 6, 2022

ewbankkit and others added 15 commits April 6, 2022 08:11

Revert "fix for support for maintenance start time (15331)"

5a9cd10

This reverts commit c24907e.

Revert "support for maintenance start time (15331)"

c465474

This reverts commit 598099a.

Merge commit 'c465474c0fcddcd2a32dbc83bd0a5c259ccd4dd2' into HEAD

51bfba4

r/aws_storagegateway_nfs_file_share: Alphabetize attributes.

853affe

r/aws_storagegateway_nfs_file_share: Add and use '_Values()' (hashico…

3e2b2d9

…rp#14601).

r/aws_storagegateway_nfs_file_share: Cosmetics.

ff4ff5c

Add and use 'FindNFSFileShareByARN'.

2301d98

'statussmBFileShare' -> 'statusSMBFileShare'.

5bc9eaf

r/aws_storagegateway_gateway: Alphabetize attributes.

59f9092

r/aws_storagegateway_gateway: Add and use '_Values()' (hashicorp#14601).

9af967f

r/aws_storagegateway_gateway: Tidy up resource Delete.

a9be9aa

Fix gofmt error

2dee622

r/aws_storagegateway_gateway: Tidy up resource Update.

e3f1e17

r/aws_storagegateway_gateway: Minor tidy up of resource Create.

52f5de9

ewbankkit added 5 commits April 6, 2022 12:11

r/aws_storagegateway_gateway: Add and use 'FindGatewayByARN'.

de6992e

Add 'TestAccStorageGatewayGateway_maintenanceStartTime'.

c9963d9

Revert "Fix gofmt error"

6c2e7db

This reverts commit 2dee622.

Merge commit 'c9963d908aeb87b0f86eab5f89700252df75e7cb' into HEAD

f2b5d02

github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/XS Managed by automation to categorize the size of a PR. labels Apr 6, 2022

ewbankkit mentioned this pull request Apr 6, 2022

support for maintenance start time configuration (15331) #15355

Closed

ewbankkit added 3 commits April 6, 2022 14:21

Pass 'null' for missing 'day_of_week' or 'day_of_month' values.

748ac26

Fix golangci-lint errors.

ac56cd8

ewbankkit approved these changes Apr 7, 2022

View reviewed changes

ewbankkit merged commit e5a5af7 into hashicorp:main Apr 7, 2022

github-actions bot added this to the v4.9.0 milestone Apr 7, 2022

github-actions bot locked as resolved and limited conversation to collaborators May 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

F/ add ability to specify a privatelink end point for S3 file gateway - NFS resource #24038

F/ add ability to specify a privatelink end point for S3 file gateway - NFS resource #24038

kliu47 commented Apr 5, 2022 •

edited by ewbankkit

Loading

github-actions bot left a comment

ewbankkit commented Apr 7, 2022 •

edited

Loading

ewbankkit left a comment

ewbankkit commented Apr 7, 2022

github-actions bot commented Apr 7, 2022

github-actions bot commented May 9, 2022

F/ add ability to specify a privatelink end point for S3 file gateway - NFS resource #24038

F/ add ability to specify a privatelink end point for S3 file gateway - NFS resource #24038

Conversation

kliu47 commented Apr 5, 2022 • edited by ewbankkit Loading

Community Note

github-actions bot left a comment

Choose a reason for hiding this comment

ewbankkit commented Apr 7, 2022 • edited Loading

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Apr 7, 2022

github-actions bot commented Apr 7, 2022

github-actions bot commented May 9, 2022

kliu47 commented Apr 5, 2022 •

edited by ewbankkit

Loading

ewbankkit commented Apr 7, 2022 •

edited

Loading