Stop replication task before applying changes that require the task to be stopped.

[fermezz]

Previous attempt to fix this issue relied on a new handle_task_lifecycle parameter. We do not do this in this PR because that attempt was before start_replication_task existed, so I think it's a good idea to manage the entire lifecycle through the one parameter.

I missed the branch-prefix convention. Let me know if it's important enough and I can re-create the PR with a new branch.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #2236.
Closes #16092 (dup).

Output from acceptance testing:

Existing acceptance tests pass:

$ make testacc TESTS=TestAccDMSReplicationTask_startReplicationTask PKG=dms
Command being timed: "/usr/local/go/pkg/tool/linux_amd64/compile -o $WORK/b760/_pkg_.a -trimpath $WORK/b760=> -p github.com/hashicorp/terraform-provider-aws/internal/service/accessanalyzer -lang=go1.17 -complete -buildid hOz6ADJNtP16IxXhuG8-/hOz6ADJNtP16IxXhuG8- -goversion go1.18 -c=4 -nolocalimports -importcfg $WORK/b760/importcfg -pack internal/service/accessanalyzer/analyzer.go internal/service/accessanalyzer/generate.go internal/service/accessanalyzer/tags_gen.go"
    User time (seconds): 11.00
    System time (seconds): 7.02
    Percent of CPU this job got: 21%
    Elapsed (wall clock) time (h:mm:ss or m:ss): 1:24.02
    Average shared text size (kbytes): 0
    Average unshared data size (kbytes): 0
    Average stack size (kbytes): 0
    Average total size (kbytes): 0
    Maximum resident set size (kbytes): 790716
    Average resident set size (kbytes): 0
    Major (requiring I/O) page faults: 24661
    Minor (reclaiming a frame) page faults: 123527
    Voluntary context switches: 59091
    Involuntary context switches: 4010
    Swaps: 0
    File system inputs: 3506000
    File system outputs: 784
    Socket messages sent: 0
    Socket messages received: 0
    Signals delivered: 0
    Page size (bytes): 4096
    Exit status: 0
=== RUN   TestAccDMSReplicationTask_startReplicationTask
=== PAUSE TestAccDMSReplicationTask_startReplicationTask
=== CONT  TestAccDMSReplicationTask_startReplicationTask
--- PASS: TestAccDMSReplicationTask_startReplicationTask (1247.64s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        1247.783s

Result from adapted acceptance tests:

Command being timed: "/usr/local/go/pkg/tool/linux_amd64/compile -o $WORK/b760/_pkg_.a -trimpath $WORK/b760=> -p github.com/hashicorp/terraform-provider-aws/internal/service/accessanalyzer -lang=go1.17 -complete -buildid hOz6ADJNtP16IxXhuG8-/hOz6ADJNtP16IxXhuG8- -goversion go1.18 -c=4 -nolocalimports -importcfg $WORK/b760/importcfg -pack internal/service/accessanalyzer/analyzer.go internal/service/accessanalyzer/generate.go internal/service/accessanalyzer/tags_gen.go"
    User time (seconds): 11.00
    System time (seconds): 7.02
    Percent of CPU this job got: 21%
    Elapsed (wall clock) time (h:mm:ss or m:ss): 1:24.02
    Average shared text size (kbytes): 0
    Average unshared data size (kbytes): 0
    Average stack size (kbytes): 0
    Average total size (kbytes): 0
    Maximum resident set size (kbytes): 790716
    Average resident set size (kbytes): 0
    Major (requiring I/O) page faults: 24661
    Minor (reclaiming a frame) page faults: 123527
    Voluntary context switches: 59091
    Involuntary context switches: 4010
    Swaps: 0
    File system inputs: 3506000
    File system outputs: 784
    Socket messages sent: 0
    Socket messages received: 0
    Signals delivered: 0
    Page size (bytes): 4096
    Exit status: 0
=== RUN   TestAccDMSReplicationTask_startReplicationTask
=== PAUSE TestAccDMSReplicationTask_startReplicationTask
=== CONT  TestAccDMSReplicationTask_startReplicationTask
--- PASS: TestAccDMSReplicationTask_startReplicationTask (992.97s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        993.036s

[github-actions]

Welcome @fermezz 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[fermezz]

Author's note: This change is necessary because for tasks of type full-load and full-load-and-cdc you can only use start-replication when it's the first time the task is run. Afterwards, you have to use resume-processing, otherwise it will fail.

Proof of it, is the following error while running the acceptance tests without this change:

replication_task_test.go:100: Step 4/4 error: Error running apply: exit status 1

Error: error starting DMS Replication Task (tf-acc-test-748333755630122031): InvalidParameterCombinationException: Start Type : START_REPLICATION, valid only for tasks running for the first time status code: 400, request id: af7935aa-89d8-49de-b835-8d6a87addc65

with aws_dms_replication_task.test, on terraform_plugin_test.tf line 176, in resource "aws_dms_replication_task" "test":
    176: resource "aws_dms_replication_task" "test" {

--- FAIL: TestAccDMSReplicationTask_startReplicationTask (1373.44s)

This way, we only use start-replication after the task is on status ready, which only happens right after the task has been created.

[andrew-wiggins]

Thank you for jumping on this so quick, especially the update to fix StartReplicationTaskTypeValueStartReplication being the only start replication task type! LGTM!

[johnsonaj]

LGTM 🚀

% make testacc TESTS=TestAccReplicationTask_ PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccReplicationTask_'  -timeout 180m
=== RUN   TestAccReplicationTask_basic
=== PAUSE TestAccReplicationTask_basic
=== RUN   TestAccReplicationTask_cdcStartPosition
=== PAUSE TestAccReplicationTask_cdcStartPosition
=== RUN   TestAccReplicationTask_startReplicationTask
=== PAUSE TestAccReplicationTask_startReplicationTask
=== RUN   TestAccReplicationTask_disappears
=== PAUSE TestAccReplicationTask_disappears
=== CONT  TestAccReplicationTask_basic
=== CONT  TestAccReplicationTask_startReplicationTask
=== CONT  TestAccReplicationTask_disappears
=== CONT  TestAccReplicationTask_cdcStartPosition
--- PASS: TestAccReplicationTask_basic (520.30s)
--- PASS: TestAccReplicationTask_cdcStartPosition (520.82s)
--- PASS: TestAccReplicationTask_disappears (552.30s)
--- PASS: TestAccReplicationTask_startReplicationTask (1388.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	1391.129s

[johnsonaj]

@fermezz thanks for the contribution 🎉 👏🏾

I made a few changes for more accurate status feedback and testing

• moved status check to startReplicationTask since it is available in the find function
• added a _disappears test

[fermezz]

@fermezz thanks for the contribution 🎉 👏🏾

I made a few changes for more accurate status feedback and testing

• moved status check to startReplicationTask since it is available in the find function
• added a _disappears test

Thank you! Good changes :)

[github-actions]

This functionality has been released in v4.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.