-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added input validation for authentication elements on schema #24154
Added input validation for authentication elements on schema #24154
Conversation
6859303
to
6fe0273
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM albeit the use of all
is too verbose IMO and can always be added if actually needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccEventsConnection_ PKG=events ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 2 -run='TestAccEventsConnection_' -timeout 180m
=== RUN TestAccEventsConnection_apiKey
=== PAUSE TestAccEventsConnection_apiKey
=== RUN TestAccEventsConnection_basic
=== PAUSE TestAccEventsConnection_basic
=== RUN TestAccEventsConnection_oAuth
=== PAUSE TestAccEventsConnection_oAuth
=== RUN TestAccEventsConnection_invocationHTTPParameters
=== PAUSE TestAccEventsConnection_invocationHTTPParameters
=== RUN TestAccEventsConnection_disappears
=== PAUSE TestAccEventsConnection_disappears
=== CONT TestAccEventsConnection_apiKey
=== CONT TestAccEventsConnection_oAuth
--- PASS: TestAccEventsConnection_apiKey (57.00s)
=== CONT TestAccEventsConnection_basic
--- PASS: TestAccEventsConnection_oAuth (63.48s)
=== CONT TestAccEventsConnection_disappears
--- PASS: TestAccEventsConnection_disappears (18.09s)
=== CONT TestAccEventsConnection_invocationHTTPParameters
--- PASS: TestAccEventsConnection_basic (52.38s)
--- PASS: TestAccEventsConnection_invocationHTTPParameters (49.97s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/events 138.577s
@AdamTylerLynch Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.10.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Bug confirmed, and reproduced. This bug manifests itself as a casting error and a panic, but it is due to improper input validation on the schema.
As per AWS API docs, all credentials used for different types of authentication have a min length of 1.
Added input validation for authentication elements as per AWS API Docs.
Closes #24061
Output from acceptance testing: