Add aws_nat_gateways data source

[iandrewt]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #7575

Output from acceptance testing:

$ make testacc TESTS=TestAccEC2NatGatewaysDataSource_basic PKG=ec2

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2NATGatewaysDataSource_basic'  -timeout 180m
=== RUN   TestAccEC2NATGatewaysDataSource_basic
=== PAUSE TestAccEC2NATGatewaysDataSource_basic
=== CONT  TestAccEC2NATGatewaysDataSource_basic
--- PASS: TestAccEC2NATGatewaysDataSource_basic (260.82s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        262.364s

I decided to build this in the same way that aws_route_tables and aws_subnets are done, where they only return the ids to be used in other data sources/resources, instead of how #7575 suggested where everything is returned plurally, but I'm happy to revisit that method if it's preferred

[github-actions]

Welcome @iandrewt 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[iandrewt]

Ah I must have confused gofmt with terrafmt. Thanks for fixing those issues :)

[ewbankkit]

LGTM 🚀.

% make testacc TESTS=TestAccEC2NATGatewaysDataSource_ PKG=ec2   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2NATGatewaysDataSource_'  -timeout 180m
=== RUN   TestAccEC2NATGatewaysDataSource_basic
=== PAUSE TestAccEC2NATGatewaysDataSource_basic
=== CONT  TestAccEC2NATGatewaysDataSource_basic
--- PASS: TestAccEC2NATGatewaysDataSource_basic (199.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	202.869s

[ewbankkit]

@iandrewt Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.10.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.