-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aws_nat_gateways data source #24190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @iandrewt 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Ah I must have confused |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccEC2NATGatewaysDataSource_ PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2NATGatewaysDataSource_' -timeout 180m
=== RUN TestAccEC2NATGatewaysDataSource_basic
=== PAUSE TestAccEC2NATGatewaysDataSource_basic
=== CONT TestAccEC2NATGatewaysDataSource_basic
--- PASS: TestAccEC2NATGatewaysDataSource_basic (199.00s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 202.869s
@iandrewt Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.10.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #7575
Output from acceptance testing:
I decided to build this in the same way that
aws_route_tables
andaws_subnets
are done, where they only return the ids to be used in other data sources/resources, instead of how #7575 suggested where everything is returned plurally, but I'm happy to revisit that method if it's preferred