Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/emr_cluster - Skip error on UnknownOperationException #24237

Merged
merged 7 commits into from
Apr 14, 2022
Merged

r/emr_cluster - Skip error on UnknownOperationException #24237

merged 7 commits into from
Apr 14, 2022

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24186

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@DrFaust92 DrFaust92 mentioned this pull request Apr 14, 2022
Closed
@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/emr Issues and PRs that pertain to the emr service. labels Apr 14, 2022
@DrFaust92 DrFaust92 added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 14, 2022
@ewbankkit ewbankkit added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Apr 14, 2022
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Apr 14, 2022
ewbankkit
ewbankkit approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

AWS Commercial
% make testacc TESTS=TestAccEMRCluster_autoTerminationPolicy PKG=emr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emr/... -v -count 1 -parallel 20 -run='TestAccEMRCluster_autoTerminationPolicy'  -timeout 180m
=== RUN   TestAccEMRCluster_autoTerminationPolicy
=== PAUSE TestAccEMRCluster_autoTerminationPolicy
=== CONT  TestAccEMRCluster_autoTerminationPolicy
--- PASS: TestAccEMRCluster_autoTerminationPolicy (661.50s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emr	666.120s
```console

##### AWS GovCloud

```console
% make testacc TESTS=TestAccEMRCluster_basic PKG=emr                
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emr/... -v -count 1 -parallel 20 -run='TestAccEMRCluster_basic'  -timeout 180m
=== RUN   TestAccEMRCluster_basic
=== PAUSE TestAccEMRCluster_basic
=== CONT  TestAccEMRCluster_basic
--- PASS: TestAccEMRCluster_basic (393.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emr	398.054s
% make testacc TESTS=TestAccEMRCluster_autoTerminationPolicy PKG=emr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emr/... -v -count 1 -parallel 20 -run='TestAccEMRCluster_autoTerminationPolicy'  -timeout 180m
=== RUN   TestAccEMRCluster_autoTerminationPolicy
=== PAUSE TestAccEMRCluster_autoTerminationPolicy
=== CONT  TestAccEMRCluster_autoTerminationPolicy
    acctest.go:681: skipping tests; current partition (aws-us-gov) not supported
--- SKIP: TestAccEMRCluster_autoTerminationPolicy (8.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emr	12.094s

@github-actions github-actions bot added service/ecs Issues and PRs that pertain to the ecs service. service/iam Issues and PRs that pertain to the iam service. service/lambda Issues and PRs that pertain to the lambda service. service/rds Issues and PRs that pertain to the rds service. service/route53 Issues and PRs that pertain to the route53 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Apr 14, 2022
@ewbankkit ewbankkit removed service/lambda Issues and PRs that pertain to the lambda service. service/iam Issues and PRs that pertain to the iam service. service/route53 Issues and PRs that pertain to the route53 service. service/rds Issues and PRs that pertain to the rds service. service/ecs Issues and PRs that pertain to the ecs service. labels Apr 14, 2022
@github-actions github-actions bot added service/ecs Issues and PRs that pertain to the ecs service. service/iam Issues and PRs that pertain to the iam service. service/lambda Issues and PRs that pertain to the lambda service. service/rds Issues and PRs that pertain to the rds service. service/route53 Issues and PRs that pertain to the route53 service. labels Apr 14, 2022
@ewbankkit ewbankkit removed service/lambda Issues and PRs that pertain to the lambda service. service/iam Issues and PRs that pertain to the iam service. service/ecs Issues and PRs that pertain to the ecs service. service/route53 Issues and PRs that pertain to the route53 service. service/rds Issues and PRs that pertain to the rds service. labels Apr 14, 2022
@ewbankkit ewbankkit merged commit a4ae773 into hashicorp:main Apr 14, 2022
@github-actions github-actions bot added this to the v4.10.0 milestone Apr 14, 2022
@DrFaust92 DrFaust92 deleted the emr-term-policy-gov branch April 14, 2022 19:21
@github-actions
Copy link

This functionality has been released in v4.10.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@harshadt-tw harshadt-tw mentioned this pull request Apr 18, 2022
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. partition/aws-us-gov Pertains to the aws-us-gov partition. service/emr Issues and PRs that pertain to the emr service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.10.0
Development

Successfully merging this pull request may close these issues.

aws_emr_cluster resource is broken in US Gov regions
2 participants
@DrFaust92 @ewbankkit