Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/transfer_workflow - new resource #24248

Merged
merged 20 commits into from
Apr 15, 2022
Merged

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Apr 14, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21808

Output from acceptance testing:

$ make testacc TESTS=TestAccWorkflow_ PKG=transfer
--- PASS: TestAccWorkflow_basic (35.85s)
--- PASS: TestAccWorkflow_onExecution (29.75s)
--- PASS: TestAccWorkflow_description (31.09s)
--- PASS: TestAccWorkflow_tags (75.47s)
--- PASS: TestAccWorkflow_disappears (21.26s)
$  make testacc TESTS=TestAccTransfer_serial/Server/Workflow PKG=transfer 
--- PASS: TestAccTransfer_serial (205.86s)
    --- PASS: TestAccTransfer_serial/Server (205.86s)
        --- PASS: TestAccTransfer_serial/Server/Workflow (205.86s)

@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. service/transfer Issues and PRs that pertain to the transfer service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. labels Apr 14, 2022
@DrFaust92 DrFaust92 added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 14, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Apr 14, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review April 14, 2022 20:43
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 15, 2022
@github-actions github-actions bot added the sweeper Pertains to changes to or issues with the sweeper. label Apr 15, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTS=TestAccTransferWorkflow_ PKG=transfer ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 3 -run='TestAccTransferWorkflow_'  -timeout 180m
=== RUN   TestAccTransferWorkflow_basic
--- PASS: TestAccTransferWorkflow_basic (17.00s)
=== RUN   TestAccTransferWorkflow_onExecution
--- PASS: TestAccTransferWorkflow_onExecution (17.27s)
=== RUN   TestAccTransferWorkflow_description
--- PASS: TestAccTransferWorkflow_description (16.18s)
=== RUN   TestAccTransferWorkflow_tags
--- PASS: TestAccTransferWorkflow_tags (40.27s)
=== RUN   TestAccTransferWorkflow_disappears
--- PASS: TestAccTransferWorkflow_disappears (11.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	106.374s
% make testacc TESTS=TestAccTransfer_serial/Server/basic PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20 -run='TestAccTransfer_serial/Server/basic'  -timeout 180m
=== RUN   TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/Server
=== RUN   TestAccTransfer_serial/Server/basic
--- PASS: TestAccTransfer_serial (207.52s)
    --- PASS: TestAccTransfer_serial/Server (207.52s)
        --- PASS: TestAccTransfer_serial/Server/basic (207.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	211.125s
% make testacc TESTS=TestAccTransfer_serial/Server/Workflow PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20 -run='TestAccTransfer_serial/Server/Workflow'  -timeout 180m
=== RUN   TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/Server
=== RUN   TestAccTransfer_serial/Server/Workflow
--- PASS: TestAccTransfer_serial (211.52s)
    --- PASS: TestAccTransfer_serial/Server (211.52s)
        --- PASS: TestAccTransfer_serial/Server/Workflow (211.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	214.987s
% make testacc TESTS=TestAccTransfer_serial/Server/VPCEndpointID PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20 -run='TestAccTransfer_serial/Server/VPCEndpointID'  -timeout 180m
=== RUN   TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/Server
=== RUN   TestAccTransfer_serial/Server/VPCEndpointID
--- PASS: TestAccTransfer_serial (77.71s)
    --- PASS: TestAccTransfer_serial/Server (77.71s)
        --- PASS: TestAccTransfer_serial/Server/VPCEndpointID (77.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	81.161s
GovCloud
% make testacc TESTS=TestAccTransferWorkflow_ PKG=transfer ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 3 -run='TestAccTransferWorkflow_'  -timeout 180m
=== RUN   TestAccTransferWorkflow_basic
--- PASS: TestAccTransferWorkflow_basic (28.87s)
=== RUN   TestAccTransferWorkflow_onExecution
--- PASS: TestAccTransferWorkflow_onExecution (19.03s)
=== RUN   TestAccTransferWorkflow_description
--- PASS: TestAccTransferWorkflow_description (18.20s)
=== RUN   TestAccTransferWorkflow_tags
--- PASS: TestAccTransferWorkflow_tags (45.43s)
=== RUN   TestAccTransferWorkflow_disappears
--- PASS: TestAccTransferWorkflow_disappears (13.93s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	135.938s
% make testacc TESTS=TestAccTransfer_serial/Server/VPCEndpointID PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20 -run='TestAccTransfer_serial/Server/VPCEndpointID'  -timeout 180m
=== RUN   TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/Server
=== RUN   TestAccTransfer_serial/Server/VPCEndpointID
    acctest.go:681: skipping tests; current partition (aws-us-gov) not supported
--- PASS: TestAccTransfer_serial (1.51s)
    --- PASS: TestAccTransfer_serial/Server (1.51s)
        --- SKIP: TestAccTransfer_serial/Server/VPCEndpointID (1.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	5.088s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit b5c4e2a into hashicorp:main Apr 15, 2022
@github-actions github-actions bot added this to the v4.11.0 milestone Apr 15, 2022
@DrFaust92 DrFaust92 deleted the transfer-workflow branch April 15, 2022 17:06
@github-actions
Copy link

This functionality has been released in v4.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/transfer Issues and PRs that pertain to the transfer service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New resource: aws_transfer_workflow
2 participants