Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_evidently_project #24263

Merged
merged 46 commits into from
Oct 5, 2022
Merged

r/aws_evidently_project #24263

merged 46 commits into from
Oct 5, 2022

Conversation

GlennChia
Copy link
Collaborator

@GlennChia GlennChia commented Apr 15, 2022 •
edited

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #22624

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccEvidentlyProject' PKG=evidently
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/evidently/... -v -count 1 -parallel 20  -run=TestAccEvidentlyProject -timeout 180m
=== RUN   TestAccEvidentlyProject_basic
=== PAUSE TestAccEvidentlyProject_basic
=== RUN   TestAccEvidentlyProject_tags
=== PAUSE TestAccEvidentlyProject_tags
=== RUN   TestAccEvidentlyProject_updateDataDeliveryCloudWatchLogGroup
=== PAUSE TestAccEvidentlyProject_updateDataDeliveryCloudWatchLogGroup
=== RUN   TestAccEvidentlyProject_updateDataDeliveryS3Bucket
=== PAUSE TestAccEvidentlyProject_updateDataDeliveryS3Bucket
=== RUN   TestAccEvidentlyProject_updateDataDeliveryS3Prefix
=== PAUSE TestAccEvidentlyProject_updateDataDeliveryS3Prefix
=== RUN   TestAccEvidentlyProject_updateDataDeliveryCloudWatchToS3
=== PAUSE TestAccEvidentlyProject_updateDataDeliveryCloudWatchToS3
=== RUN   TestAccEvidentlyProject_disappears
=== PAUSE TestAccEvidentlyProject_disappears
=== CONT  TestAccEvidentlyProject_basic
=== CONT  TestAccEvidentlyProject_updateDataDeliveryS3Prefix
=== CONT  TestAccEvidentlyProject_disappears
=== CONT  TestAccEvidentlyProject_tags
=== CONT  TestAccEvidentlyProject_updateDataDeliveryCloudWatchLogGroup
=== CONT  TestAccEvidentlyProject_updateDataDeliveryS3Bucket
=== CONT  TestAccEvidentlyProject_updateDataDeliveryCloudWatchToS3
--- PASS: TestAccEvidentlyProject_disappears (18.96s)
--- PASS: TestAccEvidentlyProject_basic (40.58s)
--- PASS: TestAccEvidentlyProject_updateDataDeliveryCloudWatchLogGroup (49.93s)
--- PASS: TestAccEvidentlyProject_updateDataDeliveryCloudWatchToS3 (53.82s)
--- PASS: TestAccEvidentlyProject_updateDataDeliveryS3Prefix (55.10s)
--- PASS: TestAccEvidentlyProject_updateDataDeliveryS3Bucket (55.52s)
--- PASS: TestAccEvidentlyProject_tags (59.43s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/evidently  59.499s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudwatchevidently tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Apr 15, 2022
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 21, 2022
@GlennChia GlennChia removed service/ce Issues and PRs that pertain to the ce service. service/vpnclient Issues and PRs that pertain to the vpnclient service. service/appautoscaling Issues and PRs that pertain to the appautoscaling service. labels Jun 27, 2022
@GlennChia GlennChia force-pushed the f-aws_cloudwatchevidently_project branch from 01756b8 to 4f362fb Compare August 25, 2022 00:35
@GlennChia GlennChia force-pushed the f-aws_cloudwatchevidently_project branch from 4f362fb to dbf77cd Compare August 25, 2022 01:03
@GlennChia
Copy link
Collaborator Author

Most recent test results after changes

$ make testacc TESTARGS='-run=TestAccEvidentlyProject' PKG=evidently
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/evidently/... -v -count 1 -parallel 20  -run=TestAccEvidentlyProject -timeout 180m
=== RUN   TestAccEvidentlyProject_basic
=== PAUSE TestAccEvidentlyProject_basic
=== RUN   TestAccEvidentlyProject_tags
=== PAUSE TestAccEvidentlyProject_tags
=== RUN   TestAccEvidentlyProject_updateDataDeliveryCloudWatchLogGroup
=== PAUSE TestAccEvidentlyProject_updateDataDeliveryCloudWatchLogGroup
=== RUN   TestAccEvidentlyProject_updateDataDeliveryS3Bucket
=== PAUSE TestAccEvidentlyProject_updateDataDeliveryS3Bucket
=== RUN   TestAccEvidentlyProject_updateDataDeliveryS3Prefix
=== PAUSE TestAccEvidentlyProject_updateDataDeliveryS3Prefix
=== RUN   TestAccEvidentlyProject_updateDataDeliveryCloudWatchToS3
=== PAUSE TestAccEvidentlyProject_updateDataDeliveryCloudWatchToS3
=== RUN   TestAccEvidentlyProject_disappears
=== PAUSE TestAccEvidentlyProject_disappears
=== CONT  TestAccEvidentlyProject_basic
=== CONT  TestAccEvidentlyProject_updateDataDeliveryS3Prefix
=== CONT  TestAccEvidentlyProject_disappears
=== CONT  TestAccEvidentlyProject_tags
=== CONT  TestAccEvidentlyProject_updateDataDeliveryCloudWatchLogGroup
=== CONT  TestAccEvidentlyProject_updateDataDeliveryS3Bucket
=== CONT  TestAccEvidentlyProject_updateDataDeliveryCloudWatchToS3
--- PASS: TestAccEvidentlyProject_disappears (18.96s)
--- PASS: TestAccEvidentlyProject_basic (40.58s)
--- PASS: TestAccEvidentlyProject_updateDataDeliveryCloudWatchLogGroup (49.93s)
--- PASS: TestAccEvidentlyProject_updateDataDeliveryCloudWatchToS3 (53.82s)
--- PASS: TestAccEvidentlyProject_updateDataDeliveryS3Prefix (55.10s)
--- PASS: TestAccEvidentlyProject_updateDataDeliveryS3Bucket (55.52s)
--- PASS: TestAccEvidentlyProject_tags (59.43s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/evidently  59.499s

ewbankkit
ewbankkit approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEvidentlyProject_' PKG=evidently ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/evidently/... -v -count 1 -parallel 2  -run=TestAccEvidentlyProject_ -timeout 180m
=== RUN   TestAccEvidentlyProject_basic
=== PAUSE TestAccEvidentlyProject_basic
=== RUN   TestAccEvidentlyProject_tags
=== PAUSE TestAccEvidentlyProject_tags
=== RUN   TestAccEvidentlyProject_updateDataDeliveryCloudWatchLogGroup
=== PAUSE TestAccEvidentlyProject_updateDataDeliveryCloudWatchLogGroup
=== RUN   TestAccEvidentlyProject_updateDataDeliveryS3Bucket
=== PAUSE TestAccEvidentlyProject_updateDataDeliveryS3Bucket
=== RUN   TestAccEvidentlyProject_updateDataDeliveryS3Prefix
=== PAUSE TestAccEvidentlyProject_updateDataDeliveryS3Prefix
=== RUN   TestAccEvidentlyProject_updateDataDeliveryCloudWatchToS3
=== PAUSE TestAccEvidentlyProject_updateDataDeliveryCloudWatchToS3
=== RUN   TestAccEvidentlyProject_disappears
=== PAUSE TestAccEvidentlyProject_disappears
=== CONT  TestAccEvidentlyProject_basic
=== CONT  TestAccEvidentlyProject_updateDataDeliveryS3Prefix
--- PASS: TestAccEvidentlyProject_basic (40.47s)
=== CONT  TestAccEvidentlyProject_updateDataDeliveryCloudWatchLogGroup
--- PASS: TestAccEvidentlyProject_updateDataDeliveryS3Prefix (52.68s)
=== CONT  TestAccEvidentlyProject_updateDataDeliveryS3Bucket
--- PASS: TestAccEvidentlyProject_updateDataDeliveryCloudWatchLogGroup (47.96s)
=== CONT  TestAccEvidentlyProject_tags
--- PASS: TestAccEvidentlyProject_updateDataDeliveryS3Bucket (51.97s)
=== CONT  TestAccEvidentlyProject_disappears
--- PASS: TestAccEvidentlyProject_disappears (16.88s)
=== CONT  TestAccEvidentlyProject_updateDataDeliveryCloudWatchToS3
--- PASS: TestAccEvidentlyProject_tags (58.53s)
--- PASS: TestAccEvidentlyProject_updateDataDeliveryCloudWatchToS3 (48.69s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/evidently	176.417s

@ewbankkit
Copy link
Contributor

@GlennChia Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit efe2563 into hashicorp:main Oct 5, 2022
@github-actions github-actions bot added this to the v4.34.0 milestone Oct 5, 2022
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

This functionality has been released in v4.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@GlennChia GlennChia mentioned this pull request Oct 19, 2022
Merged
@github-actions
Copy link

github-actions bot commented Nov 6, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

@DrFaust92 DrFaust92 DrFaust92 approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/evidently Issues and PRs that pertain to the evidently service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.34.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@GlennChia @DrFaust92 @ewbankkit @justinretzolk @hc-github-team-terraform-aws