Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/aws fsx ontap file system #24280

Merged
merged 10,000 commits into from
Apr 18, 2022
Merged

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Apr 16, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #24231

Output from acceptance testing:

$ make testacc TESTS=TestAccFSxOntapFileSystem_fsxSingleAz PKG=fsx 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 20 -run='TestAccFSxOntapFileSystem_fsxSingleAz'  -timeout 180m
=== RUN   TestAccFSxOntapFileSystem_fsxSingleAz
=== PAUSE TestAccFSxOntapFileSystem_fsxSingleAz
=== CONT  TestAccFSxOntapFileSystem_fsxSingleAz
--- PASS: TestAccFSxOntapFileSystem_fsxSingleAz (2119.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	2124.575s

...

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/ec2 Issues and PRs that pertain to the ec2 service. service/fsx Issues and PRs that pertain to the fsx service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/S Managed by automation to categorize the size of a PR. labels Apr 16, 2022
@github-actions github-actions bot removed service/ec2 Issues and PRs that pertain to the ec2 service. service/cloudformation Issues and PRs that pertain to the cloudformation service. labels Apr 16, 2022
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 16, 2022
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikhil-goenka please add changelog entry, otherwise LGTM

@nikhil-goenka
Copy link
Contributor Author

@nikhil-goenka please add changelog entry, otherwise LGTM

updated changelog

@ewbankkit
Copy link
Contributor

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@nikhil-goenka Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 6f1a9ab into hashicorp:main Apr 18, 2022
@github-actions github-actions bot added this to the v4.11.0 milestone Apr 18, 2022
@github-actions
Copy link

This functionality has been released in v4.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/fsx Issues and PRs that pertain to the fsx service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource aws_fsx_ontap_file_system allow deployment type Single AZ
5 participants