Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/aws opensearch domain Support for cold_storage #24284

Merged
merged 7 commits into from
Apr 18, 2022

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Apr 16, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24195.
Relates #19713.

Output from acceptance testing:

$ make testacc TESTS=TestAccOpenSearchDomain_Cluster_coldStorage PKG=opensearch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearch/... -v -count 1 -parallel 20 -run='TestAccOpenSearchDomain_Cluster_coldStorage'  -timeout 180m
=== RUN   TestAccOpenSearchDomain_Cluster_coldStorage
=== PAUSE TestAccOpenSearchDomain_Cluster_coldStorage
=== CONT  TestAccOpenSearchDomain_Cluster_coldStorage
--- PASS: TestAccOpenSearchDomain_Cluster_coldStorage (3013.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearch	3019.363s

...

@github-actions github-actions bot added service/opensearch Issues and PRs that pertain to the opensearch service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. labels Apr 16, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Apr 18, 2022
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Apr 18, 2022
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 18, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccOpenSearchDomain_basic\|TestAccOpenSearchDomain_Cluster_coldStorage\|TestAccOpenSearchDomain_Cluster_warm\|TestAccOpenSearchDomainDataSource_Data_basic' PKG=opensearch ACCTEST_PARALLELISM=2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearch/... -v -count 1 -parallel 2  -run=TestAccOpenSearchDomain_basic\|TestAccOpenSearchDomain_Cluster_coldStorage\|TestAccOpenSearchDomain_Cluster_warm\|TestAccOpenSearchDomainDataSource_Data_basic -timeout 180m
=== RUN   TestAccOpenSearchDomainDataSource_Data_basic
=== PAUSE TestAccOpenSearchDomainDataSource_Data_basic
=== RUN   TestAccOpenSearchDomain_basic
=== PAUSE TestAccOpenSearchDomain_basic
=== RUN   TestAccOpenSearchDomain_Cluster_coldStorage
=== PAUSE TestAccOpenSearchDomain_Cluster_coldStorage
=== RUN   TestAccOpenSearchDomain_Cluster_warm
=== PAUSE TestAccOpenSearchDomain_Cluster_warm
=== CONT  TestAccOpenSearchDomainDataSource_Data_basic
=== CONT  TestAccOpenSearchDomain_Cluster_coldStorage
--- PASS: TestAccOpenSearchDomainDataSource_Data_basic (1750.29s)
=== CONT  TestAccOpenSearchDomain_Cluster_warm
--- PASS: TestAccOpenSearchDomain_Cluster_coldStorage (3137.60s)
=== CONT  TestAccOpenSearchDomain_basic
--- PASS: TestAccOpenSearchDomain_basic (1522.93s)
--- PASS: TestAccOpenSearchDomain_Cluster_warm (4711.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearch	6466.728s

@ewbankkit
Copy link
Contributor

@nikhil-goenka Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit f7e7008 into hashicorp:main Apr 18, 2022
@github-actions github-actions bot added this to the v4.11.0 milestone Apr 18, 2022
@github-actions
Copy link

This functionality has been released in v4.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/opensearch Issues and PRs that pertain to the opensearch service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenSearch cold_storage_options not expected
2 participants