Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rd/aw_ imagebuilder_infrastructure_configuration - instance metadata options #24285

Conversation

kamilturek
Copy link
Collaborator

@kamilturek kamilturek commented Apr 16, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24006.

Output from acceptance testing:

$ make testacc PKG=imagebuilder TESTS="TestAccImageBuilderInfrastructureConfiguration_|TestAccImageBuilderInfrastructureConfigurationDataSource_" ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/imagebuilder/... -v -count 1 -parallel 2 -run='TestAccImageBuilderInfrastructureConfiguration_|TestAccImageBuilderInfrastructureConfigurationDataSource_'  -timeout 180m
=== RUN   TestAccImageBuilderInfrastructureConfigurationDataSource_arn
=== PAUSE TestAccImageBuilderInfrastructureConfigurationDataSource_arn
=== RUN   TestAccImageBuilderInfrastructureConfiguration_basic
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_basic
=== RUN   TestAccImageBuilderInfrastructureConfiguration_disappears
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_disappears
=== RUN   TestAccImageBuilderInfrastructureConfiguration_description
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_description
=== RUN   TestAccImageBuilderInfrastructureConfiguration_instanceMetadataOptions
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_instanceMetadataOptions
=== RUN   TestAccImageBuilderInfrastructureConfiguration_instanceProfileName
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_instanceProfileName
=== RUN   TestAccImageBuilderInfrastructureConfiguration_instanceTypes
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_instanceTypes
=== RUN   TestAccImageBuilderInfrastructureConfiguration_keyPair
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_keyPair
=== RUN   TestAccImageBuilderInfrastructureConfiguration_LoggingS3Logs_s3BucketName
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_LoggingS3Logs_s3BucketName
=== RUN   TestAccImageBuilderInfrastructureConfiguration_LoggingS3Logs_s3KeyPrefix
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_LoggingS3Logs_s3KeyPrefix
=== RUN   TestAccImageBuilderInfrastructureConfiguration_resourceTags
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_resourceTags
=== RUN   TestAccImageBuilderInfrastructureConfiguration_securityGroupIDs
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_securityGroupIDs
=== RUN   TestAccImageBuilderInfrastructureConfiguration_snsTopicARN
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_snsTopicARN
=== RUN   TestAccImageBuilderInfrastructureConfiguration_subnetID
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_subnetID
=== RUN   TestAccImageBuilderInfrastructureConfiguration_tags
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_tags
=== RUN   TestAccImageBuilderInfrastructureConfiguration_terminateInstanceOnFailure
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_terminateInstanceOnFailure
=== CONT  TestAccImageBuilderInfrastructureConfigurationDataSource_arn
=== CONT  TestAccImageBuilderInfrastructureConfiguration_LoggingS3Logs_s3BucketName
--- PASS: TestAccImageBuilderInfrastructureConfigurationDataSource_arn (43.06s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_terminateInstanceOnFailure
--- PASS: TestAccImageBuilderInfrastructureConfiguration_LoggingS3Logs_s3BucketName (90.97s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_tags
--- PASS: TestAccImageBuilderInfrastructureConfiguration_terminateInstanceOnFailure (62.03s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_subnetID
--- PASS: TestAccImageBuilderInfrastructureConfiguration_subnetID (66.31s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_snsTopicARN
--- PASS: TestAccImageBuilderInfrastructureConfiguration_tags (85.36s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_securityGroupIDs
--- PASS: TestAccImageBuilderInfrastructureConfiguration_snsTopicARN (67.83s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_resourceTags
--- PASS: TestAccImageBuilderInfrastructureConfiguration_securityGroupIDs (65.72s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_LoggingS3Logs_s3KeyPrefix
--- PASS: TestAccImageBuilderInfrastructureConfiguration_LoggingS3Logs_s3KeyPrefix (73.36s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_instanceMetadataOptions
--- PASS: TestAccImageBuilderInfrastructureConfiguration_resourceTags (94.31s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_keyPair
--- PASS: TestAccImageBuilderInfrastructureConfiguration_instanceMetadataOptions (40.43s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_instanceTypes
--- PASS: TestAccImageBuilderInfrastructureConfiguration_instanceTypes (64.98s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_instanceProfileName
--- PASS: TestAccImageBuilderInfrastructureConfiguration_keyPair (96.57s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_disappears
--- PASS: TestAccImageBuilderInfrastructureConfiguration_disappears (36.50s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_description
--- PASS: TestAccImageBuilderInfrastructureConfiguration_instanceProfileName (72.53s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_basic
--- PASS: TestAccImageBuilderInfrastructureConfiguration_description (62.79s)
--- PASS: TestAccImageBuilderInfrastructureConfiguration_basic (40.27s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder       535.338s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 16, 2022
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Apr 16, 2022
@kamilturek kamilturek marked this pull request as ready for review April 16, 2022 18:43
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 18, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccImageBuilderInfrastructureConfiguration PKG=imagebuilder ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/imagebuilder/... -v -count 1 -parallel 2 -run='TestAccImageBuilderInfrastructureConfiguration'  -timeout 180m
=== RUN   TestAccImageBuilderInfrastructureConfigurationDataSource_arn
=== PAUSE TestAccImageBuilderInfrastructureConfigurationDataSource_arn
=== RUN   TestAccImageBuilderInfrastructureConfiguration_basic
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_basic
=== RUN   TestAccImageBuilderInfrastructureConfiguration_disappears
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_disappears
=== RUN   TestAccImageBuilderInfrastructureConfiguration_description
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_description
=== RUN   TestAccImageBuilderInfrastructureConfiguration_instanceMetadataOptions
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_instanceMetadataOptions
=== RUN   TestAccImageBuilderInfrastructureConfiguration_instanceProfileName
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_instanceProfileName
=== RUN   TestAccImageBuilderInfrastructureConfiguration_instanceTypes
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_instanceTypes
=== RUN   TestAccImageBuilderInfrastructureConfiguration_keyPair
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_keyPair
=== RUN   TestAccImageBuilderInfrastructureConfiguration_LoggingS3Logs_s3BucketName
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_LoggingS3Logs_s3BucketName
=== RUN   TestAccImageBuilderInfrastructureConfiguration_LoggingS3Logs_s3KeyPrefix
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_LoggingS3Logs_s3KeyPrefix
=== RUN   TestAccImageBuilderInfrastructureConfiguration_resourceTags
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_resourceTags
=== RUN   TestAccImageBuilderInfrastructureConfiguration_securityGroupIDs
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_securityGroupIDs
=== RUN   TestAccImageBuilderInfrastructureConfiguration_snsTopicARN
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_snsTopicARN
=== RUN   TestAccImageBuilderInfrastructureConfiguration_subnetID
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_subnetID
=== RUN   TestAccImageBuilderInfrastructureConfiguration_tags
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_tags
=== RUN   TestAccImageBuilderInfrastructureConfiguration_terminateInstanceOnFailure
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_terminateInstanceOnFailure
=== RUN   TestAccImageBuilderInfrastructureConfigurationsDataSource_filter
=== PAUSE TestAccImageBuilderInfrastructureConfigurationsDataSource_filter
=== CONT  TestAccImageBuilderInfrastructureConfigurationDataSource_arn
=== CONT  TestAccImageBuilderInfrastructureConfiguration_LoggingS3Logs_s3KeyPrefix
--- PASS: TestAccImageBuilderInfrastructureConfigurationDataSource_arn (65.59s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_subnetID
--- PASS: TestAccImageBuilderInfrastructureConfiguration_LoggingS3Logs_s3KeyPrefix (137.59s)
=== CONT  TestAccImageBuilderInfrastructureConfigurationsDataSource_filter
--- PASS: TestAccImageBuilderInfrastructureConfiguration_subnetID (94.49s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_terminateInstanceOnFailure
--- PASS: TestAccImageBuilderInfrastructureConfigurationsDataSource_filter (47.35s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_tags
--- PASS: TestAccImageBuilderInfrastructureConfiguration_terminateInstanceOnFailure (56.95s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_securityGroupIDs
--- PASS: TestAccImageBuilderInfrastructureConfiguration_securityGroupIDs (64.51s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_snsTopicARN
--- PASS: TestAccImageBuilderInfrastructureConfiguration_tags (140.56s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_instanceProfileName
--- PASS: TestAccImageBuilderInfrastructureConfiguration_snsTopicARN (59.29s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_LoggingS3Logs_s3BucketName
--- PASS: TestAccImageBuilderInfrastructureConfiguration_instanceProfileName (64.35s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_keyPair
--- PASS: TestAccImageBuilderInfrastructureConfiguration_LoggingS3Logs_s3BucketName (60.58s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_instanceTypes
--- PASS: TestAccImageBuilderInfrastructureConfiguration_keyPair (54.37s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_description
--- PASS: TestAccImageBuilderInfrastructureConfiguration_instanceTypes (54.01s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_instanceMetadataOptions
--- PASS: TestAccImageBuilderInfrastructureConfiguration_instanceMetadataOptions (40.51s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_disappears
--- PASS: TestAccImageBuilderInfrastructureConfiguration_description (57.26s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_basic
--- PASS: TestAccImageBuilderInfrastructureConfiguration_disappears (34.93s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_resourceTags
--- PASS: TestAccImageBuilderInfrastructureConfiguration_basic (38.33s)
--- PASS: TestAccImageBuilderInfrastructureConfiguration_resourceTags (53.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder	593.219s

@ewbankkit
Copy link
Contributor

@kamilturek Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 2a5328e into hashicorp:main Apr 18, 2022
@github-actions github-actions bot added this to the v4.11.0 milestone Apr 18, 2022
@github-actions
Copy link

This functionality has been released in v4.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support metadata aws_imagebuilder_infrastructure_configuration
2 participants