-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ds/efs_file_system: return error when filtering by tags returns results != 1 #24298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccEFSFileSystemDataSource_ PKG=efs ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/efs/... -v -count 1 -parallel 2 -run='TestAccEFSFileSystemDataSource_' -timeout 180m
=== RUN TestAccEFSFileSystemDataSource_id
=== PAUSE TestAccEFSFileSystemDataSource_id
=== RUN TestAccEFSFileSystemDataSource_tags
=== PAUSE TestAccEFSFileSystemDataSource_tags
=== RUN TestAccEFSFileSystemDataSource_name
=== PAUSE TestAccEFSFileSystemDataSource_name
=== RUN TestAccEFSFileSystemDataSource_availabilityZone
=== PAUSE TestAccEFSFileSystemDataSource_availabilityZone
=== RUN TestAccEFSFileSystemDataSource_nonExistent_fileSystemID
=== PAUSE TestAccEFSFileSystemDataSource_nonExistent_fileSystemID
=== RUN TestAccEFSFileSystemDataSource_nonExistent_tags
=== PAUSE TestAccEFSFileSystemDataSource_nonExistent_tags
=== CONT TestAccEFSFileSystemDataSource_id
=== CONT TestAccEFSFileSystemDataSource_availabilityZone
--- PASS: TestAccEFSFileSystemDataSource_id (26.00s)
=== CONT TestAccEFSFileSystemDataSource_nonExistent_tags
--- PASS: TestAccEFSFileSystemDataSource_availabilityZone (26.37s)
=== CONT TestAccEFSFileSystemDataSource_nonExistent_fileSystemID
--- PASS: TestAccEFSFileSystemDataSource_nonExistent_fileSystemID (2.83s)
=== CONT TestAccEFSFileSystemDataSource_name
--- PASS: TestAccEFSFileSystemDataSource_nonExistent_tags (26.56s)
=== CONT TestAccEFSFileSystemDataSource_tags
--- PASS: TestAccEFSFileSystemDataSource_name (27.23s)
--- PASS: TestAccEFSFileSystemDataSource_tags (23.53s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/efs 85.291s
This functionality has been released in v4.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #24031
Closes #23309
Closes #21642
Output from acceptance testing: