Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ds/efs_file_system: return error when filtering by tags returns results != 1 #24298

Merged
merged 2 commits into from
Apr 18, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Apr 18, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24031
Closes #23309
Closes #21642

Output from acceptance testing:

--- PASS: TestAccEFSFileSystemDataSource_nonExistent_fileSystemID (18.35s)
--- PASS: TestAccEFSFileSystemDataSource_nonExistent_tags (55.12s)
--- PASS: TestAccEFSFileSystemDataSource_id (55.58s)
--- PASS: TestAccEFSFileSystemDataSource_availabilityZone (59.63s)
--- PASS: TestAccEFSFileSystemDataSource_tags (62.36s)
--- PASS: TestAccEFSFileSystemDataSource_name (67.06s)

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. service/efs Issues and PRs that pertain to the efs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 18, 2022
@anGie44 anGie44 marked this pull request as ready for review April 18, 2022 17:38
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Apr 18, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccEFSFileSystemDataSource_ PKG=efs ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/efs/... -v -count 1 -parallel 2 -run='TestAccEFSFileSystemDataSource_'  -timeout 180m
=== RUN   TestAccEFSFileSystemDataSource_id
=== PAUSE TestAccEFSFileSystemDataSource_id
=== RUN   TestAccEFSFileSystemDataSource_tags
=== PAUSE TestAccEFSFileSystemDataSource_tags
=== RUN   TestAccEFSFileSystemDataSource_name
=== PAUSE TestAccEFSFileSystemDataSource_name
=== RUN   TestAccEFSFileSystemDataSource_availabilityZone
=== PAUSE TestAccEFSFileSystemDataSource_availabilityZone
=== RUN   TestAccEFSFileSystemDataSource_nonExistent_fileSystemID
=== PAUSE TestAccEFSFileSystemDataSource_nonExistent_fileSystemID
=== RUN   TestAccEFSFileSystemDataSource_nonExistent_tags
=== PAUSE TestAccEFSFileSystemDataSource_nonExistent_tags
=== CONT  TestAccEFSFileSystemDataSource_id
=== CONT  TestAccEFSFileSystemDataSource_availabilityZone
--- PASS: TestAccEFSFileSystemDataSource_id (26.00s)
=== CONT  TestAccEFSFileSystemDataSource_nonExistent_tags
--- PASS: TestAccEFSFileSystemDataSource_availabilityZone (26.37s)
=== CONT  TestAccEFSFileSystemDataSource_nonExistent_fileSystemID
--- PASS: TestAccEFSFileSystemDataSource_nonExistent_fileSystemID (2.83s)
=== CONT  TestAccEFSFileSystemDataSource_name
--- PASS: TestAccEFSFileSystemDataSource_nonExistent_tags (26.56s)
=== CONT  TestAccEFSFileSystemDataSource_tags
--- PASS: TestAccEFSFileSystemDataSource_name (27.23s)
--- PASS: TestAccEFSFileSystemDataSource_tags (23.53s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/efs	85.291s

@anGie44 anGie44 added this to the v4.11.0 milestone Apr 18, 2022
@anGie44 anGie44 merged commit f197bd6 into main Apr 18, 2022
@anGie44 anGie44 deleted the b-efs-file-system-ds-panic branch April 18, 2022 18:41
github-actions bot pushed a commit that referenced this pull request Apr 18, 2022
@github-actions
Copy link

This functionality has been released in v4.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/efs Issues and PRs that pertain to the efs service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants