data-source/db_instance: prevent panic when endpoint not available #24299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
service/rds
anGie44
force-pushed
the
b-rds-instance-data-source-panic
branch
from
9323360
to
e69f4c3
Compare
github-actions
bot
added
size/XS
github-actions
bot
added
size/S
anGie44
changed the title
ewbankkit
approved these changes
Apr 18, 2022
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTS=TestAccRDSInstanceDataSource_ PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2 -run='TestAccRDSInstanceDataSource_' -timeout 180m
=== RUN TestAccRDSInstanceDataSource_basic
=== PAUSE TestAccRDSInstanceDataSource_basic
=== RUN TestAccRDSInstanceDataSource_ec2Classic
=== PAUSE TestAccRDSInstanceDataSource_ec2Classic
=== CONT TestAccRDSInstanceDataSource_basic
=== CONT TestAccRDSInstanceDataSource_ec2Classic
--- PASS: TestAccRDSInstanceDataSource_ec2Classic (627.16s)
--- PASS: TestAccRDSInstanceDataSource_basic (660.69s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 664.481s
|
This functionality has been released in v4.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #23925
Output from acceptance testing: