-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data-source/db_instance: prevent panic when endpoint not available #24299
Conversation
9323360
to
e69f4c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccRDSInstanceDataSource_ PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2 -run='TestAccRDSInstanceDataSource_' -timeout 180m
=== RUN TestAccRDSInstanceDataSource_basic
=== PAUSE TestAccRDSInstanceDataSource_basic
=== RUN TestAccRDSInstanceDataSource_ec2Classic
=== PAUSE TestAccRDSInstanceDataSource_ec2Classic
=== CONT TestAccRDSInstanceDataSource_basic
=== CONT TestAccRDSInstanceDataSource_ec2Classic
--- PASS: TestAccRDSInstanceDataSource_ec2Classic (627.16s)
--- PASS: TestAccRDSInstanceDataSource_basic (660.69s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 664.481s
This functionality has been released in v4.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #23925
Output from acceptance testing: