Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/ssm_association: use the Overview.Status field in the custom wait function instead of the root-level Status #24300

Merged
merged 2 commits into from
Apr 18, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Apr 18, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23326

Output from acceptance testing:

--- PASS: TestAccSSMAssociation_withOutputLocation_waitForSuccessTimeout (38.61s)
--- PASS: TestAccSSMAssociation_withDocumentVersion (31.01s)
--- PASS: TestAccSSMAssociation_withAssociationNameAndScheduleExpression (40.88s)
--- PASS: TestAccSSMAssociation_withAssociationName (43.10s)
--- PASS: TestAccSSMAssociation_rateControl (49.74s)
--- PASS: TestAccSSMAssociation_withScheduleExpression (50.53s)
--- PASS: TestAccSSMAssociation_withComplianceSeverity (55.12s)
--- PASS: TestAccSSMAssociation_withParameters (61.99s)
--- PASS: TestAccSSMAssociation_withTargets (65.87s)
--- PASS: TestAccSSMAssociation_withAutomationTargetParamName (70.32s)
--- PASS: TestAccSSMAssociation_withOutputLocation (72.60s)
--- PASS: TestAccSSMAssociation_applyOnlyAtCronInterval (75.66s)
--- PASS: TestAccSSMAssociation_withOutputLocation_s3Region (86.53s)
--- PASS: TestAccSSMAssociation_disappears_document (119.48s)
--- PASS: TestAccSSMAssociation_disappears (122.18s)
--- PASS: TestAccSSMAssociation_basic (139.80s)

…unction instead of the root-level Status field
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Apr 18, 2022
@github-actions github-actions bot added service/ssm Issues and PRs that pertain to the ssm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Apr 18, 2022
@anGie44 anGie44 marked this pull request as ready for review April 18, 2022 20:56
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccSSMAssociation_ PKG=ssm ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 2 -run='TestAccSSMAssociation_'  -timeout 180m
=== RUN   TestAccSSMAssociation_basic
=== PAUSE TestAccSSMAssociation_basic
=== RUN   TestAccSSMAssociation_disappears
=== PAUSE TestAccSSMAssociation_disappears
=== RUN   TestAccSSMAssociation_disappears_document
=== PAUSE TestAccSSMAssociation_disappears_document
=== RUN   TestAccSSMAssociation_applyOnlyAtCronInterval
=== PAUSE TestAccSSMAssociation_applyOnlyAtCronInterval
=== RUN   TestAccSSMAssociation_withTargets
=== PAUSE TestAccSSMAssociation_withTargets
=== RUN   TestAccSSMAssociation_withParameters
=== PAUSE TestAccSSMAssociation_withParameters
=== RUN   TestAccSSMAssociation_withAssociationName
=== PAUSE TestAccSSMAssociation_withAssociationName
=== RUN   TestAccSSMAssociation_withAssociationNameAndScheduleExpression
=== PAUSE TestAccSSMAssociation_withAssociationNameAndScheduleExpression
=== RUN   TestAccSSMAssociation_withDocumentVersion
=== PAUSE TestAccSSMAssociation_withDocumentVersion
=== RUN   TestAccSSMAssociation_withOutputLocation
=== PAUSE TestAccSSMAssociation_withOutputLocation
=== RUN   TestAccSSMAssociation_withOutputLocation_s3Region
=== PAUSE TestAccSSMAssociation_withOutputLocation_s3Region
=== RUN   TestAccSSMAssociation_withOutputLocation_waitForSuccessTimeout
=== PAUSE TestAccSSMAssociation_withOutputLocation_waitForSuccessTimeout
=== RUN   TestAccSSMAssociation_withAutomationTargetParamName
=== PAUSE TestAccSSMAssociation_withAutomationTargetParamName
=== RUN   TestAccSSMAssociation_withScheduleExpression
=== PAUSE TestAccSSMAssociation_withScheduleExpression
=== RUN   TestAccSSMAssociation_withComplianceSeverity
=== PAUSE TestAccSSMAssociation_withComplianceSeverity
=== RUN   TestAccSSMAssociation_rateControl
=== PAUSE TestAccSSMAssociation_rateControl
=== CONT  TestAccSSMAssociation_basic
=== CONT  TestAccSSMAssociation_rateControl
--- PASS: TestAccSSMAssociation_rateControl (30.09s)
=== CONT  TestAccSSMAssociation_withComplianceSeverity
--- PASS: TestAccSSMAssociation_withComplianceSeverity (31.13s)
=== CONT  TestAccSSMAssociation_withScheduleExpression
--- PASS: TestAccSSMAssociation_withScheduleExpression (31.88s)
=== CONT  TestAccSSMAssociation_withAutomationTargetParamName
--- PASS: TestAccSSMAssociation_basic (130.20s)
=== CONT  TestAccSSMAssociation_withOutputLocation_waitForSuccessTimeout
--- PASS: TestAccSSMAssociation_withOutputLocation_waitForSuccessTimeout (20.94s)
=== CONT  TestAccSSMAssociation_withOutputLocation_s3Region
--- PASS: TestAccSSMAssociation_withAutomationTargetParamName (58.30s)
=== CONT  TestAccSSMAssociation_withOutputLocation
--- PASS: TestAccSSMAssociation_withOutputLocation_s3Region (56.15s)
=== CONT  TestAccSSMAssociation_withDocumentVersion
--- PASS: TestAccSSMAssociation_withOutputLocation (60.04s)
=== CONT  TestAccSSMAssociation_withAssociationNameAndScheduleExpression
--- PASS: TestAccSSMAssociation_withDocumentVersion (17.17s)
=== CONT  TestAccSSMAssociation_withAssociationName
--- PASS: TestAccSSMAssociation_withAssociationNameAndScheduleExpression (33.27s)
=== CONT  TestAccSSMAssociation_withParameters
--- PASS: TestAccSSMAssociation_withAssociationName (36.39s)
=== CONT  TestAccSSMAssociation_withTargets
--- PASS: TestAccSSMAssociation_withParameters (31.95s)
=== CONT  TestAccSSMAssociation_applyOnlyAtCronInterval
--- PASS: TestAccSSMAssociation_withTargets (41.02s)
=== CONT  TestAccSSMAssociation_disappears_document
--- PASS: TestAccSSMAssociation_applyOnlyAtCronInterval (29.48s)
=== CONT  TestAccSSMAssociation_disappears
--- PASS: TestAccSSMAssociation_disappears_document (105.84s)
--- PASS: TestAccSSMAssociation_disappears (109.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssm	419.252s

@anGie44 anGie44 added this to the v4.11.0 milestone Apr 18, 2022
@anGie44 anGie44 merged commit af508de into main Apr 18, 2022
@anGie44 anGie44 deleted the b-ssm-association-wait-panic branch April 18, 2022 22:02
github-actions bot pushed a commit that referenced this pull request Apr 18, 2022
@github-actions
Copy link

This functionality has been released in v4.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ssm Issues and PRs that pertain to the ssm service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS SSM Association crashing while running apply
2 participants