Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/macie2_member: set invitation_disable_email_notification to boolean as expected #24304

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Apr 19, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19611

Output from acceptance testing:

--- PASS: TestAccMacie2_serial (148.75s)
    --- PASS: TestAccMacie2_serial/Member (148.75s)
        --- PASS: TestAccMacie2_serial/Member/status (29.82s)
        --- PASS: TestAccMacie2_serial/Member/basic (13.15s)
        --- PASS: TestAccMacie2_serial/Member/disappears (12.14s)
        --- PASS: TestAccMacie2_serial/Member/tags (14.08s)
        --- PASS: TestAccMacie2_serial/Member/invite (26.38s)
        --- PASS: TestAccMacie2_serial/Member/invite_removed (27.28s)
        --- PASS: TestAccMacie2_serial/Member/invitation_disable_email_notification (25.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/macie2	156.595s

@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Apr 19, 2022
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. service/macie2 Issues and PRs that pertain to the macie2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 19, 2022
@anGie44 anGie44 changed the title r/macie2_member: set invitation_disable_email_notification to boolean as expected r/macie2_member: set invitation_disable_email_notification to boolean as expected Apr 19, 2022
anGie44 added a commit that referenced this pull request Apr 19, 2022
@ewbankkit ewbankkit added the crash Results from or addresses a Terraform crash or kernel panic. label Apr 19, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@anGie44 anGie44 added this to the v4.11.0 milestone Apr 19, 2022
@anGie44 anGie44 merged commit aa3aff8 into main Apr 19, 2022
@anGie44 anGie44 deleted the b-macie2-member-panic branch April 19, 2022 13:21
github-actions bot pushed a commit that referenced this pull request Apr 19, 2022
@github-actions
Copy link

This functionality has been released in v4.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/macie2 Issues and PRs that pertain to the macie2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform crash when running aws_macie2_member from Macie2 module #28841
2 participants