Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tags to Grafana schema #24358

Merged
merged 41 commits into from
Apr 27, 2022

Conversation

AndreKapraty
Copy link
Contributor

@AndreKapraty AndreKapraty commented Apr 22, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24238.

Output from acceptance testing:

$ make testacc TESTS=TestAccGrafana_serial PKG=grafana
    --- PASS: TestAccGrafana_serial/Workspace (1018.98s)
        --- PASS: TestAccGrafana_serial/Workspace/notificationDestinations (214.48s)
        --- PASS: TestAccGrafana_serial/Workspace/tags (148.63s)
...

@github-actions github-actions bot added service/grafana Issues and PRs that pertain to the grafana service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. and removed service/grafana Issues and PRs that pertain to the grafana service. labels Apr 22, 2022
@github-actions github-actions bot added the service/grafana Issues and PRs that pertain to the grafana service. label Apr 22, 2022
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. tags Pertains to resource tagging. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 22, 2022
@DrFaust92
Copy link
Collaborator

@github-actions github-actions bot removed the tags Pertains to resource tagging. label Apr 22, 2022
@DrFaust92 DrFaust92 added the tags Pertains to resource tagging. label Apr 22, 2022
@github-actions github-actions bot added generators Relates to code generators. size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Apr 22, 2022
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Apr 22, 2022
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Apr 22, 2022
@github-actions github-actions bot removed the size/M Managed by automation to categorize the size of a PR. label Apr 22, 2022
@AndreKapraty AndreKapraty marked this pull request as draft April 24, 2022 09:50
@AndreKapraty AndreKapraty marked this pull request as ready for review April 24, 2022 13:31
@AndreKapraty AndreKapraty marked this pull request as draft April 24, 2022 17:57
@ewbankkit ewbankkit marked this pull request as ready for review April 27, 2022 18:50
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Apr 27, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccGrafana_serial/DataSource PKG=grafana
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/grafana/... -v -count 1 -parallel 20 -run='TestAccGrafana_serial/DataSource'  -timeout 180m
=== RUN   TestAccGrafana_serial
=== RUN   TestAccGrafana_serial/DataSource
=== RUN   TestAccGrafana_serial/DataSource/basic
--- PASS: TestAccGrafana_serial (151.71s)
    --- PASS: TestAccGrafana_serial/DataSource (151.71s)
        --- PASS: TestAccGrafana_serial/DataSource/basic (151.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/grafana	155.846s
% make testacc TESTS=TestAccGrafana_serial/Workspace PKG=grafana
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/grafana/... -v -count 1 -parallel 20 -run='TestAccGrafana_serial/Workspace'  -timeout 180m
=== RUN   TestAccGrafana_serial
=== RUN   TestAccGrafana_serial/Workspace
=== RUN   TestAccGrafana_serial/Workspace/disappears
=== RUN   TestAccGrafana_serial/Workspace/organization
    acctest.go:726: this AWS account must be the management account of an AWS Organization
=== RUN   TestAccGrafana_serial/Workspace/dataSources
=== RUN   TestAccGrafana_serial/Workspace/permissionType
=== RUN   TestAccGrafana_serial/Workspace/notificationDestinations
=== RUN   TestAccGrafana_serial/Workspace/tags        
=== RUN   TestAccGrafana_serial/Workspace/saml
=== RUN   TestAccGrafana_serial/Workspace/sso
    acctest.go:746: skipping tests: AccessDeniedException: User: arn:aws:sts::187416307283:assumed-role/terraform_team1_dev-developer/kewbank@hashicorp.com is not authorized to perform: sso:ListInstances
--- PASS: TestAccGrafana_serial (938.27s)
    --- PASS: TestAccGrafana_serial/Workspace (938.27s)
        --- PASS: TestAccGrafana_serial/Workspace/disappears (138.62s)
        --- SKIP: TestAccGrafana_serial/Workspace/organization (0.35s)
        --- PASS: TestAccGrafana_serial/Workspace/dataSources (149.07s)
        --- PASS: TestAccGrafana_serial/Workspace/permissionType (201.90s)
        --- PASS: TestAccGrafana_serial/Workspace/notificationDestinations (155.87s)
        --- PASS: TestAccGrafana_serial/Workspace/tags (163.90s)
        --- PASS: TestAccGrafana_serial/Workspace/saml (144.99s)
        --- SKIP: TestAccGrafana_serial/Workspace/sso (0.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/grafana	963.455s

@ewbankkit
Copy link
Contributor

@AndreKapraty Thanks for the contribution 🎉 👏.
In general everything was great.
I went ahead and made a few minor changes to get this ready for this week's release.

@AndreKapraty
Copy link
Contributor Author

Thank you @ewbankkit for finishing this PR :)

@ewbankkit ewbankkit merged commit 33c16c6 into hashicorp:main Apr 27, 2022
@github-actions github-actions bot added this to the v4.12.0 milestone Apr 27, 2022
@github-actions
Copy link

This functionality has been released in v4.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. generators Relates to code generators. service/grafana Issues and PRs that pertain to the grafana service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support to add tags
3 participants