Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/aws_networkmanager_core_policy_document #24368

Merged
merged 23 commits into from
May 17, 2022
Merged

d/aws_networkmanager_core_policy_document #24368

merged 23 commits into from
May 17, 2022

Conversation

drewmullen
Copy link
Collaborator

@drewmullen drewmullen commented Apr 22, 2022 •
edited by ewbankkit

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Partially Closes #23782

PR also includes a new guide: "Using Terraform awscc provider with aws provider"
TODO Open a new PR to update the link once the new guide has been published.

Output from acceptance testing:

$ make testacc TESTS=TestAccCoreNetworkPolicyDocumentDataSource_basic PKG=networkmanager
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 20 -run='TestAccCoreNetworkPolicyDocumentDataSource_basic'  -timeout 180m
=== RUN   TestAccCoreNetworkPolicyDocumentDataSource_basic
=== PAUSE TestAccCoreNetworkPolicyDocumentDataSource_basic
=== CONT  TestAccCoreNetworkPolicyDocumentDataSource_basic
--- PASS: TestAccCoreNetworkPolicyDocumentDataSource_basic (13.61s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager     18.615s

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/networkmanager Issues and PRs that pertain to the networkmanager service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Apr 22, 2022
maryelizbeth
maryelizbeth reviewed Apr 29, 2022
View reviewed changes
Copy link
Contributor

@maryelizbeth maryelizbeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions! Thanks for putting this together, @drewmullen!

website/docs/guides/using-aws-with-awscc-provider.md Outdated Show resolved Hide resolved
website/docs/guides/using-aws-with-awscc-provider.md Outdated Show resolved Hide resolved
website/docs/guides/using-aws-with-awscc-provider.md Show resolved Hide resolved
website/docs/guides/using-aws-with-awscc-provider.md Outdated Show resolved Hide resolved
website/docs/guides/using-aws-with-awscc-provider.md Outdated Show resolved Hide resolved
@drewmullen
Copy link
Collaborator Author

drewmullen commented May 2, 2022 •
edited

Guessing the markdownlint issue has to do with my stubbed <change-me>. Just need to know what URL the new guide will be at then i can update that URL...

-> For more information about building AWS Core Network policy documents with Terraform, see the [Using AWS & AWSCC Provider Together Guide](https://learn.hashicorp.com/terraform/aws/<changeme>).

@drewmullen drewmullen changed the title [WIP] Core network policy document d/aws_networkmanager_core_policy_document May 2, 2022
GlennChia
GlennChia reviewed May 3, 2022
View reviewed changes
website/docs/d/networkmanager_core_network_policy_document.html.markdown Outdated Show resolved Hide resolved
internal/service/networkmanager/core_network_policy_document_data_source_test.go Show resolved Hide resolved
website/docs/d/networkmanager_core_network_policy_document.html.markdown Outdated Show resolved Hide resolved
internal/service/networkmanager/core_network_policy_document_data_source.go Show resolved Hide resolved
internal/service/networkmanager/core_network_policy_document_data_source.go Show resolved Hide resolved
internal/service/networkmanager/core_network_policy_model.go Outdated Show resolved Hide resolved
website/docs/d/networkmanager_core_network_policy_document.html.markdown Outdated Show resolved Hide resolved
website/docs/d/networkmanager_core_network_policy_document.html.markdown Outdated Show resolved Hide resolved
@GlennChia
Copy link
Collaborator

Changes LGTM!

@ewbankkit ewbankkit added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels May 5, 2022
ewbankkit
ewbankkit approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccCoreNetworkPolicyDocumentDataSource_ PKG=networkmanager
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 20 -run='TestAccCoreNetworkPolicyDocumentDataSource_'  -timeout 180m
=== RUN   TestAccCoreNetworkPolicyDocumentDataSource_basic
=== PAUSE TestAccCoreNetworkPolicyDocumentDataSource_basic
=== CONT  TestAccCoreNetworkPolicyDocumentDataSource_basic
--- PASS: TestAccCoreNetworkPolicyDocumentDataSource_basic (16.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	23.805s

@ewbankkit

This comment was marked as outdated.

Sign in to view
@ewbankkit
Copy link
Contributor

ewbankkit commented May 12, 2022 •
edited

New CloudFormation Resource Schema definitions and generated Terraform resources/data sources: hashicorp/terraform-provider-awscc#497.

v0.21.0 of the Terraform AWS Cloud Control API Provider is available for download: https://registry.terraform.io/providers/hashicorp/awscc/latest.

@drewmullen drewmullen force-pushed the f-corenetworkpolicydocument branch from f10e2fb to c42adac Compare May 17, 2022 18:50
@drewmullen drewmullen force-pushed the f-corenetworkpolicydocument branch from c42adac to de31144 Compare May 17, 2022 19:48
@ewbankkit ewbankkit merged commit 2d251f4 into hashicorp:main May 17, 2022
@ewbankkit
Copy link
Contributor

@drewmullen Thanks for the contribution 🎉 👏.

@github-actions github-actions bot added this to the v4.15.0 milestone May 17, 2022
@ewbankkit ewbankkit mentioned this pull request May 18, 2022
Merged
@github-actions
Copy link

This functionality has been released in v4.15.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

This was referenced May 20, 2022
Closed
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maryelizbeth maryelizbeth maryelizbeth left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

@GlennChia GlennChia GlennChia left review comments

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/networkmanager Issues and PRs that pertain to the networkmanager service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.15.0
Development

Successfully merging this pull request may close these issues.

resource/aws_networkmanager_core_network
5 participants
@drewmullen @GlennChia @ewbankkit @maryelizbeth @justinretzolk