Add automatic recovery property to aws_launch_template and aws_instance

[Nnachevvv]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes : #24039

This PR introduces new property automatic_recovery_behavior to aws_launch_template and aws_instance. More details can be found in Recover your instance .

Output from acceptance testing:

 make testacc TESTS=TestAccEC2Instance_automaticRecoveryBehavior PKG=ec2   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2Instance_automaticRecoveryBehavior'  -timeout 180m
=== RUN   TestAccEC2Instance_automaticRecoveryBehavior
=== PAUSE TestAccEC2Instance_automaticRecoveryBehavior
=== CONT  TestAccEC2Instance_automaticRecoveryBehavior

--- PASS: TestAccEC2Instance_automaticRecoveryBehavior (149.20s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	153.234s


make testacc TESTS=TestAccEC2LaunchTemplate_data PKG=ec2       ==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2LaunchTemplate_data'  -timeout 180m
=== RUN   TestAccEC2LaunchTemplate_data
=== PAUSE TestAccEC2LaunchTemplate_data
=== CONT  TestAccEC2LaunchTemplate_data
--- PASS: TestAccEC2LaunchTemplate_data (44.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	48.727s


make testacc TESTS=TestAccEC2InstanceDataSource_automaticRecoveryBehavior PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2InstanceDataSource_automaticRecoveryBehavior'  -timeout 180m
=== RUN   TestAccEC2InstanceDataSource_automaticRecoveryBehavior
=== PAUSE TestAccEC2InstanceDataSource_automaticRecoveryBehavior
=== CONT  TestAccEC2InstanceDataSource_automaticRecoveryBehavior
--- PASS: TestAccEC2InstanceDataSource_automaticRecoveryBehavior (182.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	186.685s
...

[github-actions]

Welcome @Nnachevvv 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEC2Instance_basic\|TestAccEC2Instance_autoRecovery\|TestAccEC2LaunchTemplate_data\|TestAccEC2InstanceDataSource_autoRecovery\|TestAccEC2LaunchTemplateDataSource_name\|TestAccEC2LaunchTemplate_basic' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccEC2Instance_basic\|TestAccEC2Instance_autoRecovery\|TestAccEC2LaunchTemplate_data\|TestAccEC2InstanceDataSource_autoRecovery\|TestAccEC2LaunchTemplateDataSource_name\|TestAccEC2LaunchTemplate_basic -timeout 180m
=== RUN   TestAccEC2InstanceDataSource_autoRecovery
=== PAUSE TestAccEC2InstanceDataSource_autoRecovery
=== RUN   TestAccEC2Instance_basic
=== PAUSE TestAccEC2Instance_basic
=== RUN   TestAccEC2Instance_autoRecovery
=== PAUSE TestAccEC2Instance_autoRecovery
=== RUN   TestAccEC2LaunchTemplateDataSource_name
=== PAUSE TestAccEC2LaunchTemplateDataSource_name
=== RUN   TestAccEC2LaunchTemplate_basic
=== PAUSE TestAccEC2LaunchTemplate_basic
=== RUN   TestAccEC2LaunchTemplate_data
=== PAUSE TestAccEC2LaunchTemplate_data
=== CONT  TestAccEC2InstanceDataSource_autoRecovery
=== CONT  TestAccEC2LaunchTemplateDataSource_name
=== CONT  TestAccEC2Instance_autoRecovery
--- PASS: TestAccEC2LaunchTemplateDataSource_name (43.68s)
=== CONT  TestAccEC2LaunchTemplate_data
--- PASS: TestAccEC2LaunchTemplate_data (14.99s)
=== CONT  TestAccEC2Instance_basic
--- PASS: TestAccEC2Instance_basic (86.84s)
=== CONT  TestAccEC2LaunchTemplate_basic
--- PASS: TestAccEC2Instance_autoRecovery (155.51s)
--- PASS: TestAccEC2LaunchTemplate_basic (13.69s)
--- PASS: TestAccEC2InstanceDataSource_autoRecovery (178.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	182.308s

[ewbankkit]

@Nnachevvv Thanks for the contribution 🎉 👏.
To more closely match the underlying AWS API and future-proof ourselves for any future enhancements I made the new argument part of a new maintenance_options configuration block.

[JohnnyBoi888]

Appreciate involved for addressing this swiftly! 👏 🙇

[github-actions]

This functionality has been released in v4.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[sergei-ivanov]

I believe the two valid values are default and disabled. dedicated is a type of instance tenancy.

[JohnnyBoi888]

@ewbankkit pls see ^^, I think documentation probably needs a quick touch up? :)

[ewbankkit]

Relates #24462.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.