-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new Datasource to list cloudfront origin access identities #24023 #24382
Added new Datasource to list cloudfront origin access identities #24023 #24382
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @Aegon95 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
…filter' -> 'comments'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccCloudFrontOriginAccessIdentitiesDataSource_ PKG=cloudfront
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run='TestAccCloudFrontOriginAccessIdentitiesDataSource_' -timeout 180m
=== RUN TestAccCloudFrontOriginAccessIdentitiesDataSource_comments
=== PAUSE TestAccCloudFrontOriginAccessIdentitiesDataSource_comments
=== RUN TestAccCloudFrontOriginAccessIdentitiesDataSource_all
=== PAUSE TestAccCloudFrontOriginAccessIdentitiesDataSource_all
=== CONT TestAccCloudFrontOriginAccessIdentitiesDataSource_comments
=== CONT TestAccCloudFrontOriginAccessIdentitiesDataSource_all
--- PASS: TestAccCloudFrontOriginAccessIdentitiesDataSource_comments (19.05s)
--- PASS: TestAccCloudFrontOriginAccessIdentitiesDataSource_all (19.09s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront 25.680s
@Aegon95 Thanks for the contribution 🎉 👏.
|
This functionality has been released in v4.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #24023.
Sample output of the datasource:
iam new, please let me know, if changes are required
Output from acceptance testing: