r/mq_broker - make maint window updatable + sweeper changes #24385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/M
DrFaust92
added
enhancement
github-actions
bot
added
documentation
ewbankkit
approved these changes
Apr 25, 2022
There was a problem hiding this comment.
LGTM 🚀.
% make sweep SWEEPARGS=-sweep-run=aws_mq_broker SWEEP=us-west-2
# make sweep SWEEPARGS=-sweep-run=aws_example_thing
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-2 -sweep-run=aws_mq_broker -timeout 60m
2022/04/25 08:18:38 [DEBUG] Running Sweepers for region (us-west-2):
2022/04/25 08:18:38 [DEBUG] Running Sweeper (aws_mq_broker) in region (us-west-2)
2022/04/25 08:18:38 [INFO] Retrieved credentials from "EnvConfigCredentials"
2022/04/25 08:18:38 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/04/25 08:18:39 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/04/25 08:18:41 [DEBUG] Completed Sweeper (aws_mq_broker) in region (us-west-2) in 2.627689776s
2022/04/25 08:18:41 Completed Sweepers for region (us-west-2) in 2.627865921s
2022/04/25 08:18:41 Sweeper Tests for region (us-west-2) ran successfully:
- aws_mq_broker
ok github.com/hashicorp/terraform-provider-aws/internal/sweep 6.163s
% make testacc TESTARGS='-run=TestAccMQBroker_AllFields_customVPC\|TestAccMQBroker_basic' PKG=mq ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/mq/... -v -count 1 -parallel 2 -run=TestAccMQBroker_AllFields_customVPC\|TestAccMQBroker_basic -timeout 180m
=== RUN TestAccMQBroker_basic
=== PAUSE TestAccMQBroker_basic
=== RUN TestAccMQBroker_AllFields_customVPC
=== PAUSE TestAccMQBroker_AllFields_customVPC
=== CONT TestAccMQBroker_basic
=== CONT TestAccMQBroker_AllFields_customVPC
--- PASS: TestAccMQBroker_basic (960.22s)
--- PASS: TestAccMQBroker_AllFields_customVPC (1744.03s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/mq 1748.107s
|
@DrFaust92 Thanks for the contribution 🎉 👏. |
|
This functionality has been released in v4.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #20241
Closes #19067
Closes #18365
Output from acceptance testing: