-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new datasource for listing instance profiles for a role #24423
Added new datasource for listing instance profiles for a role #24423
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution 👍 Looks cool. I left a few ideas for improvement.
kamilturek I did all the changes mentioned, have a look and let me know if those are good for role_name validation i have reused validation function from role resource creation (role.go), not sure if thats okay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general 👍 Thanks! 🚀
Co-authored-by: Kamil Turek <kamil.turek@hotmail.com>
Co-authored-by: Kamil Turek <kamil.turek@hotmail.com>
Co-authored-by: Kamil Turek <kamil.turek@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccIAMInstanceProfilesDataSource_ PKG=iam
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMInstanceProfilesDataSource_' -timeout 180m
=== RUN TestAccIAMInstanceProfilesDataSource_basic
=== PAUSE TestAccIAMInstanceProfilesDataSource_basic
=== CONT TestAccIAMInstanceProfilesDataSource_basic
--- PASS: TestAccIAMInstanceProfilesDataSource_basic (18.27s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/iam 26.279s
@Aegon95 Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates OR Closes #23646
Sample Output for datasource:
![image](https://user-images.githubusercontent.com/42437992/165355865-e55ab806-b40b-4aeb-bb8c-86f78683d578.png)
Output from acceptance testing: