Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update aws_kms_key to indicate that HMAC_256 is now supported #24450

Merged
merged 2 commits into from
Apr 29, 2022
Merged

Update aws_kms_key to indicate that HMAC_256 is now supported #24450

merged 2 commits into from
Apr 29, 2022

Conversation

justinretzolk
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24392

Output from acceptance testing: N/a, docs

Information

With the bump to aws_sdk_go for 4.12.0, HMAC_256 is now supported for aws_kms_key.customer_master_key_spec. No code changes were necessary, so this PR aims to update the documentation and add a changelog entry.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/kms Issues and PRs that pertain to the kms service. size/XS Managed by automation to categorize the size of a PR. labels Apr 28, 2022
justinretzolk
justinretzolk commented Apr 28, 2022
View reviewed changes
website/docs/r/kms_key.html.markdown
@@ -27,7 +27,7 @@ The following arguments are supported:
* `key_usage` - (Optional) Specifies the intended use of the key. Valid values: `ENCRYPT_DECRYPT` or `SIGN_VERIFY`.
Defaults to `ENCRYPT_DECRYPT`.
* `customer_master_key_spec` - (Optional) Specifies whether the key contains a symmetric key or an asymmetric key pair and the encryption algorithms or signing algorithms that the key supports.
Valid values: `SYMMETRIC_DEFAULT`, `RSA_2048`, `RSA_3072`, `RSA_4096`, `ECC_NIST_P256`, `ECC_NIST_P384`, `ECC_NIST_P521`, or `ECC_SECG_P256K1`. Defaults to `SYMMETRIC_DEFAULT`. For help with choosing a key spec, see the [AWS KMS Developer Guide](https://docs.aws.amazon.com/kms/latest/developerguide/symm-asymm-choose.html).
Valid values: `SYMMETRIC_DEFAULT`, `RSA_2048`, `RSA_3072`, `RSA_4096`, `HMAC_256`, `ECC_NIST_P256`, `ECC_NIST_P384`, `ECC_NIST_P521`, or `ECC_SECG_P256K1`. Defaults to `SYMMETRIC_DEFAULT`. For help with choosing a key spec, see the [AWS KMS Developer Guide](https://docs.aws.amazon.com/kms/latest/developerguide/symm-asymm-choose.html).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered reordering these, but since they're already in reverse-alpha order, I figured I'd leave them alone.

ewbankkit
ewbankkit approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@justinretzolk justinretzolk merged commit 94b6784 into main Apr 29, 2022
@justinretzolk justinretzolk deleted the d-changelog-24392 branch April 29, 2022 15:33
@github-actions github-actions bot added this to the v4.13.0 milestone Apr 29, 2022
@ewbankkit ewbankkit modified the milestones: v4.13.0, v4.12.1 Apr 29, 2022
github-actions bot pushed a commit that referenced this pull request Apr 29, 2022
Update CHANGELOG.md for #24450
2126629
@github-actions
Copy link

This functionality has been released in v4.12.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/kms Issues and PRs that pertain to the kms service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.12.1
Development

Successfully merging this pull request may close these issues.

KMS HMAC Support
2 participants
@justinretzolk @ewbankkit