d/aws_route53_resolver_rules: add new name_regex filter argument

[Tailzip]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Add new name_regex filter argument for aws_route53_resolver_rules datasource. Given this isn't supported natively by AWS API, filtering is performed locally after retrieving results from the API.

Output from acceptance testing:

❯ make testacc TESTS=TestAccRoute53ResolverRulesDataSource PKG=route53resolver
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 20 -run='TestAccRoute53ResolverRulesDataSource'  -timeout 180m
=== RUN   TestAccRoute53ResolverRulesDataSource_basic
=== PAUSE TestAccRoute53ResolverRulesDataSource_basic
=== RUN   TestAccRoute53ResolverRulesDataSource_resolverEndpointID
=== PAUSE TestAccRoute53ResolverRulesDataSource_resolverEndpointID
=== RUN   TestAccRoute53ResolverRulesDataSource_nameRegex
=== PAUSE TestAccRoute53ResolverRulesDataSource_nameRegex
=== RUN   TestAccRoute53ResolverRulesDataSource_nonExistentNameRegex
=== PAUSE TestAccRoute53ResolverRulesDataSource_nonExistentNameRegex
=== CONT  TestAccRoute53ResolverRulesDataSource_basic
=== CONT  TestAccRoute53ResolverRulesDataSource_nameRegex
=== CONT  TestAccRoute53ResolverRulesDataSource_resolverEndpointID
=== CONT  TestAccRoute53ResolverRulesDataSource_nonExistentNameRegex
--- PASS: TestAccRoute53ResolverRulesDataSource_basic (6.72s)
--- PASS: TestAccRoute53ResolverRulesDataSource_nonExistentNameRegex (7.97s)
--- PASS: TestAccRoute53ResolverRulesDataSource_nameRegex (29.14s)
--- PASS: TestAccRoute53ResolverRulesDataSource_resolverEndpointID (205.15s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver    206.737s

...

[Tailzip]

Acceptance tests output after force-push:

❯ make testacc TESTS=TestAccRoute53ResolverRulesDataSource PKG=route53resolver
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 20 -run='TestAccRoute53ResolverRulesDataSource'  -timeout 180m
=== RUN   TestAccRoute53ResolverRulesDataSource_basic
=== PAUSE TestAccRoute53ResolverRulesDataSource_basic
=== RUN   TestAccRoute53ResolverRulesDataSource_resolverEndpointID
=== PAUSE TestAccRoute53ResolverRulesDataSource_resolverEndpointID
=== RUN   TestAccRoute53ResolverRulesDataSource_nameRegex
=== PAUSE TestAccRoute53ResolverRulesDataSource_nameRegex
=== RUN   TestAccRoute53ResolverRulesDataSource_nonExistentNameRegex
=== PAUSE TestAccRoute53ResolverRulesDataSource_nonExistentNameRegex
=== CONT  TestAccRoute53ResolverRulesDataSource_basic
=== CONT  TestAccRoute53ResolverRulesDataSource_nameRegex
=== CONT  TestAccRoute53ResolverRulesDataSource_nonExistentNameRegex
=== CONT  TestAccRoute53ResolverRulesDataSource_resolverEndpointID
--- PASS: TestAccRoute53ResolverRulesDataSource_basic (7.74s)
--- PASS: TestAccRoute53ResolverRulesDataSource_nonExistentNameRegex (8.23s)
--- PASS: TestAccRoute53ResolverRulesDataSource_nameRegex (29.64s)
--- PASS: TestAccRoute53ResolverRulesDataSource_resolverEndpointID (205.48s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver    207.060s

[drewmullen]

I believe you'd want to implement this feature as it behaves more natively with the api, by adding a filters block argument instead of individual arguments for each filter type. Here is an example of the implementation on another data source:

terraform-provider-aws/internal/service/ec2/ipam_pool_data_source.go

Line 20 in ca81d17

"filter": DataSourceFiltersSchema(),

[Tailzip]

I believe you'd want to implement this feature as it behaves more natively with the api, by adding a filters block argument instead of individual arguments for each filter type. Here is an example of the implementation on another data source.

Hi @drewmullen, which API are you referring to: provider's or Route53Resolver service's ? Name regex filtering isn't supported by Route53Resolver API.

[drewmullen]

I believe you'd want to implement this feature as it behaves more natively with the api, by adding a filters block argument instead of individual arguments for each filter type. Here is an example of the implementation on another data source.

Hi @drewmullen, which API are you referring to: provider's or Route53Resolver service's ? Name regex filtering isn't supported by Route53Resolver API.

Oh jeesh. Ha - sorry about that! I just saw filters was supported and assumed. Let me take a closer look next week

[gdavison]

Thanks for the PR, @Tailzip. It looks good, though I have a few suggestions for changes.

[Tailzip]

Thanks for the review @gdavison, I've implemented the requested changes 😄

New acceptance tests output:

❯ make testacc TESTS=TestAccRoute53ResolverRulesDataSource PKG=route53resolver
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 20 -run='TestAccRoute53ResolverRulesDataSource'  -timeout 180m
=== RUN   TestAccRoute53ResolverRulesDataSource_basic
=== PAUSE TestAccRoute53ResolverRulesDataSource_basic
=== RUN   TestAccRoute53ResolverRulesDataSource_resolverEndpointID
=== PAUSE TestAccRoute53ResolverRulesDataSource_resolverEndpointID
=== RUN   TestAccRoute53ResolverRulesDataSource_nameRegex
=== PAUSE TestAccRoute53ResolverRulesDataSource_nameRegex
=== RUN   TestAccRoute53ResolverRulesDataSource_nonExistentNameRegex
=== PAUSE TestAccRoute53ResolverRulesDataSource_nonExistentNameRegex
=== CONT  TestAccRoute53ResolverRulesDataSource_basic
=== CONT  TestAccRoute53ResolverRulesDataSource_nameRegex
=== CONT  TestAccRoute53ResolverRulesDataSource_resolverEndpointID
=== CONT  TestAccRoute53ResolverRulesDataSource_nonExistentNameRegex
--- PASS: TestAccRoute53ResolverRulesDataSource_nonExistentNameRegex (8.42s)
--- PASS: TestAccRoute53ResolverRulesDataSource_basic (8.44s)
--- PASS: TestAccRoute53ResolverRulesDataSource_nameRegex (30.37s)
--- PASS: TestAccRoute53ResolverRulesDataSource_resolverEndpointID (216.33s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver    217.901s

[gdavison]

Thanks, @Tailzip. Looks good! 🚀

--- PASS: TestAccRoute53ResolverRulesDataSource_basic (26.38s)
--- PASS: TestAccRoute53ResolverRulesDataSource_nonExistentNameRegex (26.69s)
--- PASS: TestAccRoute53ResolverRulesDataSource_nameRegex (49.83s)
--- PASS: TestAccRoute53ResolverRulesDataSource_resolverEndpointID (265.65s)

[github-actions]

This functionality has been released in v4.15.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.