Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enabled_metrics to aws_autoscaling_group data source #24691

Merged
merged 3 commits into from
May 9, 2022

Conversation

ed-brex
Copy link
Contributor

@ed-brex ed-brex commented May 7, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTS=TestAccAutoScalingGroupDataSource_ PKG=autoscaling

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 20 -run='TestAccAutoScalingGroupDataSource_'  -timeout 180m
=== RUN   TestAccAutoScalingGroupDataSource_basic
=== PAUSE TestAccAutoScalingGroupDataSource_basic
=== RUN   TestAccAutoScalingGroupDataSource_launchTemplate
=== PAUSE TestAccAutoScalingGroupDataSource_launchTemplate
=== CONT  TestAccAutoScalingGroupDataSource_basic
=== CONT  TestAccAutoScalingGroupDataSource_launchTemplate
--- PASS: TestAccAutoScalingGroupDataSource_basic (50.70s)
--- PASS: TestAccAutoScalingGroupDataSource_launchTemplate (51.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	52.232s

👋 This is my first contribution to this provider. These changes are largely cargo-culted from existing values.
Tried my best to follow the guidelines from Enhancement/Bugfix to a Resource & Basic Acceptance Tests.

More than happy to make any changes/fixes to make things up-to-snuff.

* Add enalbed_metrics to schema and read function
* Add checks to existing acc tests
* Add bullet line in docs
@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/autoscaling Issues and PRs that pertain to the autoscaling service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 7, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @ed-brex 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 7, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccAutoScalingGroupDataSource_ PKG=autoscaling ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2 -run='TestAccAutoScalingGroupDataSource_'  -timeout 180m
=== RUN   TestAccAutoScalingGroupDataSource_basic
=== PAUSE TestAccAutoScalingGroupDataSource_basic
=== RUN   TestAccAutoScalingGroupDataSource_launchTemplate
=== PAUSE TestAccAutoScalingGroupDataSource_launchTemplate
=== CONT  TestAccAutoScalingGroupDataSource_basic
=== CONT  TestAccAutoScalingGroupDataSource_launchTemplate
--- PASS: TestAccAutoScalingGroupDataSource_launchTemplate (60.37s)
--- PASS: TestAccAutoScalingGroupDataSource_basic (63.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	66.851s

@ewbankkit
Copy link
Contributor

@ed-brex Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 35fb608 into hashicorp:main May 9, 2022
@github-actions github-actions bot added this to the v4.14.0 milestone May 9, 2022
@github-actions
Copy link

This functionality has been released in v4.14.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants