Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: EMR Serverless support #24734

Closed
dacort opened this issue May 10, 2022 · 13 comments · Fixed by #25144
Closed

Feature Request: EMR Serverless support #24734

dacort opened this issue May 10, 2022 · 13 comments · Fixed by #25144
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource.
Milestone

Comments

@dacort
Copy link
Contributor

dacort commented May 10, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

EMR Serverless is a new serverless Spark/Hive platform currently in preview.

New or Affected Resource(s)

  • aws_emrserverless_application

Potential Terraform Configuration

resource "aws_emrserverless_application" "example" {
  name = "example-application"
  type = "SPARK"
  release_label = "emr-6.5.0-latest"
}

References

Happy to help build this. :)

@dacort dacort added the enhancement Requests to existing resources that expand the functionality or scope. label May 10, 2022
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label May 10, 2022
@DrFaust92 DrFaust92 added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels May 16, 2022
@bschaatsbergen
Copy link
Member

bschaatsbergen commented May 17, 2022

Hi @dacort,

Thanks for raising this. I'm not sure if it's a good idea to add a sign-up based preview feature to the provider as it's subject to change and not accessible for everyone.

How do we usually go about this? @justinretzolk

@dacort
Copy link
Contributor Author

dacort commented May 17, 2022

Hi @bschaatsbergen - completely agree, but wanted to be proactive and get the feature request filed.

My thought was to at least begin development/testing locally, and have a PR ready for when the feature is generally available.

@justinretzolk
Copy link
Member

Hey @dacort and @bschaatsbergen 👋 Thank you for taking the time to raise this! We've done public preview items before; typically we add a note in the docs warning that there's no guarantee of stability

I'm not familiar enough to know how popular this particular feature will wind up being, but thinking through it, it may be worth waiting until the feature is generally available, in case there's not enough community feedback to have this get prioritized before some sort of breaking change gets introduced. That said, this being a preview feature won't stop us from reviewing a PR if time/feedback from the community indicates we should 🙂

@dacort
Copy link
Contributor Author

dacort commented May 19, 2022

Thanks, @justinretzolk! That makes perfect sense. I agree we should wait until the feature is GA so that we can be confident the API won't change. I'll continue to work on it locally.

Thanks for the feedback, very much appreciated! 🙏

@ewbankkit
Copy link
Contributor

Now GA:

@dacort
Copy link
Contributor Author

dacort commented Jun 1, 2022

Indeed!

Looks like aws-sdk-go has already been bumped to v1.44.25, which has support for EMR Serverless. I've started doing a little development locally, but haven't added a service from scratch before so a little bit slow-going. 😁

@bschaatsbergen
Copy link
Member

Great @dacort, if I can give you a hand let me know. I'll keep an eye out on the PR 👍

@dacort
Copy link
Contributor Author

dacort commented Jun 2, 2022

Looks like @DrFaust92 was much faster than I! See #25144

@bryantbiggs
Copy link
Contributor

I don't know when @DrFaust92 sleeps - or I think he has crafty auto-generate-provider-code tool and he's not telling us 😅

@bschaatsbergen
Copy link
Member

bschaatsbergen commented Jun 2, 2022

Damn, he always beats us to it! Nevertheless, nice work @DrFaust92 😜

@DrFaust92
Copy link
Collaborator

Thanks all, was planning to look into it and missed this ticket.

@github-actions github-actions bot added this to the v4.18.0 milestone Jun 6, 2022
@github-actions
Copy link

This functionality has been released in v4.18.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants