add: new data source aws_lb_hosted_zone_id

[wellsiau-aws]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #7988

Output from acceptance testing:

$ make testacc PKG=elbv2 TESTS=TestAccLBHostedZoneIDDataSource_basic
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccLBHostedZoneIDDataSource_basic'  -timeout 180m
=== RUN   TestAccLBHostedZoneIDDataSource_basic
=== PAUSE TestAccLBHostedZoneIDDataSource_basic
=== CONT  TestAccLBHostedZoneIDDataSource_basic
--- PASS: TestAccLBHostedZoneIDDataSource_basic (17.18s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elbv2      36.388s
...

[wellsiau-aws]

Since network load balancer is supported on elbv2, I believe the right approach is to add new data source under elbv2: aws_lb_hosted_zone_id

[github-actions]

Welcome @wellsiau-aws 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[GlennChia]

Really great first PR! Welcome to the community!

[wellsiau-aws]

thanks for the feedback @GlennChia , see my response above

[AdamTylerLynch]

We would appreciate one final run of the AccTests with the output pasted here now that you have made changes.

Once you post that, I’ll mark this as ready for merge.

nice job!

[drewmullen]

to pass terrafmt you can run:

$ find ./internal/service/<service name> -type f -name '<your test file name>_test.go' \
    | sort -u \
    | xargs -I {} terrafmt fmt --fmtcompat {}

fill in where i have <>

[YoSuperG]

@justinretzolk ☝️

[wellsiau-aws]

Re-run textacc after the last commit

$ make testacc PKG=elbv2 TESTS=TestAccLBHostedZoneIDDataSource_basic
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccLBHostedZoneIDDataSource_basic'  -timeout 180m
=== RUN   TestAccLBHostedZoneIDDataSource_basic
=== PAUSE TestAccLBHostedZoneIDDataSource_basic
=== CONT  TestAccLBHostedZoneIDDataSource_basic
--- PASS: TestAccLBHostedZoneIDDataSource_basic (22.95s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elbv2      42.378s

[wellsiau-aws]

go generate failed because it can't find prefix for lb_hosted_zone_id

The available prefixes : [lb\. lb_listener lb_target_group]

What would the convention? should I add general prefix lb_?

[wellsiau-aws]

made minor fix for terrafmt and removing unused fmt.Errorf

[wellsiau-aws]

Test re-run

$ make testacc PKG=elb TESTS=TestAccELBHostedZoneIDDataSource_basic
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elb/... -v -count 1 -parallel 20 -run='TestAccELBHostedZoneIDDataSource_basic'  -timeout 180m
=== RUN   TestAccELBHostedZoneIDDataSource_basic
=== PAUSE TestAccELBHostedZoneIDDataSource_basic
=== CONT  TestAccELBHostedZoneIDDataSource_basic
--- PASS: TestAccELBHostedZoneIDDataSource_basic (10.75s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elb        32.939s

[AdamTylerLynch]

LGTM 🎉

[ewbankkit]

@wellsiau-aws Those prefixes are defined in names/names_data.csv.
Maybe @YakDriver can give some advice about what the long-term strategy should be for naming these ELBv2 resources/data sources?

[wellsiau-aws]

@YakDriver , for now I added new prefix in names/names_data.csv for lb_hosted (under DocPrefix)

[ewbankkit]

@wellsiau-aws Could you please also add a line about this new DS to https://github.com/hashicorp/terraform-provider-aws/blob/main/docs/contributing/contribution-checklists.md#new-region? Thanks.

[wellsiau-aws]

I had some issue with my local machine running make providerlint which I think attributed to my Go version go version go1.18.1 darwin/amd64

$ make lint
==> Checking source code with golangci-lint...
==> Checking source code with providerlint...
providerlint: internal error: package "fmt" without types was imported from "github.com/hashicorp/terraform-provider-aws/internal/service/iotevents"
make: *** [providerlint] Error 1

However, I believe I have addressed the linting issue. I will run test on separate machine shortly. Here is the latest test:

$ make testacc PKG=elb TESTS=TestAccELBHostedZoneIDDataSource_basic
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elb/... -v -count 1 -parallel 20 -run='TestAccELBHostedZoneIDDataSource_basic'  -timeout 180m
=== RUN   TestAccELBHostedZoneIDDataSource_basic
=== PAUSE TestAccELBHostedZoneIDDataSource_basic
=== CONT  TestAccELBHostedZoneIDDataSource_basic
--- PASS: TestAccELBHostedZoneIDDataSource_basic (10.89s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elb        13.574s

[ewbankkit]

% make providerlint
==> Checking source code with providerlint...

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLBHostedZoneIDDataSource_' PKG=elbv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20  -run=TestAccLBHostedZoneIDDataSource_ -timeout 180m
=== RUN   TestAccLBHostedZoneIDDataSource_basic
=== PAUSE TestAccLBHostedZoneIDDataSource_basic
=== CONT  TestAccLBHostedZoneIDDataSource_basic
--- PASS: TestAccLBHostedZoneIDDataSource_basic (46.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	53.995s

[ewbankkit]

@wellsiau-aws Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.15.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.