Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directory Service Directory Share #24766

Merged
merged 21 commits into from
Jul 2, 2022
Merged

Directory Service Directory Share #24766

merged 21 commits into from
Jul 2, 2022

Conversation

tmccombs
Copy link
Contributor

@tmccombs tmccombs commented May 13, 2022 •
edited by YakDriver

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #6003
Closes #6004
Closes #6005

I started working on this and made some progress but never finished writing tests (or actually testing it), or writing documentation, so it needs some work. I discovered that I don't actually need this, but would like to submit what I have in case someone else wants to finish it (or it is at least helpful in making a complete PR).

@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. service/ds Issues and PRs that pertain to the ds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. and removed needs-triage Waiting for first response or review from a maintainer. labels May 13, 2022
@YakDriver
Copy link
Member

@tmccombs Thanks for your work on this! It looks like good work, and I'm going to build on it. If you decide to make any changes to it, coordinate with me if you don't mind.

@YakDriver YakDriver changed the title Driectory service share Directory service share Jun 27, 2022
@YakDriver YakDriver self-assigned this Jun 27, 2022
tmccombs and others added 5 commits June 28, 2022 15:37
@tmccombs @YakDriver
Add directory service share resources
a6f826f 
Add aws_directory_service_share and aws_directory_service_share_accepter resources to
allow sharing a directory service directory across accounts.
@tmccombs @YakDriver
Initial attempt at acceptance tests
cde1c6a
@YakDriver
ds: Build on previous work
af00c93
@YakDriver
ds/dir_share: Fix issues
df14c19
@YakDriver
ds/directory_share: Fix resource, test
d6ee02a
@YakDriver YakDriver changed the title Directory service share Directory Service Directory Share Jun 29, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jun 29, 2022
@YakDriver YakDriver marked this pull request as ready for review July 1, 2022 20:55
@YakDriver YakDriver merged commit 3bc094e into hashicorp:main Jul 2, 2022
@github-actions github-actions bot added this to the v4.22.0 milestone Jul 2, 2022
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This functionality has been released in v4.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@tmccombs tmccombs deleted the driectory-service-share branch July 8, 2022 07:28
@ewbankkit ewbankkit mentioned this pull request Aug 5, 2022
Merged
@github-actions
Copy link

github-actions bot commented Aug 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@YakDriver YakDriver

Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ds Issues and PRs that pertain to the ds service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.22.0
2 participants
@tmccombs @YakDriver