Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_connect_user #24832

Merged
merged 24 commits into from
Jul 20, 2022
Merged

r/aws_connect_user #24832

merged 24 commits into from
Jul 20, 2022

Conversation

GlennChia
Copy link
Collaborator

@GlennChia GlennChia commented May 17, 2022 •
edited

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #21056

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccConnectUser_serial' PKG=connect ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 1  -run=TestAccConnectUser_serial -timeout 180m
=== RUN   TestAccConnectUser_serial
=== RUN   TestAccConnectUser_serial/update_hierarchy_group_id
=== RUN   TestAccConnectUser_serial/update_identity_info
=== RUN   TestAccConnectUser_serial/update_phone_config
=== RUN   TestAccConnectUser_serial/update_routing_profile_id
=== RUN   TestAccConnectUser_serial/update_security_profile_ids
=== RUN   TestAccConnectUser_serial/update_tags
=== RUN   TestAccConnectUser_serial/basic
=== RUN   TestAccConnectUser_serial/disappears
--- PASS: TestAccConnectUser_serial (1013.75s)
    --- PASS: TestAccConnectUser_serial/update_hierarchy_group_id (144.07s)
    --- PASS: TestAccConnectUser_serial/update_identity_info (120.72s)
    --- PASS: TestAccConnectUser_serial/update_phone_config (163.38s)
    --- PASS: TestAccConnectUser_serial/update_routing_profile_id (126.65s)
    --- PASS: TestAccConnectUser_serial/update_security_profile_ids (147.22s)
    --- PASS: TestAccConnectUser_serial/update_tags (140.98s)
    --- PASS: TestAccConnectUser_serial/basic (84.99s)
    --- PASS: TestAccConnectUser_serial/disappears (85.73s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    1013.799s

...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. needs-triage Waiting for first response or review from a maintainer. labels May 17, 2022
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 17, 2022
@keeganausan
Copy link

@GlennChia you keep beating me to these new resources :) I haven't had time to shore up the documentation and validation for a few more. Looks good

AdamTylerLynch
AdamTylerLynch approved these changes Jul 17, 2022
View reviewed changes
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Jul 20, 2022
ewbankkit
ewbankkit approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccConnectUser_serial' PKG=connect ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 1  -run=TestAccConnectUser_serial -timeout 180m
=== RUN   TestAccConnectUser_serial
=== RUN   TestAccConnectUser_serial/basic
=== RUN   TestAccConnectUser_serial/disappears
=== RUN   TestAccConnectUser_serial/update_hierarchy_group_id
=== RUN   TestAccConnectUser_serial/update_identity_info
=== RUN   TestAccConnectUser_serial/update_phone_config
=== RUN   TestAccConnectUser_serial/update_routing_profile_id
=== RUN   TestAccConnectUser_serial/update_security_profile_ids
=== RUN   TestAccConnectUser_serial/update_tags
--- PASS: TestAccConnectUser_serial (1022.32s)
    --- PASS: TestAccConnectUser_serial/basic (131.85s)
    --- PASS: TestAccConnectUser_serial/disappears (118.99s)
    --- PASS: TestAccConnectUser_serial/update_hierarchy_group_id (116.10s)
    --- PASS: TestAccConnectUser_serial/update_identity_info (128.80s)
    --- PASS: TestAccConnectUser_serial/update_phone_config (137.04s)
    --- PASS: TestAccConnectUser_serial/update_routing_profile_id (115.16s)
    --- PASS: TestAccConnectUser_serial/update_security_profile_ids (141.06s)
    --- PASS: TestAccConnectUser_serial/update_tags (133.32s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	1026.240s

@ewbankkit ewbankkit merged commit fd3f47e into hashicorp:main Jul 20, 2022
@github-actions github-actions bot added this to the v4.23.0 milestone Jul 20, 2022
@github-actions
Copy link

This functionality has been released in v4.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@GlennChia GlennChia deleted the f-aws_connect_user branch August 6, 2022 02:56
@github-actions
Copy link

github-actions bot commented Sep 6, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

@AdamTylerLynch AdamTylerLynch AdamTylerLynch approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.23.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@GlennChia @keeganausan @ewbankkit @AdamTylerLynch @justinretzolk