f/resource_aws_dms_endpoint: allow configuring secrets manager secret when engine is aurora, mariadb or mysql #24846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… MySQL secretId acc tests
github-actions
bot
added
size/XL
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome @bmcleodeq 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
justinretzolk
removed
the
needs-triage
|
Added secrets manager config support for |
bmcleodeq
changed the title
ewbankkit
reviewed
Jun 1, 2022
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccDMSEndpoint_' PKG=dms ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 3 -run=TestAccDMSEndpoint_ -timeout 180m
=== RUN TestAccDMSEndpoint_basic
=== PAUSE TestAccDMSEndpoint_basic
=== RUN TestAccDMSEndpoint_Aurora_basic
=== PAUSE TestAccDMSEndpoint_Aurora_basic
=== RUN TestAccDMSEndpoint_Aurora_secretID
=== PAUSE TestAccDMSEndpoint_Aurora_secretID
=== RUN TestAccDMSEndpoint_Aurora_update
=== PAUSE TestAccDMSEndpoint_Aurora_update
=== RUN TestAccDMSEndpoint_S3_basic
=== PAUSE TestAccDMSEndpoint_S3_basic
=== RUN TestAccDMSEndpoint_S3_extraConnectionAttributes
=== PAUSE TestAccDMSEndpoint_S3_extraConnectionAttributes
=== RUN TestAccDMSEndpoint_dynamoDB
=== PAUSE TestAccDMSEndpoint_dynamoDB
=== RUN TestAccDMSEndpoint_OpenSearch_basic
=== PAUSE TestAccDMSEndpoint_OpenSearch_basic
=== RUN TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes
=== PAUSE TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes
=== RUN TestAccDMSEndpoint_OpenSearch_errorRetryDuration
=== PAUSE TestAccDMSEndpoint_OpenSearch_errorRetryDuration
=== RUN TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage
=== PAUSE TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage
=== RUN TestAccDMSEndpoint_kafka
=== PAUSE TestAccDMSEndpoint_kafka
=== RUN TestAccDMSEndpoint_kinesis
=== PAUSE TestAccDMSEndpoint_kinesis
=== RUN TestAccDMSEndpoint_MongoDB_basic
=== PAUSE TestAccDMSEndpoint_MongoDB_basic
=== RUN TestAccDMSEndpoint_MongoDB_update
=== PAUSE TestAccDMSEndpoint_MongoDB_update
=== RUN TestAccDMSEndpoint_MariaDB_basic
=== PAUSE TestAccDMSEndpoint_MariaDB_basic
=== RUN TestAccDMSEndpoint_MariaDB_secretID
=== PAUSE TestAccDMSEndpoint_MariaDB_secretID
=== RUN TestAccDMSEndpoint_MariaDB_update
=== PAUSE TestAccDMSEndpoint_MariaDB_update
=== RUN TestAccDMSEndpoint_MySQL_basic
=== PAUSE TestAccDMSEndpoint_MySQL_basic
=== RUN TestAccDMSEndpoint_MySQL_secretID
=== PAUSE TestAccDMSEndpoint_MySQL_secretID
=== RUN TestAccDMSEndpoint_MySQL_update
=== PAUSE TestAccDMSEndpoint_MySQL_update
=== RUN TestAccDMSEndpoint_Oracle_basic
=== PAUSE TestAccDMSEndpoint_Oracle_basic
=== RUN TestAccDMSEndpoint_Oracle_secretID
=== PAUSE TestAccDMSEndpoint_Oracle_secretID
=== RUN TestAccDMSEndpoint_Oracle_update
=== PAUSE TestAccDMSEndpoint_Oracle_update
=== RUN TestAccDMSEndpoint_PostgreSQL_basic
=== PAUSE TestAccDMSEndpoint_PostgreSQL_basic
=== RUN TestAccDMSEndpoint_PostgreSQL_secretID
=== PAUSE TestAccDMSEndpoint_PostgreSQL_secretID
=== RUN TestAccDMSEndpoint_PostgreSQL_update
=== PAUSE TestAccDMSEndpoint_PostgreSQL_update
=== RUN TestAccDMSEndpoint_PostgreSQL_kmsKey
=== PAUSE TestAccDMSEndpoint_PostgreSQL_kmsKey
=== RUN TestAccDMSEndpoint_SQLServer_basic
=== PAUSE TestAccDMSEndpoint_SQLServer_basic
=== RUN TestAccDMSEndpoint_SQLServer_secretID
=== PAUSE TestAccDMSEndpoint_SQLServer_secretID
=== RUN TestAccDMSEndpoint_SQLServer_update
=== PAUSE TestAccDMSEndpoint_SQLServer_update
=== RUN TestAccDMSEndpoint_SQLServer_kmsKey
=== PAUSE TestAccDMSEndpoint_SQLServer_kmsKey
=== RUN TestAccDMSEndpoint_docDB
=== PAUSE TestAccDMSEndpoint_docDB
=== RUN TestAccDMSEndpoint_db2
=== PAUSE TestAccDMSEndpoint_db2
=== CONT TestAccDMSEndpoint_basic
=== CONT TestAccDMSEndpoint_MariaDB_update
=== CONT TestAccDMSEndpoint_PostgreSQL_update
--- PASS: TestAccDMSEndpoint_basic (66.99s)
=== CONT TestAccDMSEndpoint_Oracle_secretID
--- PASS: TestAccDMSEndpoint_PostgreSQL_update (67.36s)
=== CONT TestAccDMSEndpoint_PostgreSQL_secretID
--- PASS: TestAccDMSEndpoint_MariaDB_update (67.97s)
=== CONT TestAccDMSEndpoint_PostgreSQL_basic
--- PASS: TestAccDMSEndpoint_Oracle_secretID (44.08s)
=== CONT TestAccDMSEndpoint_Oracle_update
--- PASS: TestAccDMSEndpoint_PostgreSQL_secretID (43.79s)
=== CONT TestAccDMSEndpoint_MySQL_update
--- PASS: TestAccDMSEndpoint_PostgreSQL_basic (45.72s)
=== CONT TestAccDMSEndpoint_Oracle_basic
--- PASS: TestAccDMSEndpoint_Oracle_basic (42.38s)
=== CONT TestAccDMSEndpoint_OpenSearch_errorRetryDuration
--- PASS: TestAccDMSEndpoint_Oracle_update (53.96s)
=== CONT TestAccDMSEndpoint_MariaDB_secretID
--- PASS: TestAccDMSEndpoint_MySQL_update (53.94s)
=== CONT TestAccDMSEndpoint_MariaDB_basic
--- PASS: TestAccDMSEndpoint_MariaDB_basic (33.82s)
=== CONT TestAccDMSEndpoint_MongoDB_update
--- PASS: TestAccDMSEndpoint_OpenSearch_errorRetryDuration (53.17s)
=== CONT TestAccDMSEndpoint_MongoDB_basic
--- PASS: TestAccDMSEndpoint_MariaDB_secretID (46.20s)
=== CONT TestAccDMSEndpoint_kinesis
--- PASS: TestAccDMSEndpoint_MongoDB_update (51.45s)
=== CONT TestAccDMSEndpoint_SQLServer_update
--- PASS: TestAccDMSEndpoint_MongoDB_basic (41.87s)
=== CONT TestAccDMSEndpoint_db2
--- PASS: TestAccDMSEndpoint_db2 (51.35s)
=== CONT TestAccDMSEndpoint_docDB
--- PASS: TestAccDMSEndpoint_SQLServer_update (54.93s)
=== CONT TestAccDMSEndpoint_kafka
--- PASS: TestAccDMSEndpoint_kinesis (96.20s)
=== CONT TestAccDMSEndpoint_SQLServer_kmsKey
--- PASS: TestAccDMSEndpoint_SQLServer_kmsKey (28.08s)
=== CONT TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage
--- PASS: TestAccDMSEndpoint_docDB (54.32s)
=== CONT TestAccDMSEndpoint_S3_extraConnectionAttributes
--- PASS: TestAccDMSEndpoint_kafka (51.63s)
=== CONT TestAccDMSEndpoint_OpenSearch_basic
--- PASS: TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage (45.89s)
=== CONT TestAccDMSEndpoint_dynamoDB
--- PASS: TestAccDMSEndpoint_OpenSearch_basic (43.42s)
=== CONT TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes
--- PASS: TestAccDMSEndpoint_S3_extraConnectionAttributes (43.83s)
=== CONT TestAccDMSEndpoint_MySQL_secretID
--- PASS: TestAccDMSEndpoint_MySQL_secretID (32.66s)
=== CONT TestAccDMSEndpoint_MySQL_basic
--- PASS: TestAccDMSEndpoint_dynamoDB (64.66s)
=== CONT TestAccDMSEndpoint_S3_basic
--- PASS: TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes (47.51s)
=== CONT TestAccDMSEndpoint_Aurora_update
--- PASS: TestAccDMSEndpoint_MySQL_basic (33.51s)
=== CONT TestAccDMSEndpoint_Aurora_secretID
--- PASS: TestAccDMSEndpoint_Aurora_update (38.21s)
=== CONT TestAccDMSEndpoint_Aurora_basic
--- PASS: TestAccDMSEndpoint_Aurora_secretID (32.93s)
=== CONT TestAccDMSEndpoint_SQLServer_basic
--- PASS: TestAccDMSEndpoint_S3_basic (62.55s)
=== CONT TestAccDMSEndpoint_SQLServer_secretID
--- PASS: TestAccDMSEndpoint_Aurora_basic (34.54s)
=== CONT TestAccDMSEndpoint_PostgreSQL_kmsKey
--- PASS: TestAccDMSEndpoint_SQLServer_basic (34.19s)
--- PASS: TestAccDMSEndpoint_SQLServer_secretID (34.70s)
--- PASS: TestAccDMSEndpoint_PostgreSQL_kmsKey (36.56s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/dms 571.761s
ewbankkit
approved these changes
Jun 1, 2022
|
@bmcleodeq Thanks for the contribution 🎉 👏. |
% make providerlint golangci-lint
==> Checking source code with providerlint...
==> Checking source code with golangci-lint... |
This was referenced Jun 1, 2022
|
This functionality has been released in v4.17.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #24845
Output from acceptance testing: