Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing invalidDBInstanceState on proxy target registration #24875

Merged
merged 7 commits into from
May 24, 2022

Conversation

nikemeal
Copy link

@nikemeal nikemeal commented May 19, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

This PR is a direct clone of #19096 but updated to edit the new file in the new location. All credit to https://github.com/tatodorov for the original PR

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR. labels May 19, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @nikemeal 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels May 19, 2022
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels May 24, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSProxyTarget_' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSProxyTarget_ -timeout 180m
=== RUN   TestAccRDSProxyTarget_instance
=== PAUSE TestAccRDSProxyTarget_instance
=== RUN   TestAccRDSProxyTarget_cluster
=== PAUSE TestAccRDSProxyTarget_cluster
=== RUN   TestAccRDSProxyTarget_disappears
=== PAUSE TestAccRDSProxyTarget_disappears
=== CONT  TestAccRDSProxyTarget_instance
=== CONT  TestAccRDSProxyTarget_disappears
--- PASS: TestAccRDSProxyTarget_disappears (663.46s)
=== CONT  TestAccRDSProxyTarget_cluster
--- PASS: TestAccRDSProxyTarget_instance (669.64s)
--- PASS: TestAccRDSProxyTarget_cluster (751.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1418.958s

@ewbankkit
Copy link
Contributor

@nikemeal Thanks for the contribution 🎉 👏.

@ewbankkit
Copy link
Contributor

% make golangci-lint
==> Checking source code with golangci-lint...

@ewbankkit ewbankkit merged commit 6415379 into hashicorp:main May 24, 2022
@github-actions github-actions bot added this to the v4.16.0 milestone May 24, 2022
@github-actions
Copy link

This functionality has been released in v4.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants