-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amend r/aws_appflow_flow
validation for attribute task_properties
to avoid conflicting type assumption
#24889
Conversation
- resulted from improperly targeted terrafmt command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccAppFlowFlow_ PKG=appflow ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appflow/... -v -count 1 -parallel 2 -run='TestAccAppFlowFlow_' -timeout 180m
=== RUN TestAccAppFlowFlow_basic
=== PAUSE TestAccAppFlowFlow_basic
=== RUN TestAccAppFlowFlow_update
=== PAUSE TestAccAppFlowFlow_update
=== RUN TestAccAppFlowFlow_TaskProperties
=== PAUSE TestAccAppFlowFlow_TaskProperties
=== RUN TestAccAppFlowFlow_tags
=== PAUSE TestAccAppFlowFlow_tags
=== RUN TestAccAppFlowFlow_disappears
=== PAUSE TestAccAppFlowFlow_disappears
=== CONT TestAccAppFlowFlow_basic
=== CONT TestAccAppFlowFlow_tags
--- PASS: TestAccAppFlowFlow_basic (29.49s)
=== CONT TestAccAppFlowFlow_TaskProperties
--- PASS: TestAccAppFlowFlow_TaskProperties (25.94s)
=== CONT TestAccAppFlowFlow_update
--- PASS: TestAccAppFlowFlow_tags (70.45s)
=== CONT TestAccAppFlowFlow_disappears
--- PASS: TestAccAppFlowFlow_disappears (23.84s)
--- PASS: TestAccAppFlowFlow_update (45.15s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/appflow 106.874s
Does this require a CHANGELOG entry? |
Good catch! Should have a bug-fix changelog. Can add one when I'm back in on Thursday. |
This functionality has been released in v4.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #24888.
Output from acceptance testing:
Unfortunately, we don't have a
ValidateFunc
that allows us to check the keys and values of aTypeMap
object -- except for a simple regex check.