r/aws_cloudfront_response_headers_policy added server_timing_headers_config attribute

[daftkid]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24728

Output from acceptance testing:

$ make testacc TESTS=TestAccCloudFrontResponseHeadersPolicy_ServerTimingHeadersConfig PKG=cloudfront
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run='TestAccCloudFrontResponseHeadersPolicy_ServerTimingHeadersConfig'  -timeout 180m
=== RUN   TestAccCloudFrontResponseHeadersPolicy_ServerTimingHeadersConfig
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_ServerTimingHeadersConfig
=== CONT  TestAccCloudFrontResponseHeadersPolicy_ServerTimingHeadersConfig

--- PASS: TestAccCloudFrontResponseHeadersPolicy_ServerTimingHeadersConfig (90.06s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront 93.490s


$ make testacc TESTS=TestAccCloudFrontResponseHeadersPolicyDataSource_basic PKG=cloudfront
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run='TestAccCloudFrontResponseHeadersPolicyDataSource_basic'  -timeout 180m
=== RUN   TestAccCloudFrontResponseHeadersPolicyDataSource_basic
=== PAUSE TestAccCloudFrontResponseHeadersPolicyDataSource_basic
=== CONT  TestAccCloudFrontResponseHeadersPolicyDataSource_basic
--- PASS: TestAccCloudFrontResponseHeadersPolicyDataSource_basic (45.47s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront 48.886s


$ make testacc TESTS=TestAccCloudFrontResponseHeadersPolicy_ PKG=cloudfront
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run='TestAccCloudFrontResponseHeadersPolicy_'  -timeout 180m
=== RUN   TestAccCloudFrontResponseHeadersPolicy_CorsConfig
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_CorsConfig
=== RUN   TestAccCloudFrontResponseHeadersPolicy_CustomHeadersConfig
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_CustomHeadersConfig
=== RUN   TestAccCloudFrontResponseHeadersPolicy_SecurityHeadersConfig
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_SecurityHeadersConfig
=== RUN   TestAccCloudFrontResponseHeadersPolicy_ServerTimingHeadersConfig
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_ServerTimingHeadersConfig
=== RUN   TestAccCloudFrontResponseHeadersPolicy_disappears
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_disappears
=== CONT  TestAccCloudFrontResponseHeadersPolicy_CorsConfig
=== CONT  TestAccCloudFrontResponseHeadersPolicy_ServerTimingHeadersConfig
=== CONT  TestAccCloudFrontResponseHeadersPolicy_disappears
=== CONT  TestAccCloudFrontResponseHeadersPolicy_SecurityHeadersConfig
=== CONT  TestAccCloudFrontResponseHeadersPolicy_CustomHeadersConfig
--- PASS: TestAccCloudFrontResponseHeadersPolicy_disappears (58.12s)
--- PASS: TestAccCloudFrontResponseHeadersPolicy_CustomHeadersConfig (78.88s)
--- PASS: TestAccCloudFrontResponseHeadersPolicy_CorsConfig (116.83s)
--- PASS: TestAccCloudFrontResponseHeadersPolicy_SecurityHeadersConfig (116.83s)
--- PASS: TestAccCloudFrontResponseHeadersPolicy_ServerTimingHeadersConfig (116.93s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront 120.298s

[github-actions]

Welcome @daftkid 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCloudFrontResponseHeadersPolicy' PKG=cloudfront ACCTEST_PARALLELISM=2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 2  -run=TestAccCloudFrontResponseHeadersPolicy -timeout 180m
=== RUN   TestAccCloudFrontResponseHeadersPolicyDataSource_basic
=== PAUSE TestAccCloudFrontResponseHeadersPolicyDataSource_basic
=== RUN   TestAccCloudFrontResponseHeadersPolicy_CorsConfig
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_CorsConfig
=== RUN   TestAccCloudFrontResponseHeadersPolicy_CustomHeadersConfig
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_CustomHeadersConfig
=== RUN   TestAccCloudFrontResponseHeadersPolicy_SecurityHeadersConfig
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_SecurityHeadersConfig
=== RUN   TestAccCloudFrontResponseHeadersPolicy_ServerTimingHeadersConfig
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_ServerTimingHeadersConfig
=== RUN   TestAccCloudFrontResponseHeadersPolicy_disappears
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_disappears
=== CONT  TestAccCloudFrontResponseHeadersPolicyDataSource_basic
=== CONT  TestAccCloudFrontResponseHeadersPolicy_SecurityHeadersConfig
--- PASS: TestAccCloudFrontResponseHeadersPolicyDataSource_basic (17.78s)
=== CONT  TestAccCloudFrontResponseHeadersPolicy_disappears
--- PASS: TestAccCloudFrontResponseHeadersPolicy_disappears (16.45s)
=== CONT  TestAccCloudFrontResponseHeadersPolicy_ServerTimingHeadersConfig
--- PASS: TestAccCloudFrontResponseHeadersPolicy_SecurityHeadersConfig (34.56s)
=== CONT  TestAccCloudFrontResponseHeadersPolicy_CustomHeadersConfig
--- PASS: TestAccCloudFrontResponseHeadersPolicy_CustomHeadersConfig (22.10s)
=== CONT  TestAccCloudFrontResponseHeadersPolicy_CorsConfig
--- PASS: TestAccCloudFrontResponseHeadersPolicy_ServerTimingHeadersConfig (55.38s)
--- PASS: TestAccCloudFrontResponseHeadersPolicy_CorsConfig (38.99s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	99.729s

[ewbankkit]

@daftkid @nialdaly Thanks for the contribution 🎉 👏.

[ewbankkit]

% make providerlint && make golangci-lint
==> Checking source code with providerlint...
==> Checking source code with golangci-lint...

[github-actions]

This functionality has been released in v4.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.