Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CodeBuild with VPC #2495

Closed
adventureisyou opened this issue Nov 30, 2017 · 4 comments
Closed

Add support for CodeBuild with VPC #2495

adventureisyou opened this issue Nov 30, 2017 · 4 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service.
Milestone

Comments

@adventureisyou
Copy link

adventureisyou commented Nov 30, 2017

Amazon announced support for running CodeBuild builds within a VPC last week.

Affected Resource(s)

  • aws_codebuild_project

Expected Behavior

Create & update of projects should optionally allow the specification of VPC, subnets & security groups, likely within a new optional block to match the Create and Update APIs. Read will also need additions for these properties.

  • If VPC is supplied, subnets must also be supplied.
  • If subnets is supplied, VPC must also be supplied.
  • If security_groups is supplied, both VPC and subnets must be supplied.
resource "aws_codebuild_project" "foo" {
  name = "test-project"

  artifacts {
    type = "NO_ARTIFACTS"
  }

  environment {
    compute_type = "BUILD_GENERAL1_SMALL"
    image        = "2"
    type         = "LINUX_CONTAINER"
  }

  source {
    type     = "GITHUB"
    location = "https://github.com/mitchellh/packer.git"
  }

  vpc_config {
    vpc_id = "vpc-725fca"

    subnets = [
       "subnet-ba35d2e0",
       "subnet-ab129af1",
    ]

    security_group_ids = [
       "sg-f9f27d91",
       "sg-e4f48g23",
    ]
  }
}

References

Blog post
Documentation

@randomcamel randomcamel added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 30, 2017
@kilsbo
Copy link

kilsbo commented Jan 19, 2018

I'm really looking for this as well. Only way (AWS is talking about) to access RDS instances from your continuous deployment.

@bflad bflad added the service/codebuild Issues and PRs that pertain to the codebuild service. label Jan 27, 2018
@bflad bflad added this to the v1.10.0 milestone Feb 22, 2018
@bflad
Copy link
Contributor

bflad commented Feb 22, 2018

This functionality has been merged into master via #2547 and #3324. It will be released in v1.10.0 of the AWS provider, likely tomorrow. 🎉

@bflad bflad closed this as completed Feb 22, 2018
@bflad
Copy link
Contributor

bflad commented Feb 27, 2018

This has been released in version 1.10.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants