Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/aws_location_place_index - new data source #24980

Merged
merged 4 commits into from
May 25, 2022
Merged

d/aws_location_place_index - new data source #24980

merged 4 commits into from
May 25, 2022

Conversation

kamilturek
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #19629.

Output from acceptance testing:

$ make testacc PKG=location TESTS="TestAccLocationPlaceIndexDataSource_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/location/... -v -count 1 -parallel 20 -run='TestAccLocationPlaceIndexDataSource_'  -timeout 180m
=== RUN   TestAccLocationPlaceIndexDataSource_indexName
=== PAUSE TestAccLocationPlaceIndexDataSource_indexName
=== CONT  TestAccLocationPlaceIndexDataSource_indexName
--- PASS: TestAccLocationPlaceIndexDataSource_indexName (25.05s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/location   26.919s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/location Issues and PRs that pertain to the location service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. labels May 24, 2022
@kamilturek kamilturek marked this pull request as ready for review May 24, 2022 20:53
@ewbankkit ewbankkit added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels May 25, 2022
ewbankkit
ewbankkit approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLocationPlaceIndexDataSource_' PKG=location ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/location/... -v -count 1 -parallel 2  -run=TestAccLocationPlaceIndexDataSource_ -timeout 180m
=== RUN   TestAccLocationPlaceIndexDataSource_indexName
=== PAUSE TestAccLocationPlaceIndexDataSource_indexName
=== CONT  TestAccLocationPlaceIndexDataSource_indexName
--- PASS: TestAccLocationPlaceIndexDataSource_indexName (20.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/location	23.873s

@ewbankkit
Copy link
Contributor

@kamilturek Thanks for the contribution 🎉 👏.

@ewbankkit
Copy link
Contributor 

% make providerlint && make golangci-lint      
==> Checking source code with providerlint...
==> Checking source code with golangci-lint...

@ewbankkit ewbankkit merged commit cbfaa24 into hashicorp:main May 25, 2022
@github-actions github-actions bot added this to the v4.16.0 milestone May 25, 2022
@github-actions
Copy link

This functionality has been released in v4.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@kamilturek kamilturek deleted the f-data-aws-location-place-index branch June 18, 2022 15:12
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/location Issues and PRs that pertain to the location service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.16.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kamilturek @ewbankkit