r/aws_pinpointsmsvoicev2_phone_number - new resource #25036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
client-connections
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome @JamesMarino 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
justinretzolk
added
new-resource
ewbankkit
added
the
service/pinpointsmsvoice
|
Any news on whether we can get this merged in or if there was any feedback? Happy to fix up the conflicts. |
|
@jar-b can you please assign this for review? I would like to send PRs to close other missing resources on pinpoint. Thanks |
|
Is someone going to pick this back up? I've currently implemented a solution using null_resources and external data resources; however, bringing this back to a standard terraform provider would be fantastic :) |
github-actions
bot
added
the
prioritized
|
@dabmajor This in on the maintainers' roadmap for this quarter. |
# Conflicts: # .github/labeler-issue-triage.yml # .github/labeler-pr-triage.yml # infrastructure/repository/labels-service.tf # internal/conns/awsclient_gen.go # internal/conns/config_gen.go # internal/provider/provider.go # names/consts_gen.go # names/names_data.csv # website/allowed-subcategories.txt # website/docs/guides/custom-service-endpoints.html.markdown
ewbankkit
requested review from
breathingdust,
justinretzolk and
a team
as code owners
|
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
% make testacc TESTARGS='-run=TestAccPinpointSMSVoiceV2OptOutList_' PKG=pinpointsmsvoicev2 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.6 test ./internal/service/pinpointsmsvoicev2/... -v -count 1 -parallel 20 -run=TestAccPinpointSMSVoiceV2OptOutList_ -timeout 360m === RUN TestAccPinpointSMSVoiceV2OptOutList_basic === PAUSE TestAccPinpointSMSVoiceV2OptOutList_basic === RUN TestAccPinpointSMSVoiceV2OptOutList_disappears === PAUSE TestAccPinpointSMSVoiceV2OptOutList_disappears === RUN TestAccPinpointSMSVoiceV2OptOutList_tags === PAUSE TestAccPinpointSMSVoiceV2OptOutList_tags === CONT TestAccPinpointSMSVoiceV2OptOutList_basic === CONT TestAccPinpointSMSVoiceV2OptOutList_tags === CONT TestAccPinpointSMSVoiceV2OptOutList_disappears --- PASS: TestAccPinpointSMSVoiceV2OptOutList_disappears (13.50s) --- PASS: TestAccPinpointSMSVoiceV2OptOutList_basic (15.71s) --- PASS: TestAccPinpointSMSVoiceV2OptOutList_tags (33.37s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/pinpointsmsvoicev2 38.259s
… acceptance tests.
% make testacc TESTARGS='-run=TestAccPinpointSMSVoiceV2PhoneNumber_' PKG=pinpointsmsvoicev2 ACCTEST_PARALLELISM=2 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.6 test ./internal/service/pinpointsmsvoicev2/... -v -count 1 -parallel 2 -run=TestAccPinpointSMSVoiceV2PhoneNumber_ -timeout 360m === RUN TestAccPinpointSMSVoiceV2PhoneNumber_basic === PAUSE TestAccPinpointSMSVoiceV2PhoneNumber_basic === RUN TestAccPinpointSMSVoiceV2PhoneNumber_full === PAUSE TestAccPinpointSMSVoiceV2PhoneNumber_full === RUN TestAccPinpointSMSVoiceV2PhoneNumber_disappears === PAUSE TestAccPinpointSMSVoiceV2PhoneNumber_disappears === RUN TestAccPinpointSMSVoiceV2PhoneNumber_tags === PAUSE TestAccPinpointSMSVoiceV2PhoneNumber_tags === CONT TestAccPinpointSMSVoiceV2PhoneNumber_basic === CONT TestAccPinpointSMSVoiceV2PhoneNumber_disappears --- PASS: TestAccPinpointSMSVoiceV2PhoneNumber_basic (19.22s) === CONT TestAccPinpointSMSVoiceV2PhoneNumber_full --- PASS: TestAccPinpointSMSVoiceV2PhoneNumber_disappears (25.43s) === CONT TestAccPinpointSMSVoiceV2PhoneNumber_tags --- PASS: TestAccPinpointSMSVoiceV2PhoneNumber_full (33.86s) --- PASS: TestAccPinpointSMSVoiceV2PhoneNumber_tags (36.83s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/pinpointsmsvoicev2 67.075s
…in documentation.
ewbankkit
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccPinpointSMSVoiceV2OptOutList_' PKG=pinpointsmsvoicev2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/pinpointsmsvoicev2/... -v -count 1 -parallel 20 -run=TestAccPinpointSMSVoiceV2OptOutList_ -timeout 360m
=== RUN TestAccPinpointSMSVoiceV2OptOutList_basic
=== PAUSE TestAccPinpointSMSVoiceV2OptOutList_basic
=== RUN TestAccPinpointSMSVoiceV2OptOutList_disappears
=== PAUSE TestAccPinpointSMSVoiceV2OptOutList_disappears
=== RUN TestAccPinpointSMSVoiceV2OptOutList_tags
=== PAUSE TestAccPinpointSMSVoiceV2OptOutList_tags
=== CONT TestAccPinpointSMSVoiceV2OptOutList_basic
=== CONT TestAccPinpointSMSVoiceV2OptOutList_tags
=== CONT TestAccPinpointSMSVoiceV2OptOutList_disappears
--- PASS: TestAccPinpointSMSVoiceV2OptOutList_disappears (11.53s)
--- PASS: TestAccPinpointSMSVoiceV2OptOutList_basic (14.10s)
--- PASS: TestAccPinpointSMSVoiceV2OptOutList_tags (30.27s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/pinpointsmsvoicev2 35.355s% make testacc TESTARGS='-run=TestAccPinpointSMSVoiceV2PhoneNumber_' PKG=pinpointsmsvoicev2 ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/pinpointsmsvoicev2/... -v -count 1 -parallel 2 -run=TestAccPinpointSMSVoiceV2PhoneNumber_ -timeout 360m
=== RUN TestAccPinpointSMSVoiceV2PhoneNumber_basic
=== PAUSE TestAccPinpointSMSVoiceV2PhoneNumber_basic
=== RUN TestAccPinpointSMSVoiceV2PhoneNumber_full
=== PAUSE TestAccPinpointSMSVoiceV2PhoneNumber_full
=== RUN TestAccPinpointSMSVoiceV2PhoneNumber_disappears
=== PAUSE TestAccPinpointSMSVoiceV2PhoneNumber_disappears
=== RUN TestAccPinpointSMSVoiceV2PhoneNumber_tags
=== PAUSE TestAccPinpointSMSVoiceV2PhoneNumber_tags
=== CONT TestAccPinpointSMSVoiceV2PhoneNumber_basic
=== CONT TestAccPinpointSMSVoiceV2PhoneNumber_disappears
--- PASS: TestAccPinpointSMSVoiceV2PhoneNumber_basic (17.39s)
=== CONT TestAccPinpointSMSVoiceV2PhoneNumber_tags
--- PASS: TestAccPinpointSMSVoiceV2PhoneNumber_disappears (21.77s)
=== CONT TestAccPinpointSMSVoiceV2PhoneNumber_full
--- PASS: TestAccPinpointSMSVoiceV2PhoneNumber_full (29.72s)
--- PASS: TestAccPinpointSMSVoiceV2PhoneNumber_tags (36.11s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/pinpointsmsvoicev2 58.481s
github-actions
bot
removed
the
prioritized
|
This functionality has been released in v5.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new AWS service
pinpointsmsvoicev2and new resourcesaws_pinpointsmsvoicev2_phone_numberandaws_pinpointsmsvoicev2_opt_out_list.Note:
aws_pinpointsmsvoicev2_opt_out_listwas added as it is a dependant ofaws_pinpointsmsvoicev2_phone_numberin its tests.Community Note
Closes #24855
Output from acceptance testing: