Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_elasticache_global_replication_group: Support upgrading version #25077

Merged
merged 14 commits into from
May 27, 2022
Merged

resource/aws_elasticache_global_replication_group: Support upgrading version #25077

merged 14 commits into from
May 27, 2022

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented May 26, 2022 •
edited

Adds support for upgrading the engine_version for an aws_elasticache_global_replication_group

Relates #17696

Output from acceptance testing:

$ make testacc PKG=elasticache TESTS='TestAccElastiCacheCluster|TestAccElastiCacheGlobalReplicationGroup|TestAccElastiCacheReplicationGroup'

--- PASS: TestAccElastiCacheReplicationGroup_Validation_noNodeType (53.01s)
--- PASS: TestAccElastiCacheClusterDataSource_Data_basic (540.79s)
--- PASS: TestAccElastiCacheReplicationGroup_dataTiering (771.60s)
--- PASS: TestAccElastiCacheReplicationGroupDataSource_multiAZ (809.35s)
--- PASS: TestAccElastiCacheReplicationGroup_tags (952.12s)
--- PASS: TestAccElastiCacheReplicationGroup_Validation_globalReplicationGroupIdAndNodeType (1109.12s)
--- PASS: TestAccElastiCacheReplicationGroup_tagWithOtherModification (1162.58s)
--- PASS: TestAccElastiCacheReplicationGroup_autoMinorVersionUpgrade (1220.25s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterModeValidation_numNodeGroupsOnSecondary (1313.54s)
--- PASS: TestAccElastiCacheReplicationGroup_clusteringAndCacheNodesCausesError (2.14s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappears_noChange (1421.12s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappearsRemoveMemberCluster_atTargetSize (1445.83s)
--- PASS: TestAccElastiCacheReplicationGroup_Engine_Redis_LogDeliveryConfigurations_ClusterMode_Disabled (1535.10s)
--- PASS: TestAccElastiCacheReplicationGroup_finalSnapshot (1571.36s)
--- PASS: TestAccElastiCacheReplicationGroup_useCMKKMSKeyID (713.24s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappearsRemoveMemberCluster_scaleDown (1808.26s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClusters_multiAZEnabled (1798.28s)
--- PASS: TestAccElastiCacheReplicationGroup_Engine_Redis_LogDeliveryConfigurations_ClusterMode_Enabled (1860.50s)
--- PASS: TestAccElastiCacheReplicationGroup_ValidationMultiAz_noAutomaticFailover (2.76s)
--- PASS: TestAccElastiCacheReplicationGroup_deprecatedAvailabilityZones_multiAzInVPC (853.88s)
--- PASS: TestAccElastiCacheReplicationGroup_enableAtRestEncryption (907.07s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappears_addMemberCluster (2076.22s)
--- PASS: TestAccElastiCacheReplicationGroup_enableAuthTokenTransitEncryption (917.51s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersFailover_autoFailoverEnabled (1576.84s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_singleNode (822.31s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersFailover_autoFailoverDisabled (1433.17s)
--- PASS: TestAccElastiCacheReplicationGroup_enableSnapshotting (1020.93s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClusters_basic (1784.53s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_disappears (2792.73s)
--- PASS: TestAccElastiCacheReplicationGroup_depecatedAvailabilityZones_vpc (795.88s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_nonClusteredParameterGroup (1164.78s)
--- PASS: TestAccElastiCacheReplicationGroup_multiAzInVPC (1190.58s)
--- PASS: TestAccElastiCacheReplicationGroup_vpc (1066.62s)
--- PASS: TestAccElastiCacheReplicationGroup_updateParameterGroup (983.64s)
--- PASS: TestAccElastiCacheReplicationGroup_updateAuthToken (1177.72s)
--- PASS: TestAccElastiCacheReplicationGroup_multiAzNotInVPC_repeated (1326.12s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_updateReplicasPerNodeGroup (1908.20s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_basic (1633.82s)
--- PASS: TestAccElastiCacheReplicationGroupDataSource_nonExistent (3.16s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_basic (3539.52s)
--- PASS: TestAccElastiCacheReplicationGroup_multiAzNotInVPC (1507.77s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_full (3696.95s)
--- PASS: TestAccElastiCacheReplicationGroup_disappears (686.75s)
--- PASS: TestAccElastiCacheReplicationGroup_updateMaintenanceWindow (840.43s)
--- PASS: TestAccElastiCacheReplicationGroup_updateDescription (839.29s)
--- PASS: TestAccElastiCacheReplicationGroup_updateUserGroups (1055.84s)
--- PASS: TestAccElastiCacheReplicationGroup_deprecatedAvailabilityZones_multiAzNotInVPC (1841.99s)
--- PASS: TestAccElastiCacheReplicationGroup_uppercase (713.08s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleUp (2306.67s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterMode_basic (4008.96s)
--- PASS: TestAccElastiCacheReplicationGroup_basic_v5 (699.65s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnCreate_NoVersion (2.75s)
--- PASS: TestAccElastiCacheReplicationGroup_basic (698.71s)
--- PASS: TestAccElastiCacheReplicationGroupDataSource_Engine_Redis_LogDeliveryConfigurations (748.86s)
--- PASS: TestAccElastiCacheReplicationGroup_updateNodeSize (1605.81s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleDown (2643.41s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleUp (2811.50s)
--- PASS: TestAccElastiCacheReplicationGroupDataSource_basic (800.22s)
--- PASS: TestAccElastiCacheReplicationGroupDataSource_clusterMode (920.82s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleDown (3067.58s)
--- PASS: TestAccElastiCacheCluster_Engine_Redis_LogDeliveryConfigurations (1092.96s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnUpdate_MinorUpgrade (955.33s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnUpdate_NoVersion (986.34s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorDowngrade (1091.30s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_UpdateParameterGroupName (1267.11s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnCreate_MinorUpgrade (978.38s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorUpgrade_6x (1070.76s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorUpgrade_6x (1014.12s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MajorUpgrade (1429.59s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MajorUpgrade_6x (1607.22s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorUpgrade (1549.79s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_v5 (1265.41s)
--- PASS: TestAccElastiCacheCluster_tags (515.24s)
--- PASS: TestAccElastiCacheCluster_Memcached_finalSnapshot (2.79s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorUpgrade (1325.81s)
--- PASS: TestAccElastiCacheCluster_NumCacheNodes_redis (2.49s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_v6x (1175.01s)
--- PASS: TestAccElastiCacheCluster_tagWithOtherModification (606.32s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MajorUpgrade (1488.41s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorDowngrade (1595.89s)
--- PASS: TestAccElastiCacheCluster_multiAZInVPC (498.64s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_clusterMode (1266.06s)
--- PASS: TestAccElastiCacheCluster_Redis_autoMinorVersionUpgrade (504.22s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_disappears (1131.72s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_basic (984.45s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MajorUpgrade_6x (1903.21s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_description (1103.88s)
--- PASS: TestAccElastiCacheCluster_Redis_finalSnapshot (736.22s)
--- SKIP: TestAccElastiCacheCluster_SecurityGroup_ec2Classic (0.74s)
--- PASS: TestAccElastiCacheCluster_AZMode_redis (476.05s)
--- PASS: TestAccElastiCacheCluster_AZMode_memcached (486.10s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_v6 (1755.26s)
--- PASS: TestAccElastiCacheCluster_Engine_None (1.96s)
--- PASS: TestAccElastiCacheCluster_port (485.10s)
--- PASS: TestAccElastiCacheCluster_vpc (499.24s)
--- PASS: TestAccElastiCacheCluster_snapshotsWithUpdates (513.54s)
--- PASS: TestAccElastiCacheCluster_NodeTypeResize_memcached (1006.87s)
--- PASS: TestAccElastiCacheCluster_NumCacheNodes_increaseWithPreferredAvailabilityZones (754.76s)
--- PASS: TestAccElastiCacheCluster_Engine_redis_v5 (476.40s)
--- PASS: TestAccElastiCacheCluster_ParameterGroupName_default (476.64s)
--- PASS: TestAccElastiCacheCluster_PortRedis_default (476.51s)
--- PASS: TestAccElastiCacheCluster_NodeTypeResize_redis (1146.18s)
--- PASS: TestAccElastiCacheCluster_Engine_memcached (475.25s)
--- PASS: TestAccElastiCacheCluster_ReplicationGroupID_multipleReplica (1175.50s)
--- PASS: TestAccElastiCacheCluster_ReplicationGroupID_singleReplica (1194.76s)
--- PASS: TestAccElastiCacheCluster_ReplicationGroupID_availabilityZone (1194.64s)
--- PASS: TestAccElastiCacheCluster_Engine_redis (496.04s)
--- PASS: TestAccElastiCacheCluster_EngineVersion_memcached (1096.66s)
--- PASS: TestAccElastiCacheCluster_NumCacheNodes_increase (865.02s)
--- PASS: TestAccElastiCacheCluster_NumCacheNodes_decrease (845.13s)
--- PASS: TestAccElastiCacheClusterDataSource_Engine_Redis_LogDeliveryConfigurations (735.68s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_ReplaceSecondary_differentRegion (3311.65s)
--- PASS: TestAccElastiCacheCluster_EngineVersion_redis (2446.12s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_multipleSecondaries (3537.11s)
--- PASS: TestAccElastiCacheReplicationGroup_EngineVersion_update (5199.80s)

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 26, 2022
@gdavison gdavison mentioned this pull request May 26, 2022
Closed
3 tasks
@gdavison gdavison force-pushed the elasticache-global-rep-update branch from 27f3462 to edc5536 Compare May 26, 2022 22:13
@gdavison gdavison marked this pull request as ready for review May 27, 2022 01:35
ewbankkit
ewbankkit approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% go test -v -run=TestCustomizeDiffEngineVersionIsDowngrade ./internal/service/elasticache
=== RUN   TestCustomizeDiffEngineVersionIsDowngrade
=== RUN   TestCustomizeDiffEngineVersionIsDowngrade/upgrade_major_versions
=== RUN   TestCustomizeDiffEngineVersionIsDowngrade/downgrade_minor_versions
=== RUN   TestCustomizeDiffEngineVersionIsDowngrade/downgrade_major_versions
=== RUN   TestCustomizeDiffEngineVersionIsDowngrade/downgrade_major_6.digit
=== RUN   TestCustomizeDiffEngineVersionIsDowngrade/downgrade_from_major_7.digit_to_6.x
=== RUN   TestCustomizeDiffEngineVersionIsDowngrade/no_change
=== RUN   TestCustomizeDiffEngineVersionIsDowngrade/upgrade_minor_versions
=== RUN   TestCustomizeDiffEngineVersionIsDowngrade/downgrade_from_major_6.x
=== RUN   TestCustomizeDiffEngineVersionIsDowngrade/switch_major_6.digit_to_6.x
=== RUN   TestCustomizeDiffEngineVersionIsDowngrade/downgrade_from_major_7.x_to_6.x
--- PASS: TestCustomizeDiffEngineVersionIsDowngrade (0.00s)
    --- PASS: TestCustomizeDiffEngineVersionIsDowngrade/upgrade_major_versions (0.00s)
    --- PASS: TestCustomizeDiffEngineVersionIsDowngrade/downgrade_minor_versions (0.00s)
    --- PASS: TestCustomizeDiffEngineVersionIsDowngrade/downgrade_major_versions (0.00s)
    --- PASS: TestCustomizeDiffEngineVersionIsDowngrade/downgrade_major_6.digit (0.00s)
    --- PASS: TestCustomizeDiffEngineVersionIsDowngrade/downgrade_from_major_7.digit_to_6.x (0.00s)
    --- PASS: TestCustomizeDiffEngineVersionIsDowngrade/no_change (0.00s)
    --- PASS: TestCustomizeDiffEngineVersionIsDowngrade/upgrade_minor_versions (0.00s)
    --- PASS: TestCustomizeDiffEngineVersionIsDowngrade/downgrade_from_major_6.x (0.00s)
    --- PASS: TestCustomizeDiffEngineVersionIsDowngrade/switch_major_6.digit_to_6.x (0.00s)
    --- PASS: TestCustomizeDiffEngineVersionIsDowngrade/downgrade_from_major_7.x_to_6.x (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	3.605s
% go test -v -run=TestVersionDiff ./internal/service/elasticache
=== RUN   TestVersionDiff
--- PASS: TestVersionDiff (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	4.428s
% ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOn\|TestAccElastiCacheGlobalReplicationGroup_SetParameterGroup' PKG=elasticache ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 1  -run=TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOn\|TestAccElastiCacheGlobalReplicationGroup_SetParameterGroup -timeout 360m
=== RUN   TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_v6
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_v6
=== RUN   TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_v6x
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_v6x
=== RUN   TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_v5
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_v5
=== RUN   TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorUpgrade
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorUpgrade
=== RUN   TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorUpgrade_6x
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorUpgrade_6x
=== RUN   TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MajorUpgrade
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MajorUpgrade
=== RUN   TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MajorUpgrade_6x
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MajorUpgrade_6x
=== RUN   TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorDowngrade
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorDowngrade
=== RUN   TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnCreate_NoVersion
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnCreate_NoVersion
=== RUN   TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnCreate_MinorUpgrade
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnCreate_MinorUpgrade
=== RUN   TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorUpgrade
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorUpgrade
=== RUN   TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorUpgrade_6x
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorUpgrade_6x
=== RUN   TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorDowngrade
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorDowngrade
=== RUN   TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MajorUpgrade
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MajorUpgrade
=== RUN   TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MajorUpgrade_6x
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MajorUpgrade_6x
=== RUN   TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnUpdate_NoVersion
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnUpdate_NoVersion
=== RUN   TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnUpdate_MinorUpgrade
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnUpdate_MinorUpgrade
=== CONT  TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_v6
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_v6 (1001.27s)
=== CONT  TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnCreate_MinorUpgrade
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnCreate_MinorUpgrade (835.89s)
=== CONT  TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnUpdate_MinorUpgrade
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnUpdate_MinorUpgrade (1035.95s)
=== CONT  TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnUpdate_NoVersion
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnUpdate_NoVersion (959.00s)
=== CONT  TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MajorUpgrade_6x
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MajorUpgrade_6x (1486.13s)
=== CONT  TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MajorUpgrade
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MajorUpgrade (1297.00s)
=== CONT  TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorDowngrade
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorDowngrade (865.18s)
=== CONT  TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorUpgrade_6x
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorUpgrade_6x (993.14s)
=== CONT  TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorUpgrade
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorUpgrade (1264.24s)
=== CONT  TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MajorUpgrade
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MajorUpgrade (1268.78s)
=== CONT  TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnCreate_NoVersion
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnCreate_NoVersion (2.66s)
=== CONT  TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorDowngrade
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorDowngrade (910.93s)
=== CONT  TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MajorUpgrade_6x
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MajorUpgrade_6x (1236.06s)
=== CONT  TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorUpgrade
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorUpgrade (1241.30s)
=== CONT  TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorUpgrade_6x
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorUpgrade_6x (886.56s)
=== CONT  TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_v5
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_v5 (1003.73s)
=== CONT  TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_v6x
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_v6x (901.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	17192.794s

@gdavison @ewbankkit
Spelling correction
008c0f9 
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
@gdavison gdavison merged commit 61338c8 into main May 27, 2022
@gdavison gdavison deleted the elasticache-global-rep-update branch May 27, 2022 17:20
@github-actions github-actions bot added this to the v4.16.0 milestone May 27, 2022
github-actions bot pushed a commit that referenced this pull request May 27, 2022
Update CHANGELOG.md for #25077
54d443d
@github-actions
Copy link

This functionality has been released in v4.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.16.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gdavison @ewbankkit