-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_elasticache_global_replication_group: Support upgrading version #25077
Conversation
…on group and making minor version updates
27f3462
to
edc5536
Compare
website/docs/r/elasticache_global_replication_group.html.markdown
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% go test -v -run=TestCustomizeDiffEngineVersionIsDowngrade ./internal/service/elasticache
=== RUN TestCustomizeDiffEngineVersionIsDowngrade
=== RUN TestCustomizeDiffEngineVersionIsDowngrade/upgrade_major_versions
=== RUN TestCustomizeDiffEngineVersionIsDowngrade/downgrade_minor_versions
=== RUN TestCustomizeDiffEngineVersionIsDowngrade/downgrade_major_versions
=== RUN TestCustomizeDiffEngineVersionIsDowngrade/downgrade_major_6.digit
=== RUN TestCustomizeDiffEngineVersionIsDowngrade/downgrade_from_major_7.digit_to_6.x
=== RUN TestCustomizeDiffEngineVersionIsDowngrade/no_change
=== RUN TestCustomizeDiffEngineVersionIsDowngrade/upgrade_minor_versions
=== RUN TestCustomizeDiffEngineVersionIsDowngrade/downgrade_from_major_6.x
=== RUN TestCustomizeDiffEngineVersionIsDowngrade/switch_major_6.digit_to_6.x
=== RUN TestCustomizeDiffEngineVersionIsDowngrade/downgrade_from_major_7.x_to_6.x
--- PASS: TestCustomizeDiffEngineVersionIsDowngrade (0.00s)
--- PASS: TestCustomizeDiffEngineVersionIsDowngrade/upgrade_major_versions (0.00s)
--- PASS: TestCustomizeDiffEngineVersionIsDowngrade/downgrade_minor_versions (0.00s)
--- PASS: TestCustomizeDiffEngineVersionIsDowngrade/downgrade_major_versions (0.00s)
--- PASS: TestCustomizeDiffEngineVersionIsDowngrade/downgrade_major_6.digit (0.00s)
--- PASS: TestCustomizeDiffEngineVersionIsDowngrade/downgrade_from_major_7.digit_to_6.x (0.00s)
--- PASS: TestCustomizeDiffEngineVersionIsDowngrade/no_change (0.00s)
--- PASS: TestCustomizeDiffEngineVersionIsDowngrade/upgrade_minor_versions (0.00s)
--- PASS: TestCustomizeDiffEngineVersionIsDowngrade/downgrade_from_major_6.x (0.00s)
--- PASS: TestCustomizeDiffEngineVersionIsDowngrade/switch_major_6.digit_to_6.x (0.00s)
--- PASS: TestCustomizeDiffEngineVersionIsDowngrade/downgrade_from_major_7.x_to_6.x (0.00s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 3.605s
% go test -v -run=TestVersionDiff ./internal/service/elasticache
=== RUN TestVersionDiff
--- PASS: TestVersionDiff (0.00s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 4.428s
% ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOn\|TestAccElastiCacheGlobalReplicationGroup_SetParameterGroup' PKG=elasticache ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 1 -run=TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOn\|TestAccElastiCacheGlobalReplicationGroup_SetParameterGroup -timeout 360m
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_v6
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_v6
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_v6x
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_v6x
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_v5
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_v5
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorUpgrade
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorUpgrade
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorUpgrade_6x
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorUpgrade_6x
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MajorUpgrade
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MajorUpgrade
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MajorUpgrade_6x
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MajorUpgrade_6x
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorDowngrade
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorDowngrade
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnCreate_NoVersion
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnCreate_NoVersion
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnCreate_MinorUpgrade
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnCreate_MinorUpgrade
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorUpgrade
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorUpgrade
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorUpgrade_6x
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorUpgrade_6x
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorDowngrade
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorDowngrade
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MajorUpgrade
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MajorUpgrade
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MajorUpgrade_6x
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MajorUpgrade_6x
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnUpdate_NoVersion
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnUpdate_NoVersion
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnUpdate_MinorUpgrade
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnUpdate_MinorUpgrade
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_v6
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_v6 (1001.27s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnCreate_MinorUpgrade
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnCreate_MinorUpgrade (835.89s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnUpdate_MinorUpgrade
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnUpdate_MinorUpgrade (1035.95s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnUpdate_NoVersion
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnUpdate_NoVersion (959.00s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MajorUpgrade_6x
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MajorUpgrade_6x (1486.13s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MajorUpgrade
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MajorUpgrade (1297.00s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorDowngrade
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorDowngrade (865.18s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorUpgrade_6x
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorUpgrade_6x (993.14s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorUpgrade
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorUpgrade (1264.24s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MajorUpgrade
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MajorUpgrade (1268.78s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnCreate_NoVersion
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnCreate_NoVersion (2.66s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorDowngrade
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorDowngrade (910.93s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MajorUpgrade_6x
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MajorUpgrade_6x (1236.06s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorUpgrade
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorUpgrade (1241.30s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorUpgrade_6x
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorUpgrade_6x (886.56s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_v5
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_v5 (1003.73s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_v6x
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_v6x (901.14s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 17192.794s
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
This functionality has been released in v4.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Adds support for upgrading the
engine_version
for anaws_elasticache_global_replication_group
Relates #17696
Output from acceptance testing: