-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
b/aws_s3_bucket-object_lock-default-refactor #25098
b/aws_s3_bucket-object_lock-default-refactor #25098
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @Simple-Analysis 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Any plans to prioritize merging this? I am also running into this issue. |
Following up that we are also running into this issue still. If there is anything that I can do to help get this PR merged, please let me know. I tried to follow the contributing guide as best I could to ensure a quick review. |
…r-aws into b-aws_s3_bucket-object_lock-default-refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! 🎉
% make testacc TESTS=TestAccS3Bucket_Manage PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3Bucket_Manage' -timeout 180m
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock (76.98s)
--- PASS: TestAccS3Bucket_Manage_versioningDisabled (77.01s)
--- PASS: TestAccS3Bucket_Manage_objectLock_deprecatedEnabled (77.04s)
--- PASS: TestAccS3Bucket_Manage_MFADeleteDisabled (86.98s)
--- PASS: TestAccS3Bucket_Manage_objectLockWithVersioning_deprecatedEnabled (87.19s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration (87.29s)
--- PASS: TestAccS3Bucket_Manage_objectLockWithVersioning (87.76s)
--- PASS: TestAccS3Bucket_Manage_objectLock_migrate (102.74s)
--- PASS: TestAccS3Bucket_Manage_versioningAndMFADeleteDisabled (103.34s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRemove (109.18s)
--- PASS: TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly (115.91s)
--- PASS: TestAccS3Bucket_Manage_lifecycleBasic (116.14s)
--- PASS: TestAccS3Bucket_Manage_objectLock (121.13s)
--- PASS: TestAccS3Bucket_Manage_versioning (131.76s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 133.015s
This functionality has been released in v4.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #24809
Relates #22575
Relates #18593
Output from acceptance testing: