b/aws_s3_bucket-object_lock-default-refactor

[Simple-Analysis]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24809
Relates #22575
Relates #18593

Output from acceptance testing:

$ make testacc PKG=s3 TESTS='TestAccS3Bucket_'

=== CONT  TestAccS3Bucket_Manage_objectLockWithVersioning
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock (26.50s)
=== CONT  TestAccS3Bucket_Basic_forceDestroy
--- PASS: TestAccS3Bucket_Basic_basic (28.71s)
=== CONT  TestAccS3Bucket_Basic_acceleration
--- PASS: TestAccS3Bucket_Manage_MFADeleteDisabled (31.64s)
=== CONT  TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled
--- PASS: TestAccS3Bucket_Manage_versioningDisabled (31.69s)
=== CONT  TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes
--- PASS: TestAccS3Bucket_Manage_versioningAndMFADeleteDisabled (31.97s)
=== CONT  TestAccS3Bucket_disappears
--- PASS: TestAccS3Bucket_Manage_objectLock_deprecatedEnabled (32.43s)
=== CONT  TestAccS3Bucket_Tags_basic
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration (33.03s)
=== CONT  TestAccS3Bucket_Basic_generatedName
--- PASS: TestAccS3Bucket_Manage_objectLockWithVersioning (33.13s)
=== CONT  TestAccS3Bucket_Basic_emptyString
--- PASS: TestAccS3Bucket_Basic_keyEnabled (34.35s)
=== CONT  TestAccS3Bucket_Basic_requestPayer
--- PASS: TestAccS3Bucket_Manage_objectLockWithVersioning_deprecatedEnabled (34.97s)
=== CONT  TestAccS3Bucket_Basic_namePrefix
--- PASS: TestAccS3Bucket_Manage_objectLock_migrate (41.86s)
=== CONT  TestAccS3Bucket_Security_aclToGrant
--- PASS: TestAccS3Bucket_Manage_lifecycleRemove (47.10s)
=== CONT  TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical
--- PASS: TestAccS3Bucket_Manage_objectLock (50.65s)
=== CONT  TestAccS3Bucket_Security_logging
--- PASS: TestAccS3Bucket_disappears (18.69s)
=== CONT  TestAccS3Bucket_Web_routingRules
--- PASS: TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly (51.30s)
=== CONT  TestAccS3Bucket_Security_corsSingleMethodAndEmptyOrigin
--- PASS: TestAccS3Bucket_Tags_ignoreTags (51.34s)
=== CONT  TestAccS3Bucket_Web_redirect
--- PASS: TestAccS3Bucket_Basic_forceDestroy (25.12s)
=== CONT  TestAccS3Bucket_Security_corsEmptyOrigin
--- PASS: TestAccS3Bucket_Manage_lifecycleBasic (53.17s)
=== CONT  TestAccS3Bucket_Web_simple
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (25.13s)
=== CONT  TestAccS3Bucket_Security_corsDelete
--- PASS: TestAccS3Bucket_Manage_versioning (58.48s)
=== CONT  TestAccS3Bucket_Security_policy
--- PASS: TestAccS3Bucket_Basic_generatedName (28.04s)
=== CONT  TestAccS3Bucket_Security_corsUpdate
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (30.13s)
=== CONT  TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled
--- PASS: TestAccS3Bucket_Basic_emptyString (29.19s)
=== CONT  TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed
--- PASS: TestAccS3Bucket_Tags_basic (31.26s)
=== CONT  TestAccS3Bucket_Security_grantToACL
--- PASS: TestAccS3Bucket_Basic_namePrefix (28.83s)
=== CONT  TestAccS3Bucket_Replication_expectVersioningValidationError
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical (32.72s)
=== CONT  TestAccS3Bucket_Replication_RTC_valid
--- PASS: TestAccS3Bucket_Security_corsSingleMethodAndEmptyOrigin (29.83s)
=== CONT  TestAccS3Bucket_Replication_schemaV2SameRegion
--- PASS: TestAccS3Bucket_Security_corsDelete (24.98s)
=== CONT  TestAccS3Bucket_Security_updateGrant
--- PASS: TestAccS3Bucket_Security_corsEmptyOrigin (30.32s)
=== CONT  TestAccS3Bucket_Security_updateACL
--- PASS: TestAccS3Bucket_Basic_acceleration (54.18s)
=== CONT  TestAccS3Bucket_Replication_schemaV2
--- PASS: TestAccS3Bucket_Basic_requestPayer (49.74s)
=== CONT  TestAccS3Bucket_Replication_withoutPrefix
--- PASS: TestAccS3Bucket_Security_logging (33.66s)
=== CONT  TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation
--- PASS: TestAccS3Bucket_Replication_expectVersioningValidationError (22.06s)
=== CONT  TestAccS3Bucket_Replication_withoutStorageClass
--- PASS: TestAccS3Bucket_Security_aclToGrant (49.58s)
=== CONT  TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed (30.83s)
=== CONT  TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation
--- PASS: TestAccS3Bucket_Web_routingRules (50.25s)
=== CONT  TestAccS3Bucket_Replication_twoDestination
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (101.89s)
=== CONT  TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter
--- PASS: TestAccS3Bucket_Replication_basic (108.05s)
--- PASS: TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled (52.74s)
--- PASS: TestAccS3Bucket_Security_grantToACL (52.67s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (55.71s)
--- PASS: TestAccS3Bucket_Replication_schemaV2SameRegion (37.55s)
--- PASS: TestAccS3Bucket_Web_simple (73.97s)
--- PASS: TestAccS3Bucket_Security_policy (69.07s)
--- PASS: TestAccS3Bucket_Web_redirect (76.30s)
--- PASS: TestAccS3Bucket_Replication_withoutPrefix (45.29s)
--- PASS: TestAccS3Bucket_Replication_withoutStorageClass (45.26s)
--- PASS: TestAccS3Bucket_Security_updateACL (50.15s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter (42.90s)
--- PASS: TestAccS3Bucket_Replication_twoDestination (37.05s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter (37.62s)
--- PASS: TestAccS3Bucket_Tags_withSystemTags (145.32s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation (62.60s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation (57.79s)
--- PASS: TestAccS3Bucket_Security_updateGrant (76.76s)
--- PASS: TestAccS3Bucket_Replication_RTC_valid (92.20s)
--- PASS: TestAccS3Bucket_Replication_schemaV2 (106.26s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3 189.782s
...

[github-actions]

Welcome @Simple-Analysis 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[scotthesterberg]

Any plans to prioritize merging this? I am also running into this issue.

[Simple-Analysis]

Following up that we are also running into this issue still.

If there is anything that I can do to help get this PR merged, please let me know. I tried to follow the contributing guide as best I could to ensure a quick review.

[YakDriver]

Great job! 🎉

% make testacc TESTS=TestAccS3Bucket_Manage PKG=s3           
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3Bucket_Manage'  -timeout 180m
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock (76.98s)
--- PASS: TestAccS3Bucket_Manage_versioningDisabled (77.01s)
--- PASS: TestAccS3Bucket_Manage_objectLock_deprecatedEnabled (77.04s)
--- PASS: TestAccS3Bucket_Manage_MFADeleteDisabled (86.98s)
--- PASS: TestAccS3Bucket_Manage_objectLockWithVersioning_deprecatedEnabled (87.19s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration (87.29s)
--- PASS: TestAccS3Bucket_Manage_objectLockWithVersioning (87.76s)
--- PASS: TestAccS3Bucket_Manage_objectLock_migrate (102.74s)
--- PASS: TestAccS3Bucket_Manage_versioningAndMFADeleteDisabled (103.34s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRemove (109.18s)
--- PASS: TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly (115.91s)
--- PASS: TestAccS3Bucket_Manage_lifecycleBasic (116.14s)
--- PASS: TestAccS3Bucket_Manage_objectLock (121.13s)
--- PASS: TestAccS3Bucket_Manage_versioning (131.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	133.015s

[github-actions]

This functionality has been released in v4.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.