Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_db_instance_role_association & aws_rds_cluster_role_association: Extend timeouts #25145

Merged
merged 6 commits into from
Jun 2, 2022

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Jun 2, 2022

Extends the timeouts for aws_db_instance_role_association and aws_rds_cluster_role_association.

Closes #24963

Output from acceptance testing:

$ make testacc PKG=rds TESTS='TestAccRDSInstanceRoleAssociation|TestAccRDSClusterRoleAssociation'

--- PASS: TestAccRDSClusterRoleAssociation_Disappears_cluster (184.79s)
--- PASS: TestAccRDSClusterRoleAssociation_Disappears_role (187.39s)
--- PASS: TestAccRDSClusterRoleAssociation_disappears (190.88s)
--- PASS: TestAccRDSClusterRoleAssociation_basic (205.95s)
--- PASS: TestAccRDSInstanceRoleAssociation_disappears (901.54s)
--- PASS: TestAccRDSInstanceRoleAssociation_basic (972.91s)

@github-actions github-actions bot added service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Jun 2, 2022
@gdavison gdavison marked this pull request as ready for review June 2, 2022 21:59
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSInstanceRoleAssociation_' PKG=rds ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSInstanceRoleAssociation_ -timeout 180m
=== RUN   TestAccRDSInstanceRoleAssociation_basic
=== PAUSE TestAccRDSInstanceRoleAssociation_basic
=== RUN   TestAccRDSInstanceRoleAssociation_disappears
=== PAUSE TestAccRDSInstanceRoleAssociation_disappears
=== CONT  TestAccRDSInstanceRoleAssociation_basic
=== CONT  TestAccRDSInstanceRoleAssociation_disappears
--- PASS: TestAccRDSInstanceRoleAssociation_disappears (928.09s)
--- PASS: TestAccRDSInstanceRoleAssociation_basic (959.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	963.846s

@gdavison gdavison merged commit f76ac98 into main Jun 2, 2022
@gdavison gdavison deleted the db_instance_role_association branch June 2, 2022 23:49
@github-actions github-actions bot added this to the v4.17.0 milestone Jun 2, 2022
github-actions bot pushed a commit that referenced this pull request Jun 2, 2022
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

This functionality has been released in v4.17.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jul 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

db_instance_role_association IAM eventual consistency
2 participants