rd/cognito_user_pool_client - add enable_propagate_additional_user_context_data argument + use finders

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTS=TestAccCognitoIDPUserPoolClient_ PKG=cognitoidp
--- PASS: TestAccCognitoIDPUserPoolClient_Disappears_userPool (29.14s)
--- PASS: TestAccCognitoIDPUserPoolClient_disappears (34.31s)
--- PASS: TestAccCognitoIDPUserPoolClient_allFields (39.19s)
--- PASS: TestAccCognitoIDPUserPoolClient_basic (39.27s)
--- PASS: TestAccCognitoIDPUserPoolClient_analyticsWithARN (41.39s)
--- PASS: TestAccCognitoIDPUserPoolClient_tokenValidityUnits (56.55s)
--- PASS: TestAccCognitoIDPUserPoolClient_idTokenValidity (57.89s)
--- PASS: TestAccCognitoIDPUserPoolClient_name (59.74s)
--- PASS: TestAccCognitoIDPUserPoolClient_tokenValidityUnitsWTokenValidity (59.92s)
--- PASS: TestAccCognitoIDPUserPoolClient_allFieldsUpdatingOneField (60.13s)
--- PASS: TestAccCognitoIDPUserPoolClient_refreshTokenValidity (60.36s)
--- PASS: TestAccCognitoIDPUserPoolClient_accessTokenValidity (60.58s)
--- PASS: TestAccCognitoIDPUserPoolClient_enableRevocation (77.71s)
--- PASS: TestAccCognitoIDPUserPoolClient_analytics (89.30s)

$ make testacc TESTS=TestAccCognitoIDPUserPoolClientDataSource_basic PKG=cognitoidp
--- PASS: TestAccCognitoIDPUserPoolClientDataSource_basic (32.31s)

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCognitoIDPUserPoolClient_' PKG=cognitoidp ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 2  -run=TestAccCognitoIDPUserPoolClient_ -timeout 180m
=== RUN   TestAccCognitoIDPUserPoolClient_basic
=== PAUSE TestAccCognitoIDPUserPoolClient_basic
=== RUN   TestAccCognitoIDPUserPoolClient_enableRevocation
=== PAUSE TestAccCognitoIDPUserPoolClient_enableRevocation
=== RUN   TestAccCognitoIDPUserPoolClient_refreshTokenValidity
=== PAUSE TestAccCognitoIDPUserPoolClient_refreshTokenValidity
=== RUN   TestAccCognitoIDPUserPoolClient_accessTokenValidity
=== PAUSE TestAccCognitoIDPUserPoolClient_accessTokenValidity
=== RUN   TestAccCognitoIDPUserPoolClient_idTokenValidity
=== PAUSE TestAccCognitoIDPUserPoolClient_idTokenValidity
=== RUN   TestAccCognitoIDPUserPoolClient_tokenValidityUnits
=== PAUSE TestAccCognitoIDPUserPoolClient_tokenValidityUnits
=== RUN   TestAccCognitoIDPUserPoolClient_tokenValidityUnitsWTokenValidity
=== PAUSE TestAccCognitoIDPUserPoolClient_tokenValidityUnitsWTokenValidity
=== RUN   TestAccCognitoIDPUserPoolClient_name
=== PAUSE TestAccCognitoIDPUserPoolClient_name
=== RUN   TestAccCognitoIDPUserPoolClient_allFields
=== PAUSE TestAccCognitoIDPUserPoolClient_allFields
=== RUN   TestAccCognitoIDPUserPoolClient_allFieldsUpdatingOneField
=== PAUSE TestAccCognitoIDPUserPoolClient_allFieldsUpdatingOneField
=== RUN   TestAccCognitoIDPUserPoolClient_analytics
=== PAUSE TestAccCognitoIDPUserPoolClient_analytics
=== RUN   TestAccCognitoIDPUserPoolClient_analyticsWithARN
=== PAUSE TestAccCognitoIDPUserPoolClient_analyticsWithARN
=== RUN   TestAccCognitoIDPUserPoolClient_disappears
=== PAUSE TestAccCognitoIDPUserPoolClient_disappears
=== RUN   TestAccCognitoIDPUserPoolClient_Disappears_userPool
=== PAUSE TestAccCognitoIDPUserPoolClient_Disappears_userPool
=== CONT  TestAccCognitoIDPUserPoolClient_basic
=== CONT  TestAccCognitoIDPUserPoolClient_name
--- PASS: TestAccCognitoIDPUserPoolClient_basic (22.27s)
=== CONT  TestAccCognitoIDPUserPoolClient_analyticsWithARN
--- PASS: TestAccCognitoIDPUserPoolClient_name (37.95s)
=== CONT  TestAccCognitoIDPUserPoolClient_Disappears_userPool
--- PASS: TestAccCognitoIDPUserPoolClient_analyticsWithARN (24.61s)
=== CONT  TestAccCognitoIDPUserPoolClient_disappears
--- PASS: TestAccCognitoIDPUserPoolClient_Disappears_userPool (15.15s)
=== CONT  TestAccCognitoIDPUserPoolClient_allFieldsUpdatingOneField
--- PASS: TestAccCognitoIDPUserPoolClient_disappears (16.40s)
=== CONT  TestAccCognitoIDPUserPoolClient_analytics
--- PASS: TestAccCognitoIDPUserPoolClient_allFieldsUpdatingOneField (31.18s)
=== CONT  TestAccCognitoIDPUserPoolClient_allFields
--- PASS: TestAccCognitoIDPUserPoolClient_allFields (19.10s)
=== CONT  TestAccCognitoIDPUserPoolClient_idTokenValidity
--- PASS: TestAccCognitoIDPUserPoolClient_analytics (48.52s)
=== CONT  TestAccCognitoIDPUserPoolClient_tokenValidityUnitsWTokenValidity
--- PASS: TestAccCognitoIDPUserPoolClient_idTokenValidity (33.00s)
=== CONT  TestAccCognitoIDPUserPoolClient_tokenValidityUnits
--- PASS: TestAccCognitoIDPUserPoolClient_tokenValidityUnitsWTokenValidity (36.12s)
=== CONT  TestAccCognitoIDPUserPoolClient_enableRevocation
--- PASS: TestAccCognitoIDPUserPoolClient_tokenValidityUnits (33.64s)
=== CONT  TestAccCognitoIDPUserPoolClient_accessTokenValidity
--- PASS: TestAccCognitoIDPUserPoolClient_enableRevocation (42.97s)
=== CONT  TestAccCognitoIDPUserPoolClient_refreshTokenValidity
--- PASS: TestAccCognitoIDPUserPoolClient_accessTokenValidity (30.86s)
--- PASS: TestAccCognitoIDPUserPoolClient_refreshTokenValidity (31.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	226.305s

[github-actions]

This functionality has been released in v4.18.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.