New Resource: aws_ce_anomaly_subscription #25224

brittandeyoung · 2022-06-07T20:15:08Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

➜ terraform-provider-aws (f-aws_ce_anomaly_subscription) ✗ make testacc TESTARGS='-run=TestAccCEAnomalySubscription_' PKG_NAME=internal/service/ce  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ce/... -v -count 1 -parallel 20  -run=TestAccCEAnomalySubscription_ -timeout 180m
=== RUN   TestAccCEAnomalySubscription_basic
--- PASS: TestAccCEAnomalySubscription_basic (23.26s)
=== RUN   TestAccCEAnomalySubscription_Frequency
=== PAUSE TestAccCEAnomalySubscription_Frequency
=== RUN   TestAccCEAnomalySubscription_MonitorARNList
=== PAUSE TestAccCEAnomalySubscription_MonitorARNList
=== RUN   TestAccCEAnomalySubscription_Subscriber
=== PAUSE TestAccCEAnomalySubscription_Subscriber
=== RUN   TestAccCEAnomalySubscription_Threshold
=== PAUSE TestAccCEAnomalySubscription_Threshold
=== RUN   TestAccCEAnomalySubscription_Tags
=== PAUSE TestAccCEAnomalySubscription_Tags
=== CONT  TestAccCEAnomalySubscription_Frequency
=== CONT  TestAccCEAnomalySubscription_Threshold
=== CONT  TestAccCEAnomalySubscription_Tags
=== CONT  TestAccCEAnomalySubscription_Subscriber
=== CONT  TestAccCEAnomalySubscription_MonitorARNList
--- PASS: TestAccCEAnomalySubscription_Frequency (50.54s)
--- PASS: TestAccCEAnomalySubscription_MonitorARNList (54.56s)
--- PASS: TestAccCEAnomalySubscription_Threshold (55.77s)
--- PASS: TestAccCEAnomalySubscription_Tags (68.03s)
--- PASS: TestAccCEAnomalySubscription_Subscriber (86.73s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ce 113.456s

…ption

- Amend anomaly subscription resource to support tags - Amend anomaly subscription resource update subscribers correctly - Amend anomaly subscription tests to test each update field

- Added website docs - Amend resource, correct caps service names in functions - Amend tests, randomize emails - Amend test, add subscriber type SNS test case

- Amend docs to fit proper indentation of list items - Amend ARN check to ensure proper format

- Amend resource update function to include "tags_all" - Amend errors to produce correct output based on CRUD operation.

merge `main` to bring branch up to speed

- Add FindAnomalySubscriptionByARN finder - Update tests to use new finder - Update read to use new finder

- Amend tests: fix terraform lint

brittandeyoung · 2022-06-10T20:01:48Z

Rebase from main after merge of #25177 and added improvements. Output of current acceptance tests:

➜ terraform-provider-aws (f-aws_ce_anomaly_subscription) ✗ make testacc TESTARGS='-run=TestAccCEAnomalySubscription_' PKG_NAME=internal/service/ce 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ce/... -v -count 1 -parallel 20  -run=TestAccCEAnomalySubscription_ -timeout 180m
=== RUN   TestAccCEAnomalySubscription_basic
--- PASS: TestAccCEAnomalySubscription_basic (22.76s)
=== RUN   TestAccCEAnomalySubscription_Frequency
=== PAUSE TestAccCEAnomalySubscription_Frequency
=== RUN   TestAccCEAnomalySubscription_MonitorARNList
=== PAUSE TestAccCEAnomalySubscription_MonitorARNList
=== RUN   TestAccCEAnomalySubscription_Subscriber
=== PAUSE TestAccCEAnomalySubscription_Subscriber
=== RUN   TestAccCEAnomalySubscription_Threshold
=== PAUSE TestAccCEAnomalySubscription_Threshold
=== RUN   TestAccCEAnomalySubscription_Tags
=== PAUSE TestAccCEAnomalySubscription_Tags
=== CONT  TestAccCEAnomalySubscription_Frequency
=== CONT  TestAccCEAnomalySubscription_Threshold
=== CONT  TestAccCEAnomalySubscription_Subscriber
=== CONT  TestAccCEAnomalySubscription_MonitorARNList
=== CONT  TestAccCEAnomalySubscription_Tags
--- PASS: TestAccCEAnomalySubscription_Threshold (56.23s)
--- PASS: TestAccCEAnomalySubscription_Frequency (56.98s)
--- PASS: TestAccCEAnomalySubscription_MonitorARNList (57.81s)
--- PASS: TestAccCEAnomalySubscription_Tags (69.02s)
--- PASS: TestAccCEAnomalySubscription_Subscriber (86.65s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ce 112.914s

- Check content of subscriber block in basic test - Check import at each step of Subscriber attribute test

- Checking the exact values of a nested Set or List value is not recommended or necessary: - Faulty errors can result from changed indices - Testing framework will already return failure if there is a mismatch with specified config during ImportStateVerify - If check *is* necessary: should use TestCheckTypeSetElemNestedAttrs (https://pkg.go.dev/github.com/hashicorp/terraform-plugin-sdk/v2@v2.17.0/helper/resource#TestCheckTypeSetElemNestedAttrs)

zhelding · 2022-06-21T21:44:57Z

Hi @brittandeyoung! I've made a handful of minor edits -- mostly around acceptance testing robustness.

Acceptance tests appear to cover all desired functionality and are fully passing:

❯ make testacc TESTS=TestAccCEAnomalySubscription PKG=ce
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ce/... -v -count 1 -parallel 20 -run='TestAccCEAnomalySubscription'  -timeout 180m
=== RUN   TestAccCEAnomalySubscription_basic
=== PAUSE TestAccCEAnomalySubscription_basic
=== RUN   TestAccCEAnomalySubscription_disappears
=== PAUSE TestAccCEAnomalySubscription_disappears
=== RUN   TestAccCEAnomalySubscription_Frequency
=== PAUSE TestAccCEAnomalySubscription_Frequency
=== RUN   TestAccCEAnomalySubscription_MonitorARNList
=== PAUSE TestAccCEAnomalySubscription_MonitorARNList
=== RUN   TestAccCEAnomalySubscription_Subscriber
=== PAUSE TestAccCEAnomalySubscription_Subscriber
=== RUN   TestAccCEAnomalySubscription_Threshold
=== PAUSE TestAccCEAnomalySubscription_Threshold
=== RUN   TestAccCEAnomalySubscription_Tags
=== PAUSE TestAccCEAnomalySubscription_Tags
=== CONT  TestAccCEAnomalySubscription_basic
=== CONT  TestAccCEAnomalySubscription_Subscriber
=== CONT  TestAccCEAnomalySubscription_Tags
=== CONT  TestAccCEAnomalySubscription_Frequency
=== CONT  TestAccCEAnomalySubscription_Threshold
=== CONT  TestAccCEAnomalySubscription_MonitorARNList
=== CONT  TestAccCEAnomalySubscription_disappears
--- PASS: TestAccCEAnomalySubscription_disappears (14.48s)
--- PASS: TestAccCEAnomalySubscription_basic (16.71s)
--- PASS: TestAccCEAnomalySubscription_Frequency (26.48s)
--- PASS: TestAccCEAnomalySubscription_MonitorARNList (26.62s)
--- PASS: TestAccCEAnomalySubscription_Threshold (26.69s)
--- PASS: TestAccCEAnomalySubscription_Tags (34.78s)
--- PASS: TestAccCEAnomalySubscription_Subscriber (49.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ce	49.522s

Thanks so much for your work here @brittandeyoung; am looking forward to seeing further contributions!

Merging to main 🚀

zhelding · 2022-06-22T16:27:11Z

Made final small edit. Acceptance tests confirmed still passing ✔️

github-actions · 2022-06-23T23:09:24Z

This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-07-24T02:41:36Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

brittandeyoung added 4 commits June 7, 2022 10:16

Add Initial aws_ce_anomaly_subscription resource

11735e2

Merge branch 'f-aws_ce_anomaly_monitor' into f-aws_ce_anomaly_subscri…

f4ad7f3

…ption

Added working basic test

698a98c

ce: Amend anomaly subscription test and resource

b0df680

- Amend anomaly subscription resource to support tags - Amend anomaly subscription resource update subscribers correctly - Amend anomaly subscription tests to test each update field

brittandeyoung changed the title ~~New Resource: aws_ce_anomaly_subscription~~ [WIP] New Resource: aws_ce_anomaly_subscription Jun 7, 2022

brittandeyoung added 2 commits June 8, 2022 09:16

ce: Add docs, Amend resource and Amend tests

45df942

- Added website docs - Amend resource, correct caps service names in functions - Amend tests, randomize emails - Amend test, add subscriber type SNS test case

ce: Amend anomaly subscription tests and docs

eb52305

- Amend docs to fit proper indentation of list items - Amend ARN check to ensure proper format

brittandeyoung changed the title ~~[WIP] New Resource: aws_ce_anomaly_subscription~~ New Resource: aws_ce_anomaly_subscription Jun 8, 2022

justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 8, 2022

ce: Amend anomaly subscription

086c04d

- Amend resource update function to include "tags_all" - Amend errors to produce correct output based on CRUD operation.

zhelding mentioned this pull request Jun 9, 2022

New Resource: aws_ce_anomaly_monitor #25177

Merged

Merge branch 'main' into f-aws_ce_anomaly_subscription

9173b36

merge `main` to bring branch up to speed

github-actions bot removed generators Relates to code generators. tags Pertains to resource tagging. labels Jun 9, 2022

brittandeyoung added 2 commits June 9, 2022 16:14

ce: Amend Anomaly Subscription

887677d

- Add FindAnomalySubscriptionByARN finder - Update tests to use new finder - Update read to use new finder

ce: Amend Anomaly Subscription tests

4fe99ba

- Amend tests: fix terraform lint

zhelding self-requested a review June 10, 2022 18:17

zhelding added 2 commits June 15, 2022 15:08

Amend acceptance tests to use shared base config for standard monitor

0206fdb

Amend schema validation

310fd53

zhelding added 9 commits June 15, 2022 15:21

Add disappearance acceptance test for anomaly subscription

7f41f08

Amend acceptance tests

6fbc0c1

- Check content of subscriber block in basic test - Check import at each step of Subscriber attribute test

Allow for user-defined account_id input

6e94c67

Amend spelling on cost anomaly subscription docs

377356d

Specify account_id as an input in anomaly_subscription docs

56c9ae3

Merge branch 'main' into f-aws_ce_anomaly_subscription

8530329

Add newline between acceptance test functions

7fda8b8

Amend test config names to comply with semgrep rules

20c4413

zhelding approved these changes Jun 21, 2022

View reviewed changes

Rearrange cost explorer resources to group those re: anomalies

aa8b09d

zhelding merged commit 398ae31 into hashicorp:main Jun 22, 2022

github-actions bot added this to the v4.20.0 milestone Jun 22, 2022

zhelding mentioned this pull request Jun 22, 2022

terraform resources for the Cost Explorer Service #16137

Closed

This was referenced Jun 30, 2022

New data source aws_ce_anomaly_monitor or change aws_ce_anomaly_monitor #25632

Closed

aws_ce_anomaly_subscription type of subscriber address must be a "list" #25685

Closed

github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: aws_ce_anomaly_subscription #25224

New Resource: aws_ce_anomaly_subscription #25224

brittandeyoung commented Jun 7, 2022 •

edited

Loading

brittandeyoung commented Jun 10, 2022

zhelding commented Jun 21, 2022

zhelding commented Jun 22, 2022

github-actions bot commented Jun 23, 2022

github-actions bot commented Jul 24, 2022

New Resource: aws_ce_anomaly_subscription #25224

New Resource: aws_ce_anomaly_subscription #25224

Conversation

brittandeyoung commented Jun 7, 2022 • edited Loading

Community Note

brittandeyoung commented Jun 10, 2022

zhelding commented Jun 21, 2022

zhelding commented Jun 22, 2022

github-actions bot commented Jun 23, 2022

github-actions bot commented Jul 24, 2022

brittandeyoung commented Jun 7, 2022 •

edited

Loading