Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Eventbridge API Destination Invocation Rate Limit to be greater than 300 #25277

Merged

Conversation

jordanfinners
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25276

@github-actions github-actions bot added service/events Issues and PRs that pertain to the events service. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Jun 10, 2022
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 10, 2022
@jordanfinners
Copy link
Contributor Author

@justinretzolk would it be possible to rebuild the providerlint action step? Unsure why it failed

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEventsAPIDestination_' PKG=events ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 2  -run=TestAccEventsAPIDestination_ -timeout 180m
=== RUN   TestAccEventsAPIDestination_basic
=== PAUSE TestAccEventsAPIDestination_basic
=== RUN   TestAccEventsAPIDestination_optional
=== PAUSE TestAccEventsAPIDestination_optional
=== RUN   TestAccEventsAPIDestination_disappears
=== PAUSE TestAccEventsAPIDestination_disappears
=== CONT  TestAccEventsAPIDestination_basic
=== CONT  TestAccEventsAPIDestination_disappears
--- PASS: TestAccEventsAPIDestination_disappears (16.50s)
=== CONT  TestAccEventsAPIDestination_optional
--- PASS: TestAccEventsAPIDestination_basic (45.83s)
--- PASS: TestAccEventsAPIDestination_optional (44.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	64.736s

@ewbankkit
Copy link
Contributor

@jordanfinners Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit a818e06 into hashicorp:main Jun 22, 2022
@ewbankkit
Copy link
Contributor

@jordanfinners Thanks for the contribution 🎉 👏.

@github-actions github-actions bot added this to the v4.20.0 milestone Jun 22, 2022
@github-actions
Copy link

This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@jordanfinners jordanfinners deleted the f-eventbridge-api-destination-limit branch June 24, 2022 10:20
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/events Issues and PRs that pertain to the events service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eventbridge: Support Invocation Rate > 300
3 participants