Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/cognito_risk_configuration - new resource #25282

Merged
merged 10 commits into from
Jun 23, 2022
Merged

r/cognito_risk_configuration - new resource #25282

merged 10 commits into from
Jun 23, 2022

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #7007

Output from acceptance testing:

$ make testacc TESTS=TestAccCognitoIDPRiskConfiguration_ PKG=cognitoidp
--- PASS: TestAccCognitoIDPRiskConfiguration_disappears_userPool (29.84s)
--- PASS: TestAccCognitoIDPRiskConfiguration_compromised (38.48s)
--- PASS: TestAccCognitoIDPRiskConfiguration_client (41.34s)
--- PASS: TestAccCognitoIDPRiskConfiguration_exception (63.75s)

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 11, 2022
@DrFaust92 DrFaust92 added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 11, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jun 11, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review June 11, 2022 18:09
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. labels Jun 12, 2022
ewbankkit
ewbankkit approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCognitoIDPRiskConfiguration_' PKG=cognitoidp ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 2  -run=TestAccCognitoIDPRiskConfiguration_ -timeout 180m
=== RUN   TestAccCognitoIDPRiskConfiguration_exception
=== PAUSE TestAccCognitoIDPRiskConfiguration_exception
=== RUN   TestAccCognitoIDPRiskConfiguration_client
=== PAUSE TestAccCognitoIDPRiskConfiguration_client
=== RUN   TestAccCognitoIDPRiskConfiguration_compromised
=== PAUSE TestAccCognitoIDPRiskConfiguration_compromised
=== RUN   TestAccCognitoIDPRiskConfiguration_disappears_userPool
=== PAUSE TestAccCognitoIDPRiskConfiguration_disappears_userPool
=== CONT  TestAccCognitoIDPRiskConfiguration_exception
=== CONT  TestAccCognitoIDPRiskConfiguration_compromised
--- PASS: TestAccCognitoIDPRiskConfiguration_compromised (19.02s)
=== CONT  TestAccCognitoIDPRiskConfiguration_client
--- PASS: TestAccCognitoIDPRiskConfiguration_exception (30.63s)
=== CONT  TestAccCognitoIDPRiskConfiguration_disappears_userPool
--- PASS: TestAccCognitoIDPRiskConfiguration_client (18.05s)
--- PASS: TestAccCognitoIDPRiskConfiguration_disappears_userPool (12.89s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	47.173s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 6601e21 into hashicorp:main Jun 23, 2022
@github-actions github-actions bot added this to the v4.20.0 milestone Jun 23, 2022
@github-actions
Copy link

This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

TakumiHaruta
TakumiHaruta reviewed Jun 29, 2022
View reviewed changes
Copy link
Contributor

@TakumiHaruta TakumiHaruta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DrFaust92 @ewbankkit

This PR is really helpful. Thank you so much!

I possibly found some typos in the document. Please check them.
I'm not sure where to write such a minor report. It's okay to delete this comment if I'm not on the right track.

website/docs/r/cognito_risk_configuration.html.markdown
##### notify email type

* `html_body` - (Required) The email HTML body.
* `block_email` - (Required) The email subject.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: is block_email supposed to be subject?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create PR #25645

website/docs/r/cognito_risk_configuration.html.markdown

* `html_body` - (Required) The email HTML body.
* `block_email` - (Required) The email subject.
* `block_email` - (Required) The email text body.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: is block_email supposed to be text_body?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create PR #25645

@TakumiHaruta TakumiHaruta mentioned this pull request Jul 1, 2022
Closed
@github-actions
Copy link

github-actions bot commented Aug 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TakumiHaruta TakumiHaruta TakumiHaruta left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. github_actions Pull requests that update Github_actions code new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.20.0
Development

Successfully merging this pull request may close these issues.

AWS Cognito User Pool Doesn't Support Advanced Security Features
3 participants
@DrFaust92 @ewbankkit @TakumiHaruta