-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_dynamodb_table_item: fix to remove item elements on update #25326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Output of acceptance tests:
make testacc TESTARGS='-run=TestAccTableItem_' PKG=dynamodb
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run=TestAccTableItem_ -timeout 180m
=== RUN TestAccTableItem_basic
=== PAUSE TestAccTableItem_basic
=== RUN TestAccTableItem_rangeKey
=== PAUSE TestAccTableItem_rangeKey
=== RUN TestAccTableItem_withMultipleItems
=== PAUSE TestAccTableItem_withMultipleItems
=== RUN TestAccTableItem_wonkyItems
=== PAUSE TestAccTableItem_wonkyItems
=== RUN TestAccTableItem_update
=== PAUSE TestAccTableItem_update
=== RUN TestAccTableItem_updateWithRangeKey
=== PAUSE TestAccTableItem_updateWithRangeKey
=== RUN TestAccTableItem_disappears
=== PAUSE TestAccTableItem_disappears
=== CONT TestAccTableItem_basic
=== CONT TestAccTableItem_update
=== CONT TestAccTableItem_withMultipleItems
=== CONT TestAccTableItem_rangeKey
=== CONT TestAccTableItem_disappears
=== CONT TestAccTableItem_wonkyItems
=== CONT TestAccTableItem_updateWithRangeKey
--- PASS: TestAccTableItem_basic (27.12s)
--- PASS: TestAccTableItem_withMultipleItems (27.51s)
--- PASS: TestAccTableItem_disappears (28.01s)
--- PASS: TestAccTableItem_rangeKey (28.10s)
--- PASS: TestAccTableItem_wonkyItems (28.17s)
--- PASS: TestAccTableItem_updateWithRangeKey (39.55s)
--- PASS: TestAccTableItem_update (41.20s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb 44.288s
This functionality has been released in v4.19.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #15700
Output from acceptance testing: