Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_dynamodb_table_item: fix to remove item elements on update #25326

Merged
merged 6 commits into from
Jun 14, 2022

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Jun 14, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15700

Output from acceptance testing:

$ make testacc TESTS=TestAccTableItem_ PKG=dynamodb

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccTableItem_'  -timeout 180m
=== RUN   TestAccTableItem_basic
=== PAUSE TestAccTableItem_basic
=== RUN   TestAccTableItem_rangeKey
=== PAUSE TestAccTableItem_rangeKey
=== RUN   TestAccTableItem_withMultipleItems
=== PAUSE TestAccTableItem_withMultipleItems
=== RUN   TestAccTableItem_wonkyItems
=== PAUSE TestAccTableItem_wonkyItems
=== RUN   TestAccTableItem_update
=== PAUSE TestAccTableItem_update
=== RUN   TestAccTableItem_updateWithRangeKey
=== PAUSE TestAccTableItem_updateWithRangeKey
=== RUN   TestAccTableItem_disappears
=== PAUSE TestAccTableItem_disappears
=== CONT  TestAccTableItem_basic
=== CONT  TestAccTableItem_update
=== CONT  TestAccTableItem_withMultipleItems
=== CONT  TestAccTableItem_wonkyItems
=== CONT  TestAccTableItem_disappears
=== CONT  TestAccTableItem_updateWithRangeKey
=== CONT  TestAccTableItem_rangeKey
--- PASS: TestAccTableItem_wonkyItems (17.43s)
--- PASS: TestAccTableItem_disappears (20.71s)
--- PASS: TestAccTableItem_withMultipleItems (21.02s)
--- PASS: TestAccTableItem_basic (21.02s)
--- PASS: TestAccTableItem_rangeKey (22.57s)
--- PASS: TestAccTableItem_updateWithRangeKey (27.90s)
--- PASS: TestAccTableItem_update (29.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	31.577s
...

@github-actions github-actions bot added service/dynamodb Issues and PRs that pertain to the dynamodb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. labels Jun 14, 2022
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Jun 14, 2022
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Jun 14, 2022
@johnsonaj johnsonaj marked this pull request as ready for review June 14, 2022 17:41
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Output of acceptance tests:

make testacc TESTARGS='-run=TestAccTableItem_' PKG=dynamodb
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dynamodb/... -v -count 1 -parallel 20  -run=TestAccTableItem_ -timeout 180m
=== RUN   TestAccTableItem_basic
=== PAUSE TestAccTableItem_basic
=== RUN   TestAccTableItem_rangeKey
=== PAUSE TestAccTableItem_rangeKey
=== RUN   TestAccTableItem_withMultipleItems
=== PAUSE TestAccTableItem_withMultipleItems
=== RUN   TestAccTableItem_wonkyItems
=== PAUSE TestAccTableItem_wonkyItems
=== RUN   TestAccTableItem_update
=== PAUSE TestAccTableItem_update
=== RUN   TestAccTableItem_updateWithRangeKey
=== PAUSE TestAccTableItem_updateWithRangeKey
=== RUN   TestAccTableItem_disappears
=== PAUSE TestAccTableItem_disappears
=== CONT  TestAccTableItem_basic
=== CONT  TestAccTableItem_update
=== CONT  TestAccTableItem_withMultipleItems
=== CONT  TestAccTableItem_rangeKey
=== CONT  TestAccTableItem_disappears
=== CONT  TestAccTableItem_wonkyItems
=== CONT  TestAccTableItem_updateWithRangeKey
--- PASS: TestAccTableItem_basic (27.12s)
--- PASS: TestAccTableItem_withMultipleItems (27.51s)
--- PASS: TestAccTableItem_disappears (28.01s)
--- PASS: TestAccTableItem_rangeKey (28.10s)
--- PASS: TestAccTableItem_wonkyItems (28.17s)
--- PASS: TestAccTableItem_updateWithRangeKey (39.55s)
--- PASS: TestAccTableItem_update (41.20s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	44.288s

@johnsonaj johnsonaj merged commit 9b3b6f2 into main Jun 14, 2022
@johnsonaj johnsonaj deleted the b-aws_dynamodb_table_item_update branch June 14, 2022 20:45
@github-actions github-actions bot added this to the v4.19.0 milestone Jun 14, 2022
github-actions bot pushed a commit that referenced this pull request Jun 14, 2022
@github-actions
Copy link

This functionality has been released in v4.19.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/dynamodb Issues and PRs that pertain to the dynamodb service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dynamodb_table_item does not update after change is made
2 participants