-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: pass fleet & stack in correct order #25370
bugfix: pass fleet & stack in correct order #25370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @mherzig 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccAppStreamFleetStackAssociation PKG=appstream ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appstream/... -v -count 1 -parallel 3 -run='TestAccAppStreamFleetStackAssociation' -timeout 180m
=== RUN TestAccAppStreamFleetStackAssociation_basic
=== PAUSE TestAccAppStreamFleetStackAssociation_basic
=== RUN TestAccAppStreamFleetStackAssociation_disappears
=== PAUSE TestAccAppStreamFleetStackAssociation_disappears
=== CONT TestAccAppStreamFleetStackAssociation_basic
=== CONT TestAccAppStreamFleetStackAssociation_disappears
--- PASS: TestAccAppStreamFleetStackAssociation_disappears (890.43s)
--- PASS: TestAccAppStreamFleetStackAssociation_basic (925.65s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/appstream 934.060s
@mherzig Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.21.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #22625
Fixes swapped arguments in function call to generate an ID for
aws_appstream_fleet_stack_association