bugfix: validate embed_host_domains correctly

[mherzig]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25205

Output from acceptance testing:

$ make testacc TESTS=TestAccAppStreamStack PKG=appstream 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appstream/... -v -count 1 -parallel 20 -run='TestAccAppStreamStack'  -timeout 180m
=== RUN   TestAccAppStreamStack_basic
=== PAUSE TestAccAppStreamStack_basic
=== RUN   TestAccAppStreamStack_disappears
=== PAUSE TestAccAppStreamStack_disappears
=== RUN   TestAccAppStreamStack_complete
=== PAUSE TestAccAppStreamStack_complete
=== RUN   TestAccAppStreamStack_withTags
=== PAUSE TestAccAppStreamStack_withTags
=== CONT  TestAccAppStreamStack_basic
=== CONT  TestAccAppStreamStack_complete
=== CONT  TestAccAppStreamStack_disappears
=== CONT  TestAccAppStreamStack_withTags
--- PASS: TestAccAppStreamStack_disappears (6.92s)
--- PASS: TestAccAppStreamStack_basic (12.82s)
--- PASS: TestAccAppStreamStack_withTags (24.32s)
--- PASS: TestAccAppStreamStack_complete (25.81s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appstream  27.388s

The embed_host_domains path was validated incorrectly, and any plan that used it crashed. This fixes it so that it validates the paths as a set, not a list.

[ewbankkit]

LGTM 🚀.

% make testacc TESTS=TestAccAppStreamStack PKG=appstream ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appstream/... -v -count 1 -parallel 3 -run='TestAccAppStreamStack'  -timeout 180m
=== RUN   TestAccAppStreamStack_basic
=== PAUSE TestAccAppStreamStack_basic
=== RUN   TestAccAppStreamStack_disappears
=== PAUSE TestAccAppStreamStack_disappears
=== RUN   TestAccAppStreamStack_complete
=== PAUSE TestAccAppStreamStack_complete
=== RUN   TestAccAppStreamStack_withTags
=== PAUSE TestAccAppStreamStack_withTags
=== CONT  TestAccAppStreamStack_basic
=== CONT  TestAccAppStreamStack_complete
=== CONT  TestAccAppStreamStack_disappears
--- PASS: TestAccAppStreamStack_disappears (15.08s)
=== CONT  TestAccAppStreamStack_withTags
--- PASS: TestAccAppStreamStack_basic (22.56s)
--- PASS: TestAccAppStreamStack_complete (38.67s)
--- PASS: TestAccAppStreamStack_withTags (35.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appstream	54.601s

[ewbankkit]

@mherzig Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.21.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.