Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_launch_configuration: No default for associate_public_ip_address #25450

Merged
merged 5 commits into from
Jun 17, 2022
Merged

r/aws_launch_configuration: No default for associate_public_ip_address #25450

merged 5 commits into from
Jun 17, 2022

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jun 17, 2022 •
edited

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25244.
Closes #25252.
Relates #17695.

Removes the default value for associate_public_ip_address argument and marks it as Computed.
This allows the pre-v4.17.0 behavior of no configured value triggering the API default behavior to be restored whilst also allowing a configured value of false to override the subnet's setting.

% make testacc TESTARGS='-run=TestAccAutoScalingLaunchConfiguration_' PKG=autoscaling ACCTEST_PARALLELISM=3 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 3  -run=TestAccAutoScalingLaunchConfiguration_ -timeout 180m
=== RUN   TestAccAutoScalingLaunchConfiguration_basic
=== PAUSE TestAccAutoScalingLaunchConfiguration_basic
=== RUN   TestAccAutoScalingLaunchConfiguration_disappears
=== PAUSE TestAccAutoScalingLaunchConfiguration_disappears
=== RUN   TestAccAutoScalingLaunchConfiguration_Name_generated
=== PAUSE TestAccAutoScalingLaunchConfiguration_Name_generated
=== RUN   TestAccAutoScalingLaunchConfiguration_namePrefix
=== PAUSE TestAccAutoScalingLaunchConfiguration_namePrefix
=== RUN   TestAccAutoScalingLaunchConfiguration_withBlockDevices
=== PAUSE TestAccAutoScalingLaunchConfiguration_withBlockDevices
=== RUN   TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI
=== PAUSE TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI
=== RUN   TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears
=== PAUSE TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears
=== RUN   TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize
=== PAUSE TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize
=== RUN   TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice
=== PAUSE TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice
=== RUN   TestAccAutoScalingLaunchConfiguration_withSpotPrice
=== PAUSE TestAccAutoScalingLaunchConfiguration_withSpotPrice
=== RUN   TestAccAutoScalingLaunchConfiguration_withVPCClassicLink
=== PAUSE TestAccAutoScalingLaunchConfiguration_withVPCClassicLink
=== RUN   TestAccAutoScalingLaunchConfiguration_withIAMProfile
=== PAUSE TestAccAutoScalingLaunchConfiguration_withIAMProfile
=== RUN   TestAccAutoScalingLaunchConfiguration_withGP3
=== PAUSE TestAccAutoScalingLaunchConfiguration_withGP3
=== RUN   TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice
=== PAUSE TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice
=== RUN   TestAccAutoScalingLaunchConfiguration_metadataOptions
=== PAUSE TestAccAutoScalingLaunchConfiguration_metadataOptions
=== RUN   TestAccAutoScalingLaunchConfiguration_EBS_noDevice
=== PAUSE TestAccAutoScalingLaunchConfiguration_EBS_noDevice
=== RUN   TestAccAutoScalingLaunchConfiguration_userData
=== PAUSE TestAccAutoScalingLaunchConfiguration_userData
=== RUN   TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigNull
=== PAUSE TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigNull
=== RUN   TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigFalse
=== PAUSE TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigFalse
=== RUN   TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigTrue
=== PAUSE TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigTrue
=== RUN   TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigNull
=== PAUSE TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigNull
=== RUN   TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigFalse
=== PAUSE TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigFalse
=== RUN   TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigTrue
=== PAUSE TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigTrue
=== CONT  TestAccAutoScalingLaunchConfiguration_basic
=== CONT  TestAccAutoScalingLaunchConfiguration_withGP3
=== CONT  TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigFalse
--- PASS: TestAccAutoScalingLaunchConfiguration_withGP3 (51.95s)
=== CONT  TestAccAutoScalingLaunchConfiguration_EBS_noDevice
--- PASS: TestAccAutoScalingLaunchConfiguration_basic (52.84s)
=== CONT  TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigNull
--- PASS: TestAccAutoScalingLaunchConfiguration_EBS_noDevice (48.63s)
=== CONT  TestAccAutoScalingLaunchConfiguration_userData
--- PASS: TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigFalse (171.74s)
=== CONT  TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears
--- PASS: TestAccAutoScalingLaunchConfiguration_userData (89.17s)
=== CONT  TestAccAutoScalingLaunchConfiguration_withIAMProfile
--- PASS: TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigNull (155.48s)
=== CONT  TestAccAutoScalingLaunchConfiguration_withVPCClassicLink
--- PASS: TestAccAutoScalingLaunchConfiguration_withIAMProfile (56.83s)
=== CONT  TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigFalse
--- PASS: TestAccAutoScalingLaunchConfiguration_withVPCClassicLink (54.83s)
=== CONT  TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigTrue
--- PASS: TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigFalse (172.01s)
=== CONT  TestAccAutoScalingLaunchConfiguration_metadataOptions
--- PASS: TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigTrue (183.60s)
=== CONT  TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigNull
--- PASS: TestAccAutoScalingLaunchConfiguration_metadataOptions (51.27s)
=== CONT  TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice
--- PASS: TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice (87.86s)
=== CONT  TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice
--- PASS: TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears (408.65s)
=== CONT  TestAccAutoScalingLaunchConfiguration_withSpotPrice
--- PASS: TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice (47.18s)
=== CONT  TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize
--- PASS: TestAccAutoScalingLaunchConfiguration_withSpotPrice (46.38s)
=== CONT  TestAccAutoScalingLaunchConfiguration_namePrefix
--- PASS: TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigNull (183.17s)
=== CONT  TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI
--- PASS: TestAccAutoScalingLaunchConfiguration_namePrefix (48.83s)
=== CONT  TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigTrue
--- PASS: TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI (63.24s)
=== CONT  TestAccAutoScalingLaunchConfiguration_Name_generated
--- PASS: TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize (90.73s)
=== CONT  TestAccAutoScalingLaunchConfiguration_withBlockDevices
--- PASS: TestAccAutoScalingLaunchConfiguration_Name_generated (50.08s)
=== CONT  TestAccAutoScalingLaunchConfiguration_disappears
--- PASS: TestAccAutoScalingLaunchConfiguration_withBlockDevices (51.07s)
--- PASS: TestAccAutoScalingLaunchConfiguration_disappears (41.80s)
--- PASS: TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigTrue (159.81s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	839.362s

@ewbankkit
r/aws_launch_configuration: Additional tests for 'associate_public_ip…
5420399 
…_address'.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_' PKG=autoscaling ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2  -run=TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_ -timeout 180m
=== RUN   TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigNull
=== PAUSE TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigNull
=== RUN   TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigFalse
=== PAUSE TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigFalse
=== RUN   TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigTrue
=== PAUSE TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigTrue
=== RUN   TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigNull
=== PAUSE TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigNull
=== RUN   TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigFalse
=== PAUSE TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigFalse
=== RUN   TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigTrue
=== PAUSE TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigTrue
=== CONT  TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigNull
=== CONT  TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigNull
    launch_configuration_test.go:698: Step 1/2 error: Check failed: Check 4/4 error: i-04282ae7bd585f800 has public IP address; got false, expected true
--- PASS: TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigNull (175.54s)
=== CONT  TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigTrue
--- FAIL: TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigNull (221.09s)
=== CONT  TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigTrue
--- PASS: TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigTrue (186.39s)
=== CONT  TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigFalse
--- PASS: TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigTrue (147.57s)
=== CONT  TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigFalse
--- PASS: TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigFalse (160.34s)
--- PASS: TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigFalse (185.05s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	550.974s
FAIL
make: *** [testacc] Error 1
@ewbankkit
r/aws_launch_configuration: Remove default value for 'associate_publi…
ada1fab 
…c_ip_address' (amd mark as Computed).

Acceptance test output:

% make testacc TESTARGS='-run=TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_' PKG=autoscaling ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2  -run=TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_ -timeout 180m
=== RUN   TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigNull
=== PAUSE TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigNull
=== RUN   TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigFalse
=== PAUSE TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigFalse
=== RUN   TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigTrue
=== PAUSE TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigTrue
=== RUN   TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigNull
=== PAUSE TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigNull
=== RUN   TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigFalse
=== PAUSE TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigFalse
=== RUN   TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigTrue
=== PAUSE TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigTrue
=== CONT  TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigNull
=== CONT  TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigNull
--- PASS: TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigNull (157.31s)
=== CONT  TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigTrue
--- PASS: TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigNull (183.34s)
=== CONT  TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigFalse
--- PASS: TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigFalse (154.65s)
=== CONT  TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigTrue
--- PASS: TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigTrue (196.07s)
=== CONT  TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigFalse
--- PASS: TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigTrue (142.93s)
--- PASS: TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigFalse (149.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	506.726s
@ewbankkit
'name_prefix' -> 'name'.
9862347
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. service/autoscaling Issues and PRs that pertain to the autoscaling service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 17, 2022
@ewbankkit
Copy link
Contributor Author 

==> Checking source code with golangci-lint...
==> Checking source code with providerlint...

@ewbankkit ewbankkit changed the title [WIP] r/aws_launch_configuration: No default for associate_public_ip_address r/aws_launch_configuration: No default for associate_public_ip_address Jun 17, 2022
@YakDriver YakDriver self-assigned this Jun 17, 2022
YakDriver
YakDriver approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc TESTARGS='-run=TestAccAutoScalingLaunchConfiguration_' PKG=autoscaling ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 3  -run=TestAccAutoScalingLaunchConfiguration_ -timeout 180m
=== RUN   TestAccAutoScalingLaunchConfiguration_basic
=== PAUSE TestAccAutoScalingLaunchConfiguration_basic
=== RUN   TestAccAutoScalingLaunchConfiguration_disappears
=== PAUSE TestAccAutoScalingLaunchConfiguration_disappears
=== RUN   TestAccAutoScalingLaunchConfiguration_Name_generated
=== PAUSE TestAccAutoScalingLaunchConfiguration_Name_generated
=== RUN   TestAccAutoScalingLaunchConfiguration_namePrefix
=== PAUSE TestAccAutoScalingLaunchConfiguration_namePrefix
=== RUN   TestAccAutoScalingLaunchConfiguration_withBlockDevices
=== PAUSE TestAccAutoScalingLaunchConfiguration_withBlockDevices
=== RUN   TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI
=== PAUSE TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI
=== RUN   TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears
=== PAUSE TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears
=== RUN   TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize
=== PAUSE TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize
=== RUN   TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice
=== PAUSE TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice
=== RUN   TestAccAutoScalingLaunchConfiguration_withSpotPrice
=== PAUSE TestAccAutoScalingLaunchConfiguration_withSpotPrice
=== RUN   TestAccAutoScalingLaunchConfiguration_withVPCClassicLink
=== PAUSE TestAccAutoScalingLaunchConfiguration_withVPCClassicLink
=== RUN   TestAccAutoScalingLaunchConfiguration_withIAMProfile
=== PAUSE TestAccAutoScalingLaunchConfiguration_withIAMProfile
=== RUN   TestAccAutoScalingLaunchConfiguration_withGP3
=== PAUSE TestAccAutoScalingLaunchConfiguration_withGP3
=== RUN   TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice
=== PAUSE TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice
=== RUN   TestAccAutoScalingLaunchConfiguration_metadataOptions
=== PAUSE TestAccAutoScalingLaunchConfiguration_metadataOptions
=== RUN   TestAccAutoScalingLaunchConfiguration_EBS_noDevice
=== PAUSE TestAccAutoScalingLaunchConfiguration_EBS_noDevice
=== RUN   TestAccAutoScalingLaunchConfiguration_userData
=== PAUSE TestAccAutoScalingLaunchConfiguration_userData
=== RUN   TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigNull
=== PAUSE TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigNull
=== RUN   TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigFalse
=== PAUSE TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigFalse
=== RUN   TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigTrue
=== PAUSE TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigTrue
=== RUN   TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigNull
=== PAUSE TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigNull
=== RUN   TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigFalse
=== PAUSE TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigFalse
=== RUN   TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigTrue
=== PAUSE TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigTrue
=== CONT  TestAccAutoScalingLaunchConfiguration_basic
=== CONT  TestAccAutoScalingLaunchConfiguration_withGP3
=== CONT  TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigFalse
--- PASS: TestAccAutoScalingLaunchConfiguration_withGP3 (30.41s)
=== CONT  TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigTrue
--- PASS: TestAccAutoScalingLaunchConfiguration_basic (31.37s)
=== CONT  TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigFalse
--- PASS: TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigFalse (157.16s)
=== CONT  TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigNull
--- PASS: TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigFalse (140.87s)
=== CONT  TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigTrue
--- PASS: TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigTrue (143.68s)
=== CONT  TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears
--- PASS: TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigTrue (121.10s)
=== CONT  TestAccAutoScalingLaunchConfiguration_withIAMProfile
--- PASS: TestAccAutoScalingLaunchConfiguration_withIAMProfile (40.71s)
=== CONT  TestAccAutoScalingLaunchConfiguration_withVPCClassicLink
    ec2_classic.go:56: this test can only run in EC2-Classic, platforms available in us-east-1: ["VPC"]
--- SKIP: TestAccAutoScalingLaunchConfiguration_withVPCClassicLink (0.43s)
=== CONT  TestAccAutoScalingLaunchConfiguration_withSpotPrice
--- PASS: TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetTrueConfigNull (179.02s)
=== CONT  TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice
--- PASS: TestAccAutoScalingLaunchConfiguration_withSpotPrice (27.32s)
=== CONT  TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize
--- PASS: TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice (27.14s)
=== CONT  TestAccAutoScalingLaunchConfiguration_EBS_noDevice
--- PASS: TestAccAutoScalingLaunchConfiguration_EBS_noDevice (28.31s)
=== CONT  TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigNull
--- PASS: TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize (59.78s)
=== CONT  TestAccAutoScalingLaunchConfiguration_userData
--- PASS: TestAccAutoScalingLaunchConfiguration_userData (57.90s)
=== CONT  TestAccAutoScalingLaunchConfiguration_namePrefix
--- PASS: TestAccAutoScalingLaunchConfiguration_namePrefix (28.90s)
=== CONT  TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI
--- PASS: TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI (29.25s)
=== CONT  TestAccAutoScalingLaunchConfiguration_withBlockDevices
--- PASS: TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears (371.28s)
=== CONT  TestAccAutoScalingLaunchConfiguration_Name_generated
--- PASS: TestAccAutoScalingLaunchConfiguration_AssociatePublicIPAddress_subnetFalseConfigNull (157.49s)
=== CONT  TestAccAutoScalingLaunchConfiguration_disappears
--- PASS: TestAccAutoScalingLaunchConfiguration_withBlockDevices (28.58s)
=== CONT  TestAccAutoScalingLaunchConfiguration_metadataOptions
--- PASS: TestAccAutoScalingLaunchConfiguration_disappears (23.38s)
=== CONT  TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice
--- PASS: TestAccAutoScalingLaunchConfiguration_Name_generated (28.27s)
--- PASS: TestAccAutoScalingLaunchConfiguration_metadataOptions (29.47s)
--- PASS: TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice (57.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	631.217s

@ewbankkit ewbankkit merged commit 245dd13 into main Jun 17, 2022
@ewbankkit ewbankkit deleted the b-aws_launch_configuration-associate_public_ip_address branch June 17, 2022 22:16
@github-actions github-actions bot added this to the v4.20.0 milestone Jun 17, 2022
github-actions bot pushed a commit that referenced this pull request Jun 17, 2022
Update CHANGELOG.md for #25450
35aeb01
@github-actions
Copy link

This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
service/autoscaling Issues and PRs that pertain to the autoscaling service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.20.0
2 participants
@ewbankkit @YakDriver