Ec2host outpostarn

[silvaalbert]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25410

Output from acceptance testing:

$ make testacc TESTS='TestAccHost_outpost' PKG=ec2 TESTARGS=-short                    2 ✘  16s
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccHost_outpost' -short -timeout 180m
=== RUN   TestAccHost_outpost
=== PAUSE TestAccHost_outpost
=== CONT  TestAccHost_outpost
--- PASS: TestAccHost_outpost (20.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	22.960s



$ make testacc TESTS='TestAccEC2HostDataSource_outpost' PKG=ec2 TESTARGS=-short         ✔  17s
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2HostDataSource_outpost' -short -timeout 180m
=== RUN   TestAccEC2HostDataSource_outpost
=== PAUSE TestAccEC2HostDataSource_outpost
=== CONT  TestAccEC2HostDataSource_outpost
--- PASS: TestAccEC2HostDataSource_outpost (16.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	18.959s

...

[github-actions]

Welcome @silvaalbert 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEC2Host' PKG=ec2 ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 1  -run=TestAccEC2Host -timeout 180m
=== RUN   TestAccEC2HostDataSource_basic
=== PAUSE TestAccEC2HostDataSource_basic
=== RUN   TestAccEC2HostDataSource_filter
=== PAUSE TestAccEC2HostDataSource_filter
=== RUN   TestAccEC2Host_basic
=== PAUSE TestAccEC2Host_basic
=== RUN   TestAccEC2Host_disappears
=== PAUSE TestAccEC2Host_disappears
=== RUN   TestAccEC2Host_instanceFamily
=== PAUSE TestAccEC2Host_instanceFamily
=== RUN   TestAccEC2Host_tags
=== PAUSE TestAccEC2Host_tags
=== RUN   TestAccEC2Host_outpost
=== PAUSE TestAccEC2Host_outpost
=== CONT  TestAccEC2HostDataSource_basic
--- PASS: TestAccEC2HostDataSource_basic (15.85s)
=== CONT  TestAccEC2Host_instanceFamily
    ec2_host_test.go:78: Step 1/3 error: Error running apply: exit status 1
        
        Error: error allocating EC2 Host: HostLimitExceeded: The number of Dedicated hosts you've requested (1) would bring your total up to 1 for the specified group of instance types (c5). This exceeds your current limit of 2. If you've recently released Dedicated hosts, it may take some time for them to stop counting towards your limit. Try allocating your hosts again after a few minutes. Please visit http://aws.amazon.com/contact-us/ec2-request to request an adjustment to this limit.
        	status code: 400, request id: b9849a64-be9e-4642-a5e3-f3addc89bbef
        
          with aws_ec2_host.test,
          on terraform_plugin_test.tf line 11, in resource "aws_ec2_host" "test":
          11: resource "aws_ec2_host" "test" {
        
--- FAIL: TestAccEC2Host_instanceFamily (6.48s)
=== CONT  TestAccEC2Host_outpost
    acctest.go:1308: skipping since no Outposts found
--- SKIP: TestAccEC2Host_outpost (0.58s)
=== CONT  TestAccEC2Host_tags
--- PASS: TestAccEC2Host_tags (38.21s)
=== CONT  TestAccEC2Host_basic
--- PASS: TestAccEC2Host_basic (15.17s)
=== CONT  TestAccEC2Host_disappears
    ec2_host_test.go:55: Step 1/1 error: Error running apply: exit status 1
        
        Error: error allocating EC2 Host: HostLimitExceeded: The number of Dedicated hosts you've requested (1) would bring your total up to 3 for the specified group of instance types (a1). This exceeds your current limit of 2. If you've recently released Dedicated hosts, it may take some time for them to stop counting towards your limit. Try allocating your hosts again after a few minutes. Please visit http://aws.amazon.com/contact-us/ec2-request to request an adjustment to this limit.
        	status code: 400, request id: 70f57415-a5a7-464c-a642-4acc772f3c0d
        
          with aws_ec2_host.test,
          on terraform_plugin_test.tf line 11, in resource "aws_ec2_host" "test":
          11: resource "aws_ec2_host" "test" {
        
--- FAIL: TestAccEC2Host_disappears (5.65s)
=== CONT  TestAccEC2HostDataSource_filter
    ec2_host_data_source_test.go:50: Step 1/1 error: Error running apply: exit status 1
        
        Error: error allocating EC2 Host: HostLimitExceeded: The number of Dedicated hosts you've requested (1) would bring your total up to 3 for the specified group of instance types (a1). This exceeds your current limit of 2. If you've recently released Dedicated hosts, it may take some time for them to stop counting towards your limit. Try allocating your hosts again after a few minutes. Please visit http://aws.amazon.com/contact-us/ec2-request to request an adjustment to this limit.
        	status code: 400, request id: d939ded7-e812-4c7a-babf-70d3ecccbe30
        
          with aws_ec2_host.test,
          on terraform_plugin_test.tf line 11, in resource "aws_ec2_host" "test":
          11: resource "aws_ec2_host" "test" {
        
--- FAIL: TestAccEC2HostDataSource_filter (5.62s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	91.595s
FAIL
make: *** [testacc] Error 1

Failures are unrelated to this change.

[ewbankkit]

% make semall
==> Running Semgrep checks locally (must have semgrep installed)...
Scanning 3982 files with 37 go rules.
  100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████|3982/3982 tasks

Some files were skipped or only partially analyzed.
  Scan was limited to files tracked by git.
  Scan skipped: 1613 files matching .semgrepignore patterns
  For a full list of skipped files, run semgrep with the --verbose flag.

Ran 37 rules on 3982 files: 0 findings.
If Semgrep missed a finding, please send us feedback to let us know!
  $ semgrep shouldafound --help

A new version of Semgrep is available. See https://semgrep.dev/docs/upgrading
Scanning 957 files with 199 go rules.
  100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████|957/957 tasks

Some files were skipped or only partially analyzed.
  Scan was limited to files tracked by git.
  Scan skipped: 1613 files matching .semgrepignore patterns
  For a full list of skipped files, run semgrep with the --verbose flag.

Ran 199 rules on 957 files: 0 findings.
If Semgrep missed a finding, please send us feedback to let us know!
  $ semgrep shouldafound --help

A new version of Semgrep is available. See https://semgrep.dev/docs/upgrading
Scanning 1078 files with 197 go rules.
  100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████|1078/1078 tasks

Some files were skipped or only partially analyzed.
  Scan was limited to files tracked by git.
  Scan skipped: 1613 files matching .semgrepignore patterns
  For a full list of skipped files, run semgrep with the --verbose flag.

Ran 198 rules on 1078 files: 0 findings.
If Semgrep missed a finding, please send us feedback to let us know!
  $ semgrep shouldafound --help

A new version of Semgrep is available. See https://semgrep.dev/docs/upgrading
Scanning 779 files with 194 go rules.
  100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████|779/779 tasks

Some files were skipped or only partially analyzed.
  Scan was limited to files tracked by git.
  Scan skipped: 1613 files matching .semgrepignore patterns
  For a full list of skipped files, run semgrep with the --verbose flag.

Ran 198 rules on 779 files: 0 findings.
If Semgrep missed a finding, please send us feedback to let us know!
  $ semgrep shouldafound --help

A new version of Semgrep is available. See https://semgrep.dev/docs/upgrading
Scanning 1104 files with 198 go rules.
  100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████|1104/1104 tasks

Some files were skipped or only partially analyzed.
  Scan was limited to files tracked by git.
  Scan skipped: 1613 files matching .semgrepignore patterns
  For a full list of skipped files, run semgrep with the --verbose flag.

Ran 198 rules on 1104 files: 0 findings.
If Semgrep missed a finding, please send us feedback to let us know!
  $ semgrep shouldafound --help

A new version of Semgrep is available. See https://semgrep.dev/docs/upgrading

[ewbankkit]

@silvaalbert Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.