-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_cost_categories: Fix parameter expansion and update values type to schema.TypeList #25488
r/aws_cost_categories: Fix parameter expansion and update values type to schema.TypeList #25488
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @joakimhew 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccCECostCategory_' PKG=ce ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ce/... -v -count 1 -parallel 2 -run=TestAccCECostCategory_ -timeout 180m
=== RUN TestAccCECostCategory_basic
=== PAUSE TestAccCECostCategory_basic
=== RUN TestAccCECostCategory_complete
=== PAUSE TestAccCECostCategory_complete
=== RUN TestAccCECostCategory_splitCharge
=== PAUSE TestAccCECostCategory_splitCharge
=== RUN TestAccCECostCategory_disappears
=== PAUSE TestAccCECostCategory_disappears
=== CONT TestAccCECostCategory_basic
=== CONT TestAccCECostCategory_splitCharge
--- PASS: TestAccCECostCategory_basic (22.68s)
=== CONT TestAccCECostCategory_disappears
--- PASS: TestAccCECostCategory_disappears (16.90s)
=== CONT TestAccCECostCategory_complete
--- PASS: TestAccCECostCategory_splitCharge (41.44s)
--- PASS: TestAccCECostCategory_complete (29.03s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ce 77.768s
@joakimhew Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
This PR closes #25487 and fixes an issue where the
cost_category
schema (split_charge_rule.parameter.values
) is of incorrect type as well as incorrect implementation ofexpandCostCategorySplitChargeRuleParameter
where it's trying to expand non-existent fieldmethod
while it should be expandingtype
Output from acceptance testing: