add data source for aws_route53_resolver_firewall_domain_list #25509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvaalbert
changed the title
github-actions
bot
added
needs-triage
github-actions
bot
added
size/L
github-actions
bot
added
the
documentation
silvaalbert
changed the title
AdamTylerLynch
suggested changes
Jun 21, 2022
There was a problem hiding this comment.
A few changes requested.
I would like to get @ewbankkit's opinion:
The ResourceFirewallDomainList exposes a list of domains, I feel that should be exposed in the following ways in the data source.
- Domains attribute for the selected FirewallDomainList
- Ability to filter FirewallDomainList(s) by associated Domain (www.example.com).
Thoughts?
internal/service/route53resolver/firewall_domain_list_data_source.go
Outdated
Show resolved
Hide resolved
internal/service/route53resolver/firewall_domain_list_data_source.go
Outdated
Show resolved
Hide resolved
internal/service/route53resolver/firewall_domain_list_data_source.go
Outdated
Show resolved
Hide resolved
internal/service/route53resolver/firewall_domain_list_data_source.go
Outdated
Show resolved
Hide resolved
silvaalbert
changed the title
justinretzolk
added
new-data-source
…_list_id'. Acceptance test output: % make testacc TESTARGS='-run=TestAccRoute53ResolverFirewallDomainListDataSource_' PKG=route53resolver ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 2 -run=TestAccRoute53ResolverFirewallDomainListDataSource_ -timeout 180m === RUN TestAccRoute53ResolverFirewallDomainListDataSource_basic --- PASS: TestAccRoute53ResolverFirewallDomainListDataSource_basic (100.53s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver 107.003s
…t' CRUD handlers (hashicorp#15090). Acceptance test output: % make testacc TESTARGS='-run=TestAccRoute53ResolverFirewallDomainListDataSource_' PKG=route53resolver ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 2 -run=TestAccRoute53ResolverFirewallDomainListDataSource_ -timeout 180m === RUN TestAccRoute53ResolverFirewallDomainListDataSource_basic --- PASS: TestAccRoute53ResolverFirewallDomainListDataSource_basic (90.40s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver 96.375s
ewbankkit
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRoute53ResolverFirewallDomainListDataSource_' PKG=route53resolver ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 2 -run=TestAccRoute53ResolverFirewallDomainListDataSource_ -timeout 180m
=== RUN TestAccRoute53ResolverFirewallDomainListDataSource_basic
--- PASS: TestAccRoute53ResolverFirewallDomainListDataSource_basic (90.40s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver 96.375s
|
@silvaalbert Thanks for the contribution 🎉 👏. |
|
This functionality has been released in v4.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #25492
Output from acceptance testing: